From: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>
To: "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] test-pmd: Free of address-of expression
Date: Tue, 17 May 2016 07:55:54 +0000 [thread overview]
Message-ID: <158888A50F43E34AAE179517F56C97455A52C6@IRSMSX103.ger.corp.intel.com> (raw)
Hi,
Noticed is that in the file:
app/test-pmd/mempool.c
using of the function munmap() could cause a problem.
Coverity static code analyzer provide error (CID 13184) in line 158:
munmap frees incorrect pointer uv.
I noticed information on the net:
https://www.ibm.com/support/knowledgecenter/SSLTBW_2.1.0/com.ibm.zos.v2r1.bpxbd00/mumap.htm
"If addr is not the address of a mapping established by a prior call to mmap(), the behavior is undefined"
I have analyzed the code and I have done some test with gcc.
It seems that it is possible to free subrange of the mapping memory.
In the mempool.c code the address is calculated independently.
Anyway in my opinion the address variable uv is calculated correctly.
So we should classify this issue as a False Positive.
Please accept the conclusion.
Slawomir Mrozowicz
Sii Engineer
Delivering outsourced services to Intel
Intel Technology Poland sp. z o.o. - KRS 101882 - ul. Slowackiego 173, 80-298 Gdansk
next reply other threads:[~2016-05-17 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 7:55 Mrozowicz, SlawomirX [this message]
2016-05-17 8:16 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158888A50F43E34AAE179517F56C97455A52C6@IRSMSX103.ger.corp.intel.com \
--to=slawomirx.mrozowicz@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).