From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BB41CA04A4;
Tue, 26 May 2020 11:02:31 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A27AB1DA29;
Tue, 26 May 2020 11:02:22 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by dpdk.org (Postfix) with ESMTP id 819241DA1D
for <dev@dpdk.org>; Tue, 26 May 2020 11:02:20 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12C191FB;
Tue, 26 May 2020 02:02:20 -0700 (PDT)
Received: from phil-VirtualBox.shanghai.arm.com
(phil-VirtualBox.shanghai.arm.com [10.169.109.151])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 12F583F52E;
Tue, 26 May 2020 02:02:12 -0700 (PDT)
From: Phil Yang <phil.yang@arm.com>
To: dev@dpdk.org
Cc: mattias.ronnblom@ericsson.com, mb@smartsharesystems.com,
stephen@networkplumber.org, thomas@monjalon.net,
bruce.richardson@intel.com, ferruh.yigit@intel.com, hemant.agrawal@nxp.com,
jerinj@marvell.com, ktraynor@redhat.com, konstantin.ananyev@intel.com,
maxime.coquelin@redhat.com, olivier.matz@6wind.com,
harry.van.haaren@intel.com, erik.g.carrillo@intel.com,
drc@linux.vnet.ibm.com, david.marchand@redhat.com, zhaoyan.chen@intel.com,
ola.liljedahl@arm.com, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com,
phil.yang@arm.com, nd@arm.com
Date: Tue, 26 May 2020 17:01:06 +0800
Message-Id: <1590483667-10318-4-git-send-email-phil.yang@arm.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1590483667-10318-1-git-send-email-phil.yang@arm.com>
References: <1589270586-4480-1-git-send-email-phil.yang@arm.com>
<1590483667-10318-1-git-send-email-phil.yang@arm.com>
Subject: [dpdk-dev] [PATCH v5 3/4] devtools: prevent use of rte atomic APIs
in future patches
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
In order to deprecate the rte_atomic APIs, prevent the patches from
using rte_atomic APIs in the converted modules and compilers __sync
built-ins in all modules.
The converted modules:
lib/librte_distributor
lib/librte_hash
lib/librte_kni
lib/librte_lpm
lib/librte_rcu
lib/librte_ring
lib/librte_stack
lib/librte_vhost
lib/librte_timer
lib/librte_ipsec
drivers/event/octeontx
drivers/event/octeontx2
drivers/event/opdl
drivers/net/bnx2x
drivers/net/hinic
drivers/net/hns3
drivers/net/memif
drivers/net/thunderx
drivers/net/virtio
examples/l2fwd-event
On x86 the __atomic_thread_fence(__ATOMIC_SEQ_CST) is quite expensive
for SMP case. Flag the new code which use SEQ_CST memory ordering in
__atomic_thread_fence API.
Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
devtools/checkpatches.sh | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 158087f..5983f05 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -69,6 +69,38 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # refrain from new additions of 16/32/64 bits rte_atomic_xxx()
+ # multiple folders and expressions are separated by spaces
+ awk -v FOLDERS="lib/librte_distributor lib/librte_hash lib/librte_kni
+ lib/librte_lpm lib/librte_rcu lib/librte_ring
+ lib/librte_stack lib/librte_vhost drivers/event/octeontx
+ drivers/event/octeontx2 drivers/event/opdl
+ drivers/net/bnx2x drivers/net/hinic drivers/net/hns3
+ drivers/net/memif drivers/net/thunderx
+ drivers/net/virtio examples/l2fwd-event" \
+ -v EXPRESSIONS="rte_atomic[0-9][0-9]_.*\\\(" \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Use of rte_atomicNN_xxx APIs not allowed, use __atomic_xxx APIs' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
+ # refrain from using compiler __sync built-ins
+ awk -v FOLDERS="lib drivers app examples" \
+ -v EXPRESSIONS="__sync_.*\\\(" \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Use of __sync_xxx built-ins not allowed, use __atomic_xxx APIs' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
+ # refrain from using compiler __atomic_thread_fence(__ATOMIC_SEQ_CST)
+ # It should be avoided on x86 for SMP case.
+ awk -v FOLDERS="lib drivers app examples" \
+ -v EXPRESSIONS="__atomic_thread_fence\\\(__ATOMIC_SEQ_CST" \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Use of __atomic_thread_fence with SEQ_CST ordering is not allowed, use rte_atomic_thread_fence' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# svg figures must be included with wildcard extension
# because of png conversion for pdf docs
awk -v FOLDERS='doc' \
--
2.7.4