From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9A6721B5B3 for ; Thu, 10 Jan 2019 00:41:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1A427236D8; Wed, 9 Jan 2019 18:41:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 Jan 2019 18:41:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=iv4o/Q9vf6w8Y52t1FAL93uckzwQCW0GnTzu2NJHcdE=; b=gJ8CyxMbl5hg dOAgdvbEO2qnw71+ubSM5RiWMRLdJLWNPcK4DkwbQOgDfKsQ73QtCUzD7RxCExEv Gj3B1+pbeBPdCO56XDLo3bGic0W1arwqYADhC0x+wmdtc8JGTDioWIGbDjAuTMM1 3OZguKKx+5xMAj2au8BKS0XnX2y37rE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=iv4o/Q9vf6w8Y52t1FAL93uckzwQCW0GnTzu2NJHc dE=; b=LG1S568w90Ytv46CzOXWmCfwFDdl+Hd14LhJx6/kYONs5l/gopV7hojl0 oLlejth1bx4zU2Tgqdgv9bszkzQOWJTuvLo2c+524i8sBY/dA5XkY3cDAMAoHEmO R1V5jlrYERlB8yTF2297RCjJF/JdwLIHxbfyvIKeBWF3qpKHCu/7qtJCrlwm+4V8 AYpAgHDcorI9NgsW5awGsKHcBUBNSizZ2jdBxEetQg0IlV8wvaE3z8XZyiH4QJZo lAuKgzrge0VlnWI0NKT4MSfqfMdPSTvmThyX9O0aIbnulppFSRu+uDWe6EuNSP7+ f2DtrlNV/shWNx2qL37kodVFSV1aQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedvgdduvdculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F5B0E4043; Wed, 9 Jan 2019 18:41:03 -0500 (EST) From: Thomas Monjalon To: "Ananyev, Konstantin" Cc: dev@dpdk.org, Stephen Hemminger , "akhil.goyal@nxp.com" Date: Thu, 10 Jan 2019 00:41:02 +0100 Message-ID: <1590938.LK3aT5LD3e@xps> In-Reply-To: <2601191342CEEE43887BDE71AB977258010D8FBDA7@irsmsx105.ger.corp.intel.com> References: <1546010263-16257-2-git-send-email-konstantin.ananyev@intel.com> <20190103162537.54bd1647@hermes> <2601191342CEEE43887BDE71AB977258010D8FBDA7@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata pointer into crypto sym session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 23:41:05 -0000 04/01/2019 10:29, Ananyev, Konstantin: > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Friday, January 4, 2019 12:26 AM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org; akhil.goyal@nxp.com > > Subject: Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata pointer into crypto sym session > > > > On Thu, 3 Jan 2019 20:16:17 +0000 > > Konstantin Ananyev wrote: > > > > > Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. > > > That allows upper layer to easily associate some user defined > > > data with the session. > > > > > > Signed-off-by: Konstantin Ananyev > > > Acked-by: Fiona Trahe > > > Acked-by: Mohammad Abdul Awal > > > Acked-by: Declan Doherty > > > Acked-by: Akhil Goyal > > > --- > > > lib/librte_cryptodev/rte_cryptodev.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h > > > index 4099823f1..009860e7b 100644 > > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > > @@ -954,6 +954,8 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, > > > * has a fixed algo, key, op-type, digest_len etc. > > > */ > > > struct rte_cryptodev_sym_session { > > > + uint64_t opaque_data; > > > + /**< Opaque user defined data */ > > > __extension__ void *sess_private_data[0]; > > > /**< Private symmetric session material */ > > > }; > > > > This will cause ABI breakage. > > Yes, it surely would. > That's why we submitted deprecation notice in 18.11 and got 3 acks for it. So you should remove the deprecation notice in this patch, and bump the ABI version, and update the release notes for ABI + version changes.