From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 61F5E12A8
 for <dev@dpdk.org>; Mon, 15 Jun 2015 11:13:06 +0200 (CEST)
Received: by wigg3 with SMTP id g3so70405380wig.1
 for <dev@dpdk.org>; Mon, 15 Jun 2015 02:13:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LqLkpg2dtH3NJv1YrAjoKgGqpPdMFWhDkJsM4/DeIMo=;
 b=V85eyVFYAtgleEnnbFu09J8kxCYdSRQXpOvSNMoipfvf+tH4THXfik/lee9jeetXyh
 EydoTUhRhbs94aIy1QcWEbQKJnaUi0RQItQdwiHYJLFKheSjD4JHiCX2o8P2NzC2Ophx
 rg8LqTwAXZS8qcb2fdvZdTNt+ObBjEd6YfclSsRgGIZkCzl/NqcrkgnjPSOZg4Dzng3p
 sne+YFCo1oubFBzlP7lef+FyVfC/jGRXU4aDSpxAlY7oCZMTQiD2HbhX13SqNk3lE8jV
 DaI3iKZzclYSpD/ljdd1AzYJpLL30K8lcM3pfC3N1xdF4vPRX1k3IAedbeG2zM120JmP
 rpzA==
X-Gm-Message-State: ALoCoQlqGOutX1yZb3SwC+U9om5NdneHJA+0rjoPG9Kxrr+cgZcpZFLBYItKj96ZF/Q3/EEzy6Mo
X-Received: by 10.180.95.67 with SMTP id di3mr28961299wib.78.1434359586149;
 Mon, 15 Jun 2015 02:13:06 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id q9sm14878456wix.1.2015.06.15.02.13.04
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 15 Jun 2015 02:13:05 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>,
 Pawel Wodkowski <pawelx.wodkowski@intel.com>
Date: Mon, 15 Jun 2015 11:12:08 +0200
Message-ID: <1591170.szdQAMiik7@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1432913219-11589-3-git-send-email-maciejx.t.gajdzica@intel.com>
References: <1432913219-11589-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <1432913219-11589-3-git-send-email-maciejx.t.gajdzica@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] librte_compat: fix macro deffinition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jun 2015 09:13:06 -0000

Hi,

More fixes are needed in rte_compat.h

2015-05-29 17:26, Maciej Gajdzica:
> --- a/lib/librte_compat/rte_compat.h
> +++ b/lib/librte_compat/rte_compat.h
> @@ -103,7 +103,7 @@
>  #define VERSION_SYMBOL(b, e, v)

Should be b,e,n

>  #define __vsym
>  #define BASE_SYMBOL(b, n)

Should be b,e

> -#define BIND_DEFAULT_SYMBOL(b, v)
> +#define BIND_DEFAULT_SYMBOL(b, v, n)

Should be b,e,n

This comment needs also to be fixed:
 *  BIND_DEFAULT_SYMBOL(foo, 2.1);