From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 9BDD49201 for ; Fri, 30 Oct 2015 15:59:28 +0100 (CET) Received: by wmeg8 with SMTP id g8so13854491wme.0 for ; Fri, 30 Oct 2015 07:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=jKr/JIkKXwlTvzaxt+Ty83MYXN5Z9Epsnv3P1RCgZDo=; b=LxCXZLOphiC7/Xni384ID86jRuFjyRc0bvRCEgok7CLh4zZhujWOhqsPWSFaKSGYEB FMBNYI9Dr6pXGGYDDMxZ3538Tx/nPFxc1O3ZZnV2K7bw7YdejkaUwfRrSwLQ2MXAALyU 3uWndHjUHwEZByLz1FfAuLrORxpSCqw25sEfs2GQWMzxxO1kB+8dfpwEdH5PIjAyZ1F7 ZURe2IPZri9g8w2P1VEQxC6Xwp0w7XcYyXU6G2a4d+3SRo2g5H/AHU0sgWq8P9Fu/f0q pTw4OAsu0gJEWYhFdh9y9cQE7bwGyAqtTJrzQioPhbZD+aX8mPCY/26njQDbJFoEdApa cGTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=jKr/JIkKXwlTvzaxt+Ty83MYXN5Z9Epsnv3P1RCgZDo=; b=nH0MkcWEbMmeXoAiT6jWaBMsoQJum4cMWoMqbR42MlSHX99I0B91pQit2cGTvYPS/W x9zX/QyeRP2WHhP/TLSUe0F1gCBN1j6zKXT7n0+3357iFOXWt49+958UC+eDDjEI6KKO hpo74ZmraWhxZUGIaBFPYcW+skMJA3oY22Me49GgkReNlxixHEQlx5dZbhFO8g0DiUtw THqzGK2foiaoOuva9e7JwVyzWXzSIex+jCH276/46eXTEixlUUfM00RTXh9iAgvOzp0v jfFr93V6XJZwB4ZSKwNsycYGsKKmIjyqblr1sQKRqdg2ec2pmycos2hQAPrhOLK0pGxi 9lRg== X-Gm-Message-State: ALoCoQlp/SdJLqaHr/vTVM3LQBd5bsMNjGUdwtpJTn+DfAU77mkyw8qu8I4/ljVYB+fBRj5t0RF4 X-Received: by 10.28.55.209 with SMTP id e200mr3740632wma.79.1446217168431; Fri, 30 Oct 2015 07:59:28 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id q204sm3298245wmg.4.2015.10.30.07.59.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Oct 2015 07:59:27 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Date: Fri, 30 Oct 2015 15:58:17 +0100 Message-ID: <1591890.tYYizGEdDA@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1446089865-20090-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: fix build error on old kernel doesn't support MQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 14:59:28 -0000 2015-10-30 15:40, David Marchand: > On Thu, Oct 29, 2015 at 4:37 AM, Yuanhan Liu > wrote: >=20 > > Fix build error: > > > > virtio-net.c:80:89: error: =E2=80=98VIRTIO_NET_F_MQ=E2=80=99 unde= clared here > > rte_virtio_net.h:109: error: =E2=80=98VIRTIO_NET_CTRL_MQ_VQ_PAIRS= _MAX=E2=80=99 > > undeclared here > > > > Above two virtio-net MQ macros are introduced since kernel v3.8. > > For older kernel, we should not reference them directly, hence, > > this patch introduced two wrapper macros, with proper values > > being set depending on we support MQ or not. > > > > Fixes: 19d4d7ef2a21 ("vhost-user: enable multiple queue") >=20 > Not sure about this fix line as a build error first appeared for me a= t > b09b198bfb5c ("vhost-user: announce queue number in message") Fixed > > Reported-by: Gu YongjieX > > Signed-off-by: Yuanhan Liu > > >=20 > Build restored on kernel 3.2 with this fixed applied. > Tested-by: David Marchand Applied, thanks