From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 9C7FF2BE5
 for <dev@dpdk.org>; Sat, 15 Sep 2018 22:37:54 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 38B2B167F;
 Sat, 15 Sep 2018 16:37:53 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Sat, 15 Sep 2018 16:37:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=2tx9SWgarCl/JoLjjQOtbeAvko
 t6cF37PbqdVOgmce4=; b=eYOursR/BQqWLlt+hXuD2a4/5zoYvmZKd35MRP28FY
 jFTfR2fOowpu0wZOpqiU6P15iGzvLx7rFYEXZlQRK9i6XtcVEoROjrmg12WGXOIi
 6Bzli/Z4ewbmZFsmhVePhx4ejR+oHPymG/smobFN6UcVhUtqkuG1CyUF+9huaiJS
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=2tx9SW
 garCl/JoLjjQOtbeAvkot6cF37PbqdVOgmce4=; b=EVMQTyWdtIc1gxMBNi3Fdt
 0Qdjk/uG5USrJYRORLgM9JLVDTQG3cewMk9i0sdSy4ymqsqCLGvzG51fKuEoyBOy
 YTm20DPK44BL1FzB1yY2X+JMlqEmWAtC21nSlZ04pm1FDvttNOiMVBy1PTTeh37L
 0ik71NArUlA0AU8WQ3LdI7+8iLRobleC566qPw3v1PkV5YQu29qHZ7nh1z5T/q5K
 3JTsKzV7MwW+9k6FbKu4/v0KEYoCj+laS2iPP455VQ8JsXzJeLFLx9syb5aiKxRT
 gUW3S/AyXN9Hv7n/WXbEb3FKFJpY9iEIueV/JJsuS1HTc9tlKtPNNxyzRhbY3CVQ
 ==
X-ME-Proxy: <xmx:n22dW8vJHI7oJObhGAfBxvXPnN9w2rmoo7AEyafOtz5WsbJzw5rQJg>
 <xmx:n22dW8yRi8UpyMlqEAI0RfojXCE9sDiBzyiLwM_UiRxcYkOmX0uu0Q>
 <xmx:n22dWzlKDMhhpOo0j5H2uLpMTBAJ6wkkUpjZX8_-lGg3QxTIZYCWJw>
 <xmx:n22dWyZ6riDIselQbG1S15ABWVMCGUytxHgko7xqlxdaq4pXzE9zBA>
 <xmx:n22dWw5w3290rEjQUxXkIKIlrtFD1AxjoOe5LJlVWq9cmvr-ZUJ5pA>
 <xmx:oG2dW3y0ZXdiJLki_LpnWzARSZ8iSol6D0HSP0cdkgUW383k3C7TIQ>
X-ME-Sender: <xms:n22dWwM333kJXmYPABSm1XVcEfMhjVoKvZsTDC0m9MfkoWpL7JRawQ>
Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])
 by mail.messagingengine.com (Postfix) with ESMTPA id 3F998102D3;
 Sat, 15 Sep 2018 16:37:51 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: Ilya Maximets <i.maximets@samsung.com>, dev@dpdk.org,
 Stephen Hemminger <stephen@networkplumber.org>
Date: Sat, 15 Sep 2018 22:37:49 +0200
Message-ID: <1591958.AmeY3D3653@xps>
In-Reply-To: <CAKy9EB1UYnZrQw7-QXTc+mb6kcXezzhzKATxCYaxMetgjp7BAQ@mail.gmail.com>
References: <CGME20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33@eucas1p2.samsung.com>
 <6831653.AvvoQPlBBt@xps>
 <CAKy9EB1UYnZrQw7-QXTc+mb6kcXezzhzKATxCYaxMetgjp7BAQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: don't use bash
	extension in checkpatches
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Sep 2018 20:37:54 -0000

15/09/2018 21:07, Arnon Warshavsky:
> > > If we wish to keep the awk code in this file and not in a separate file,
> > > maybe receiving the awk script parameters from the function
> > >  check_forbidden_additions( ) can also preserve the ability to reuse in
> > > future cases.
> >
> > Yes I feel we could add some parameters to this function.
> > And yes, we could move the awk script in a separate file.
> > Actually, it would be better to keep checkpatches.sh as a wrapper script
> > calling various tools.
> >
> I was under the wrong impression the  opposite was desired, so yes,
> moving the entire awk code to a separate file would indeed be the cleanest.

OK, who can do this change please?