From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id D1FD02A5E for ; Mon, 7 Nov 2016 16:08:00 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id p190so188789495wmp.1 for ; Mon, 07 Nov 2016 07:08:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=DEva5y4ma/O3AKBMCLOiM/2BUyAiAlUv4kwlyaCGX+Q=; b=wjbtjGLTcBShN7St8ymCQDJ2WWEpDBOR6nBZ/t+sU7+Ueq//D49isOUZ1NmWh7Tci+ Hy7dnDRgrd/4A9hakknVndEvgHk/PJtEaBiw8nSF4aInm6DVbzdvQXgW3XneFqhUR/0j a6BPErPpakYlREPtCuH3h8JU4o70uGFjsQMn4tMa/tF57diWTSOs7NDJ9pPfSsPtMN6I hrKSAqnYntKc8z8AKHU+3AN2rR6MRZSQvSHXiVbnvFmi6NhCxroU5j2iiXDYA3Slfh9o ZF5gcdRRdqc5dPesPXrCqxjooxOi34Muq2flPFwHRI45EhcEXAHHaesYtf4afZP0tvWF +t7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=DEva5y4ma/O3AKBMCLOiM/2BUyAiAlUv4kwlyaCGX+Q=; b=aHQ8gzsHu34DXr2t4H4Im+eowQ5Ne/DeoIiARlcr3RLaFU58Bh+oP6yQdtkfioEqXu zb8yF//1QXrdFOOQssVPDL////er4bSmk6Tdi/gePLglZxeWkojaNqztELezhzCwmHYb lQ8AvtQ45dEXVmOCY6hVdmekE72X0AOo/VwgPV8RcMvJIF7YwrGXI6CUFt5JANC25rYb VHw1+QXqqKD9DhQsN4SQ+K4+i3JIJFfn9/WcxHEPxnYSpod79gzsqsKklVvI1Y7yPraC aNRzt5JaBaGvC7asoU0yE1U/hL76Y/0aXN3WmFtt3nV+gKc1rwwal3Y1qqnifCP6gdnf BZIA== X-Gm-Message-State: ABUngveoLGMgOliAyHEG4TBZjVC6vtzWZUfmRSFEr085TYFqrqdjF1N5Kc1pOU6lKTyg7q3A X-Received: by 10.28.232.213 with SMTP id f82mr9071869wmi.85.1478531280448; Mon, 07 Nov 2016 07:08:00 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id n3sm31511024wjq.34.2016.11.07.07.07.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 07:07:59 -0800 (PST) From: Thomas Monjalon To: Ananda Sathyanarayana Cc: dev@dpdk.org, "Lu, Wenzhuo" Date: Mon, 07 Nov 2016 16:07:58 +0100 Message-ID: <15921137.Y6goMQDZAC@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC090939340B93@shsmsx102.ccr.corp.intel.com> References: <1478129815-241504-1-git-send-email-ananda@versa-networks.com> <6A0DE07E22DDAD4C9103DF62FEBC090939340B93@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] E1000: fix for forced speed/duplex config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 15:08:02 -0000 > > From the code, it looks like, hw->mac.autoneg, variable is used to switch > > between calling either autoneg function or forcing speed/duplex function. But > > this variable is not modified in eth_em_start/eth_igb_start routines (it is always > > set to 1) even while forcing the link speed. > > > > Following discussion thread has some more information on this > > > > http://dpdk.org/ml/archives/dev/2016-October/049272.html > > > > Signed-off-by: Ananda Sathyanarayana > Acked-by: Wenzhuo Lu Applied, thanks