From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C2A8A04A5; Wed, 17 Jun 2020 13:46:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDAE61252; Wed, 17 Jun 2020 13:46:02 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3A510100C for ; Wed, 17 Jun 2020 13:46:01 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A55755C0035; Wed, 17 Jun 2020 07:46:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 17 Jun 2020 07:46:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= NUjD+O4N8Uck7Wm/tz7WkKPYx6X37owy+xix3fNBhYc=; b=wwzjqJlml73phdob Oypv88Fvo7NeSC1YThRlJ56r8PUdOHeIWWwNbbLOL4kTFqOG+PD6uMXElsj6aOQW sWij6Tn83mrpioKOXRpKEFmlwKIYMQOrL7ahQBQbdcfXRwVyYSliDiE5KYWHgH/W ANvU7bOZzYnXnAloO1RckeS9PAcjQH0pc0tIOhmmx6kh11XefdS23NeUX9ACFedE WA4pZsE5pdHdK9e6cTTKfOVfv5r6flAN61SIyhgy+/YnKVd1t73IL6f1JqgjFVuC cU11mjKhalDwNChcudQLzUbUJ4M+25Tjnn6d0MU+Gae94NiUQzAhIh/mTI9agN5C AMi7Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=NUjD+O4N8Uck7Wm/tz7WkKPYx6X37owy+xix3fNBh Yc=; b=jIRMJoZjWUzKoLb5uslFMMHgXZhZWK0/Wj2ILfe++6K2o2Nxi+7GF/46M jDS3z9mx7Ib6jE1wfSAU9sgRVQqJv7zMdgIhyXSPC3924s5n2/61HSNxo5h9iVNf nkl+SDmG9bhDS9ds38AWqx34KdtNY7UEjWQf6IMQm6pFkVr8NIqWixZlMG48M+ue LIJNibf9+gxVycerS70u9OZXpPfNQxS81zNpU0RmEnPIuFrHAuMLaK0q6Iooargj 1dnHAC0WSeybR3TDr9pClEboZyuMphAOkZ/Irnb7DlduEFwL0ThaxxnsTtXcCc4P SBFQWYzsVxhfMFx6r7/15wFI+6qIw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejvddggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffeufeduheekudehkefhffejffffleffgfdutefgjeevffejudej geffueeuledtnecuffhomhgrihhnpehgnhhurdhorhhgpdhsohhurhgtvgifrghrvgdroh hrghenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 275B63280063; Wed, 17 Jun 2020 07:45:59 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Wed, 17 Jun 2020 13:45:57 +0200 Message-ID: <159240636.HSrAOgkoKl@thomas> In-Reply-To: <20200617104012.470617-1-bruce.richardson@intel.com> References: <20200617104012.470617-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: check functionality rather than binutils version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/06/2020 12:40, Bruce Richardson: > Rather than checking the binutils version number, which can lead to > unnecessary disabling of AVX512 if fixes have been backported to distro > versions, we can instead check the output of "as" from binutils to see if > it is correct. > > These checks use the minimal assembly reproduction code posted to the > public bug tracker for gcc/binutils for those issues [1][2]. If the > binutils bug is present, the instruction parameters - specifically the > displacement parameter - will be different in the disassembled output > compared to the input. Therefore each check involves assembling a single > instruction and disassembling it again, checking that the two match. Whaoh, that's a very specific optimization :) Which distro is affected (backported binutils fix)? > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 > [2] https://sourceware.org/bugzilla/show_bug.cgi?id=23465 > > Signed-off-by: Bruce Richardson > --- > --- a/buildtools/meson.build > +++ b/buildtools/meson.build > -subdir('pmdinfogen') Why removing pmdinfogen? > --- a/meson.build > +++ b/meson.build > +# do configuration and get tool paths > +subdir('buildtools') > subdir('config') > > # build libs and drivers > -subdir('buildtools') > +subdir('buildtools/pmdinfogen') Is it related to binutils check? [...] > - ldver = run_command('ld', '-v').stdout().strip() > - if ldver.contains('2.30') and cc.has_argument('-mno-avx512f') > + as_ok = run_command(binutils_avx512_check) > + if as_ok.returncode() != 0 and cc.has_argument('-mno-avx512f') "as_ok" is difficult to understand. I would suggest "binutils_avx512_ok". > + message('Binutils error with AVX512 assembly, disabling AVX512 support') It looks like something which should be part of meson itself.