DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH 00/27] event/dlb Intel DLB PMD
@ 2020-06-27  4:37 Tim McDaniel
  2020-06-27  4:37 ` [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites Tim McDaniel
                   ` (26 more replies)
  0 siblings, 27 replies; 50+ messages in thread
From: Tim McDaniel @ 2020-06-27  4:37 UTC (permalink / raw)
  To: jerinj; +Cc: mattias.ronnblom, dev, gage.eads, harry.van.haaren

Hello Jerin and the DPDK community.

    The following patchset adds support for a new eventdev PMD. The DLB
    PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware.
    The DLB is a PCIe device that provides load-balanced, prioritized
    scheduling of core-to-core communication. The device consists of
    queues and arbiters that connect producer and consumer cores, and
    implements load-balanced queueing features including:
    - Lock-free multi-producer/multi-consumer operation.
    - Multiple priority levels for varying traffic types.
    - 'Direct' traffic (i.e. multi-producer/single-consumer)
    - Simple unordered load-balanced distribution.
    - Atomic lock-free load balancing across multiple consumers.
    - Queue element reordering feature allowing ordered load-balanced
      distribution.

    The DLB hardware supports both load balanced and directed ports and
    queues. Unlike other eventdev devices already in the repo,  not all
    DLB ports and queues are equally capable. In particular, directed
    ports are limited to a single link, and must be connected to a directed
    queue.
    Additionally, even though LDB ports may link multiple queues, the
    number of queues that may be linked is limited by hardware. Another
    difference is that DLB does not have a straightforward way of carrying
    the flow_id in the queue elements (QE) that the hardware operates on.

    Due to the above restrictions, we would like to extend the eventdev
    interface in manner that allows our PMD to take full advantage of
    the DLB hardware, while also adding useful functionality for non-Intel
    PMDs. Our proposed changes are contained in the first two patches
    in this patch set.

    While reviewing the code, please be aware that this PMD has full
    control over the DLB hardware. Intel will be extending the DLB PMD
    in the future (not as part of this first series) with a mode that we
    refer to as the bifurcated PMD. The bifurcated PMD communicates with a
    kernel driver to configure the device, ports, and queues, and memory
    maps device MMIO so data path operations occur purely in user-space.

    The framework to support both the PF PMD and bifurcated PMD exists in
    this patch set, and is why the iface.[ch] layer is present.

    New for V2
    =========

    	1) Correct ABI break that was present in V1. 
	2) Address some of the review comments received from Mattias.
    	   I will address the remaining items identified by Mattias in the next
    	   patch delivery.
	3) General code cleanup based on internal code reviews

    Known Issues:
        1) some core dlb enqueue functions appear prematurely in a unrelated
           patch. This will be addressed in the next update to this
           patch series, after the first round of reviews has been
           completed.


    Thank You and Best Regards,

    Tim McDaniel

McDaniel, Timothy (27):
  eventdev: dlb upstream prerequisites
  eventdev: do not pass disable_implicit_release bit to trace macro
  event/dlb: add shared code version 10.7.9
  event/dlb: add make and meson build infrastructure
  event/dlb: add DLB documentation
  event/dlb: add dynamic logging
  event/dlb: add private data structures and constants
  event/dlb: add definitions shared with LKM or shared code
  event/dlb: add inline functions used in multiple files
  event/dlb: add PFPMD-specific interface layer to shared code
  event/dlb: add flexible PMD to device interfaces
  event/dlb: add the PMD's public interfaces
  event/dlb: add xstats support
  event/dlb: add PMD self-tests
  event/dlb: add probe
  event/dlb: add infos_get and configure
  event/dlb: add queue_def_conf and port_def_conf
  event/dlb: add queue setup
  event/dlb: add port_setup
  event/dlb: add port_link
  event/dlb: add queue_release and port_release
  event/dlb: add port_unlink and port_unlinks_in_progress
  event/dlb: add eventdev_start
  event/dlb: add timeout_ticks, dump, xstats, and selftest
  event/dlb: add enqueue and its burst variants
  event/dlb: add dequeue, dequeue_burst, and variants
  event/dlb: add eventdev_stop and eventdev_close

 app/test-eventdev/evt_common.h                     |    1 +
 app/test-eventdev/test_order_atq.c                 |    4 +
 app/test-eventdev/test_order_common.c              |    6 +-
 app/test-eventdev/test_order_queue.c               |    4 +
 app/test-eventdev/test_perf_atq.c                  |    1 +
 app/test-eventdev/test_perf_queue.c                |    1 +
 app/test-eventdev/test_pipeline_atq.c              |    1 +
 app/test-eventdev/test_pipeline_queue.c            |    1 +
 app/test/test_eventdev.c                           |    4 +-
 config/common_base                                 |   19 +-
 config/rte_config.h                                |    8 +-
 doc/guides/eventdevs/dlb.rst                       |  497 +
 drivers/event/Makefile                             |    7 +
 drivers/event/dlb/Makefile                         |   35 +
 drivers/event/dlb/dlb.c                            | 4232 +++++++++
 drivers/event/dlb/dlb_iface.c                      |  105 +
 drivers/event/dlb/dlb_iface.h                      |   92 +
 drivers/event/dlb/dlb_inline_fns.h                 |   80 +
 drivers/event/dlb/dlb_log.h                        |   24 +
 drivers/event/dlb/dlb_priv.h                       |  564 ++
 drivers/event/dlb/dlb_selftest.c                   | 1564 ++++
 drivers/event/dlb/dlb_user.h                       | 1083 +++
 drivers/event/dlb/dlb_xstats.c                     | 1249 +++
 drivers/event/dlb/meson.build                      |   15 +
 drivers/event/dlb/pf/base/dlb_hw_types.h           |  360 +
 drivers/event/dlb/pf/base/dlb_mbox.h               |  645 ++
 drivers/event/dlb/pf/base/dlb_osdep.h              |  348 +
 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h       |  442 +
 drivers/event/dlb/pf/base/dlb_osdep_list.h         |  131 +
 drivers/event/dlb/pf/base/dlb_osdep_types.h        |   31 +
 drivers/event/dlb/pf/base/dlb_regs.h               | 2646 ++++++
 drivers/event/dlb/pf/base/dlb_resource.c           | 9700 ++++++++++++++++++++
 drivers/event/dlb/pf/base/dlb_resource.h           | 1625 ++++
 drivers/event/dlb/pf/base/dlb_user.h               | 1084 +++
 drivers/event/dlb/pf/dlb_main.c                    |  609 ++
 drivers/event/dlb/pf/dlb_main.h                    |   54 +
 drivers/event/dlb/pf/dlb_pf.c                      |  776 ++
 drivers/event/dlb/rte_pmd_dlb.c                    |   38 +
 drivers/event/dlb/rte_pmd_dlb.h                    |   69 +
 drivers/event/dlb/rte_pmd_dlb_event_version.map    |    6 +
 drivers/event/dpaa2/dpaa2_eventdev.c               |    2 +-
 drivers/event/meson.build                          |    4 +
 drivers/event/octeontx/ssovf_evdev.c               |    2 +-
 drivers/event/skeleton/skeleton_eventdev.c         |    2 +-
 drivers/event/sw/sw_evdev.c                        |    5 +-
 drivers/event/sw/sw_evdev_selftest.c               |    9 +-
 .../eventdev_pipeline/pipeline_worker_generic.c    |    8 +-
 examples/eventdev_pipeline/pipeline_worker_tx.c    |    3 +
 examples/l2fwd-event/l2fwd_event_generic.c         |    5 +-
 examples/l2fwd-event/l2fwd_event_internal_port.c   |    5 +-
 examples/l3fwd/l3fwd_event_generic.c               |    5 +-
 examples/l3fwd/l3fwd_event_internal_port.c         |    5 +-
 lib/librte_eal/x86/include/rte_cpuflags.h          |    1 +
 lib/librte_eal/x86/rte_cpuflags.c                  |    1 +
 lib/librte_eventdev/meson.build                    |    1 +
 lib/librte_eventdev/rte_event_crypto_adapter.c     |    2 +-
 lib/librte_eventdev/rte_event_eth_tx_adapter.c     |    7 +-
 lib/librte_eventdev/rte_eventdev.c                 |  201 +-
 lib/librte_eventdev/rte_eventdev.h                 |  198 +
 lib/librte_eventdev/rte_eventdev_pmd_pci.h         |   54 +
 lib/librte_eventdev/rte_eventdev_trace.h           |    9 +-
 lib/librte_eventdev/rte_eventdev_version.map       |   13 +-
 mk/rte.app.mk                                      |    1 +
 63 files changed, 28658 insertions(+), 46 deletions(-)
 create mode 100644 doc/guides/eventdevs/dlb.rst
 create mode 100644 drivers/event/dlb/Makefile
 create mode 100644 drivers/event/dlb/dlb.c
 create mode 100644 drivers/event/dlb/dlb_iface.c
 create mode 100644 drivers/event/dlb/dlb_iface.h
 create mode 100644 drivers/event/dlb/dlb_inline_fns.h
 create mode 100644 drivers/event/dlb/dlb_log.h
 create mode 100644 drivers/event/dlb/dlb_priv.h
 create mode 100644 drivers/event/dlb/dlb_selftest.c
 create mode 100644 drivers/event/dlb/dlb_user.h
 create mode 100644 drivers/event/dlb/dlb_xstats.c
 create mode 100644 drivers/event/dlb/meson.build
 create mode 100644 drivers/event/dlb/pf/base/dlb_hw_types.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_mbox.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_list.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_types.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_regs.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_resource.c
 create mode 100644 drivers/event/dlb/pf/base/dlb_resource.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_user.h
 create mode 100644 drivers/event/dlb/pf/dlb_main.c
 create mode 100644 drivers/event/dlb/pf/dlb_main.h
 create mode 100644 drivers/event/dlb/pf/dlb_pf.c
 create mode 100644 drivers/event/dlb/rte_pmd_dlb.c
 create mode 100644 drivers/event/dlb/rte_pmd_dlb.h
 create mode 100644 drivers/event/dlb/rte_pmd_dlb_event_version.map

-- 
1.7.10


^ permalink raw reply	[flat|nested] 50+ messages in thread