DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mempool: remove get capability debug print
@ 2017-10-10 14:17 Hemant Agrawal
  2017-10-10 14:28 ` santosh
  0 siblings, 1 reply; 3+ messages in thread
From: Hemant Agrawal @ 2017-10-10 14:17 UTC (permalink / raw)
  To: olivier.matz; +Cc: dev, santosh.shukla

This is not required to be printed for every mempool call.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 lib/librte_mempool/rte_mempool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 57a4f81..6357fd4 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -559,10 +559,7 @@ rte_mempool_populate_default(struct rte_mempool *mp)
 	/* Get mempool capabilities */
 	mp_flags = 0;
 	ret = rte_mempool_ops_get_capabilities(mp, &mp_flags);
-	if (ret == -ENOTSUP)
-		RTE_LOG(DEBUG, MEMPOOL, "get_capability not supported for %s\n",
-					mp->name);
-	else if (ret < 0)
+	if ((ret < 0) && (ret != -ENOTSUP))
 		return ret;
 
 	/* update mempool capabilities */
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mempool: remove get capability debug print
  2017-10-10 14:17 [dpdk-dev] [PATCH] mempool: remove get capability debug print Hemant Agrawal
@ 2017-10-10 14:28 ` santosh
  2017-10-12  1:31   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: santosh @ 2017-10-10 14:28 UTC (permalink / raw)
  To: Hemant Agrawal, olivier.matz; +Cc: dev


On Tuesday 10 October 2017 07:47 PM, Hemant Agrawal wrote:
> This is not required to be printed for every mempool call.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---

Will print only in debug mode though, But ok with patch.

Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mempool: remove get capability debug print
  2017-10-10 14:28 ` santosh
@ 2017-10-12  1:31   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-10-12  1:31 UTC (permalink / raw)
  To: Hemant Agrawal; +Cc: dev, santosh, olivier.matz

10/10/2017 16:28, santosh:
> 
> On Tuesday 10 October 2017 07:47 PM, Hemant Agrawal wrote:
> > This is not required to be printed for every mempool call.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> 
> Will print only in debug mode though, But ok with patch.
> 
> Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> Thanks.

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-12  1:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 14:17 [dpdk-dev] [PATCH] mempool: remove get capability debug print Hemant Agrawal
2017-10-10 14:28 ` santosh
2017-10-12  1:31   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).