DPDK patches and discussions
 help / color / Atom feed
From: Lijun Ou <oulijun@huawei.com>
To: <wenzhuo.lu@intel.com>, <beilei.xing@intel.com>,
	<bernard.iremonger@intel.com>, <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>, <linuxarm@huawei.com>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine
Date: Wed, 1 Jul 2020 15:43:26 +0800
Message-ID: <1593589406-12868-1-git-send-email-oulijun@huawei.com> (raw)

When set the forwarding mode of the pkt, it needs to update
the fwd_eng that it is the member of cur_fwd_config. Otherwise,
an error will occur when executing the set command and show
confg fwd.
the flows as follows:
   1. ./tespmd -w xxx -l xx -n 4 -- i
   2. set fwd mac
      testpmd> set fwd mac
      Set mac packet forwarding mode

   3. show config fwd
      testpmd> show config fwd
      io packet forwarding - ports=1 - cores=1 - streams=8 -...
      Logical Core 1 (socket 0) forwards packets on 8 streams:

When run the 1 ~ 3 step, it should show the packet forwarding is
mac.

Fixes: af75078fece3 ("first public release")
Cc: wenzhuo.lu@intel.com
Cc: beilei.xing@intel.com
Cc: bernard.iremonger@intel.com
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
v2:
-- fix the title
-- add fixes and Cc
---
 app/test-pmd/config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index a7112c9..ee0e904 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char *fwd_mode_name)
 			       fwd_mode_name,
 			       retry_enabled == 0 ? "" : " with retry");
 			cur_fwd_eng = fwd_eng;
+			cur_fwd_config.fwd_eng = fwd_eng;
 			return;
 		}
 		i++;
-- 
2.7.4


             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  7:43 Lijun Ou [this message]
2020-07-02  8:11 ` Wisam Monther
2020-07-02 15:03 ` Phil Yang
2020-07-03  1:31   ` Phil Yang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593589406-12868-1-git-send-email-oulijun@huawei.com \
    --to=oulijun@huawei.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=linuxarm@huawei.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox