DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: ferruh.yigit@intel.com, anatoly.burakov@intel.com,
	shahafs@mellanox.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type
Date: Thu, 02 May 2019 10:10:35 +0200	[thread overview]
Message-ID: <1593707.DseZV921jT@xps> (raw)
In-Reply-To: <20190502074357.32031-1-yskoh@mellanox.com>

02/05/2019 09:43, Yongseok Koh:
> Mellanox mlx4/5 PMD doesn't need to be detached from kernel driver and
> attached to VFIO/UIO. Control path still goes through the existing kernel
> drivers, which is mlx4_core/mlx5_core.

The real change here is to handle RTE_PCI_DRV_IOVA_AS_VA
with Mellanox kernel drivers.
It think it should be explained in the commit log,
because there is no other reason for not using RTE_KDRV_UNKNOWN.

> @@ -568,7 +571,8 @@ pci_one_device_has_iova_va(void)
>  	FOREACH_DRIVER_ON_PCIBUS(drv) {
>  		if (drv && drv->drv_flags & RTE_PCI_DRV_IOVA_AS_VA) {
>  			FOREACH_DEVICE_ON_PCIBUS(dev) {
> -				if (dev->kdrv == RTE_KDRV_VFIO &&
> +				if ((dev->kdrv == RTE_KDRV_VFIO ||
> +				     dev->kdrv == RTE_KDRV_NIC_MLX) &&
>  				    rte_pci_match(drv, dev))
>  					return 1;
>  			}

  parent reply	other threads:[~2019-05-02  8:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02  1:44 [dpdk-dev] [PATCH] net/mlx: support IOVA VA mode Yongseok Koh
2019-05-02  1:44 ` Yongseok Koh
2019-05-02  7:31 ` Yongseok Koh
2019-05-02  7:31   ` Yongseok Koh
2019-05-02  7:43 ` [dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type Yongseok Koh
2019-05-02  7:43   ` Yongseok Koh
2019-05-02  7:43   ` [dpdk-dev] [PATCH v2 2/2] net/mlx: support IOVA VA mode Yongseok Koh
2019-05-02  7:43     ` Yongseok Koh
2019-05-02  8:10   ` Thomas Monjalon [this message]
2019-05-02  8:10     ` [dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type Thomas Monjalon
2019-05-02  9:07 ` [dpdk-dev] [PATCH v3 " Yongseok Koh
2019-05-02  9:07   ` Yongseok Koh
2019-05-02  9:07   ` [dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode Yongseok Koh
2019-05-02  9:07     ` Yongseok Koh
2019-05-02 13:06     ` Shahaf Shuler
2019-05-02 13:06       ` Shahaf Shuler
2019-06-03 22:39   ` [dpdk-dev] [PATCH v3 1/2] bus/pci: add Mellanox kernel driver type Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593707.DseZV921jT@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).