[dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Panu Matilainen]

Commit d0cf91303d73 added dependency on librte_net headers to vhost
but did not add this to the Makefile, which makes builds
non-deterministic. Curiously it is non-parallel build that is
consistently broken by this missing dependency, usually it's the other
way around, but trying to build without -j(n) fails with:

	dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
	fatal error: rte_ip.h: No such file or directory

Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 lib/librte_vhost/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile
index 035b569..ef9bbae 100644
--- a/lib/librte_vhost/Makefile
+++ b/lib/librte_vhost/Makefile
@@ -65,5 +65,6 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_VHOST)-include += rte_virtio_net.h
 DEPDIRS-$(CONFIG_RTE_LIBRTE_VHOST) += lib/librte_eal
 DEPDIRS-$(CONFIG_RTE_LIBRTE_VHOST) += lib/librte_ether
 DEPDIRS-$(CONFIG_RTE_LIBRTE_VHOST) += lib/librte_mbuf
+DEPDIRS-$(CONFIG_RTE_LIBRTE_VHOST) += lib/librte_net
 
 include $(RTE_SDK)/mk/rte.lib.mk
-- 
2.5.0

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Yuanhan Liu]

On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> Commit d0cf91303d73 added dependency on librte_net headers to vhost
> but did not add this to the Makefile, which makes builds
> non-deterministic. Curiously it is non-parallel build that is
> consistently broken by this missing dependency, usually it's the other
> way around, but trying to build without -j(n) fails with:

Yeah, I have confirmed it; I was wondering why I didn't meet such build
error.

> 
> 	dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
> 	fatal error: rte_ip.h: No such file or directory
> 
> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Thanks.

BTW, please cc me for virtio/vhost patches next time, otherwise, it's
easily got overlooked: too many emails.

	--yliu

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Panu Matilainen]

On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
>> Commit d0cf91303d73 added dependency on librte_net headers to vhost
>> but did not add this to the Makefile, which makes builds
>> non-deterministic. Curiously it is non-parallel build that is
>> consistently broken by this missing dependency, usually it's the other
>> way around, but trying to build without -j(n) fails with:
>
> Yeah, I have confirmed it; I was wondering why I didn't meet such build
> error.
>
>>
>> 	dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
>> 	fatal error: rte_ip.h: No such file or directory
>>
>> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Thanks.
>
> BTW, please cc me for virtio/vhost patches next time, otherwise, it's
> easily got overlooked: too many emails.

Hmm, I thought I did. Looking more carefully now, I mixed up the patch 
author (who was CC'd) with you:

commit d0cf91303d731997945420832ee245b21f292e19
Author: Jijiang Liu <jijiang.liu@intel.com>

I hate it when people call me Paul (commonly happens) just because it 
vaguely resembles my name, so I really should do better than this. 
Apologies, I'll pay closer attention in the future.

	- Panu -

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Yuanhan Liu]

On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote:
> On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
> >On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> >>Commit d0cf91303d73 added dependency on librte_net headers to vhost
> >>but did not add this to the Makefile, which makes builds
> >>non-deterministic. Curiously it is non-parallel build that is
> >>consistently broken by this missing dependency, usually it's the other
> >>way around, but trying to build without -j(n) fails with:
> >
> >Yeah, I have confirmed it; I was wondering why I didn't meet such build
> >error.
> >
> >>
> >>	dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
> >>	fatal error: rte_ip.h: No such file or directory
> >>
> >>Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> >>Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> >
> >Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >
> >Thanks.
> >
> >BTW, please cc me for virtio/vhost patches next time, otherwise, it's
> >easily got overlooked: too many emails.
> 
> Hmm, I thought I did. Looking more carefully now, I mixed up the patch
> author (who was CC'd) with you:

I didn't see the author was cc'ed from my email client:

    Date: Thu, 18 Feb 2016 11:47:43 +0200
    From: Panu Matilainen <pmatilai@redhat.com>
    To: dev@dpdk.org
    Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

> 
> commit d0cf91303d731997945420832ee245b21f292e19
> Author: Jijiang Liu <jijiang.liu@intel.com>
> 
> I hate it when people call me Paul (commonly happens) just because it

Hmm... I didn't call you that, right?

> vaguely resembles my name,

Indeed :)

> so I really should do better than this.
> Apologies, I'll pay closer attention in the future.

Never mind, it's not a big deal. Emails with me CC'ed are highlighted
in my mutt email client, therefore, it's unlikely I will miss them.

	--yliu

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Panu Matilainen]

On 02/18/2016 03:56 PM, Yuanhan Liu wrote:
> On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote:
>> On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
>>> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
>>>> Commit d0cf91303d73 added dependency on librte_net headers to vhost
>>>> but did not add this to the Makefile, which makes builds
>>>> non-deterministic. Curiously it is non-parallel build that is
>>>> consistently broken by this missing dependency, usually it's the other
>>>> way around, but trying to build without -j(n) fails with:
>>>
>>> Yeah, I have confirmed it; I was wondering why I didn't meet such build
>>> error.
>>>
>>>>
>>>> 	dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
>>>> 	fatal error: rte_ip.h: No such file or directory
>>>>
>>>> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
>>>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>>>
>>> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>>>
>>> Thanks.
>>>
>>> BTW, please cc me for virtio/vhost patches next time, otherwise, it's
>>> easily got overlooked: too many emails.
>>
>> Hmm, I thought I did. Looking more carefully now, I mixed up the patch
>> author (who was CC'd) with you:
>
> I didn't see the author was cc'ed from my email client:
>
>      Date: Thu, 18 Feb 2016 11:47:43 +0200
>      From: Panu Matilainen <pmatilai@redhat.com>
>      To: dev@dpdk.org
>      Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

Hmm, indeed. But this is what git told me (happened to have the whole 
thing in scrollback buffer):

[pmatilai@sopuli dpdk]$ git send-email --cc="jijiang.liu@intel.com" 
--cc="huawei.xie@intel.com" -1
/tmp/ZAW8ErlHWe/0001-vhost-add-missing-build-dependency-on-librte_net.patch

From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Cc: jijiang.liu@intel.com,
	huawei.xie@intel.com
Subject: [PATCH] vhost: add missing build dependency on librte_net
Date: Thu, 18 Feb 2016 11:47:43 +0200
Message-Id: 
<eef2b50186eea076a3a3ff9f10bd8c310a036549.1455788863.git.pmatilai@redhat.com>
X-Mailer: git-send-email 2.5.0

Send this email? ([y]es|[n]o|[q]uit|[a]ll): a
OK. Log says:
Server: smtp.corp.redhat.com
MAIL FROM:<pmatilai@redhat.com>
RCPT TO:<dev@dpdk.org>
RCPT TO:<jijiang.liu@intel.com>
RCPT TO:<huawei.xie@intel.com>
From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Cc: jijiang.liu@intel.com,
	huawei.xie@intel.com
Subject: [PATCH] vhost: add missing build dependency on librte_net
Date: Thu, 18 Feb 2016 11:47:43 +0200
Message-Id: 
<eef2b50186eea076a3a3ff9f10bd8c310a036549.1455788863.git.pmatilai@redhat.com>
X-Mailer: git-send-email 2.5.0

So where do the CC's vanish?

>>
>> commit d0cf91303d731997945420832ee245b21f292e19
>> Author: Jijiang Liu <jijiang.liu@intel.com>
>>
>> I hate it when people call me Paul (commonly happens) just because it
>
> Hmm... I didn't call you that, right?

No, not you :)

>> vaguely resembles my name,
>
> Indeed :)
>
>> so I really should do better than this.
>> Apologies, I'll pay closer attention in the future.
>
> Never mind, it's not a big deal. Emails with me CC'ed are highlighted
> in my mutt email client, therefore, it's unlikely I will miss them.
>
> 	--yliu
>

Sure. We all get too much email :)

	- Panu -

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Thomas Monjalon]

2016-02-18 21:25, Yuanhan Liu:
> On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> > Commit d0cf91303d73 added dependency on librte_net headers to vhost
> > but did not add this to the Makefile, which makes builds
> > non-deterministic. Curiously it is non-parallel build that is
> > consistently broken by this missing dependency, usually it's the other
> > way around, but trying to build without -j(n) fails with:
> 
> Yeah, I have confirmed it; I was wondering why I didn't meet such build
> error.
> 
> > 
> > 	dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
> > 	fatal error: rte_ip.h: No such file or directory
> > 
> > Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> 
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Applied, thanks

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Yuanhan Liu]

On Thu, Feb 18, 2016 at 04:07:52PM +0200, Panu Matilainen wrote:
> >I didn't see the author was cc'ed from my email client:
> >
> >     Date: Thu, 18 Feb 2016 11:47:43 +0200
> >     From: Panu Matilainen <pmatilai@redhat.com>
> >     To: dev@dpdk.org
> >     Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net
> 
> Hmm, indeed. But this is what git told me (happened to have the whole thing
> in scrollback buffer):
> 
> [pmatilai@sopuli dpdk]$ git send-email --cc="jijiang.liu@intel.com"
> --cc="huawei.xie@intel.com" -1
> /tmp/ZAW8ErlHWe/0001-vhost-add-missing-build-dependency-on-librte_net.patch
> 
> From: Panu Matilainen <pmatilai@redhat.com>
> To: dev@dpdk.org
> Cc: jijiang.liu@intel.com,
> 	huawei.xie@intel.com
> Subject: [PATCH] vhost: add missing build dependency on librte_net
> Date: Thu, 18 Feb 2016 11:47:43 +0200
> Message-Id:
> <eef2b50186eea076a3a3ff9f10bd8c310a036549.1455788863.git.pmatilai@redhat.com>
> X-Mailer: git-send-email 2.5.0
> 
> Send this email? ([y]es|[n]o|[q]uit|[a]ll): a
> OK. Log says:
> Server: smtp.corp.redhat.com
> MAIL FROM:<pmatilai@redhat.com>
> RCPT TO:<dev@dpdk.org>
> RCPT TO:<jijiang.liu@intel.com>
> RCPT TO:<huawei.xie@intel.com>
> From: Panu Matilainen <pmatilai@redhat.com>
> To: dev@dpdk.org
> Cc: jijiang.liu@intel.com,
> 	huawei.xie@intel.com
> Subject: [PATCH] vhost: add missing build dependency on librte_net
> Date: Thu, 18 Feb 2016 11:47:43 +0200
> Message-Id:
> <eef2b50186eea076a3a3ff9f10bd8c310a036549.1455788863.git.pmatilai@redhat.com>
> X-Mailer: git-send-email 2.5.0
> 
> So where do the CC's vanish?

No idea. I also have met this issue __many__ times before: I made a
group reply, with lots of people CC'ed, later I then received a copy
(from the mailing list) with all cc list being vanished -- only
dev@dpdk.org is left. However, I found the CC list was there while
I checked the sent box.

I was firstly thinking it might be an issue of my email client. However,
I also found same phenomenon from other's reply. Just not sure whether
they removed the cc list on purpose or not, though. IIRC, this also
happened to Bruce (CC'ed).

Anyway, since you have met similar issue just now, I guess it's time to 
shout out and let this issue get noticed, or fixed if there is indeed
an issue. The mailing list is with high chance being the culprit, IMO.
Hence, Thomas is CC'ed.

BTW, I have never meet this issue with git send-email.

	--yliu

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Thomas Monjalon]

2016-02-19 09:56, Yuanhan Liu:
> On Thu, Feb 18, 2016 at 04:07:52PM +0200, Panu Matilainen wrote:
> > So where do the CC's vanish?
> 
> No idea. I also have met this issue __many__ times before: I made a
> group reply, with lots of people CC'ed, later I then received a copy
> (from the mailing list) with all cc list being vanished -- only
> dev@dpdk.org is left. However, I found the CC list was there while
> I checked the sent box.
> 
> I was firstly thinking it might be an issue of my email client. However,
> I also found same phenomenon from other's reply. Just not sure whether
> they removed the cc list on purpose or not, though. IIRC, this also
> happened to Bruce (CC'ed).
> 
> Anyway, since you have met similar issue just now, I guess it's time to 
> shout out and let this issue get noticed, or fixed if there is indeed
> an issue. The mailing list is with high chance being the culprit, IMO.
> Hence, Thomas is CC'ed.

Yes this is due to the "no duplicates" option of mailman:
	https://bugs.launchpad.net/mailman/+bug/1216960

I am checking how to disable it.

Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

[Bruce Richardson]

On Fri, Feb 19, 2016 at 09:56:04AM +0800, Yuanhan Liu wrote:
> On Thu, Feb 18, 2016 at 04:07:52PM +0200, Panu Matilainen wrote:
> > >I didn't see the author was cc'ed from my email client:
> > >
> > >     Date: Thu, 18 Feb 2016 11:47:43 +0200
> > >     From: Panu Matilainen <pmatilai@redhat.com>
> > >     To: dev@dpdk.org
> > >     Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net
> > 
> > Hmm, indeed. But this is what git told me (happened to have the whole thing
> > in scrollback buffer):
> > 
> > [pmatilai@sopuli dpdk]$ git send-email --cc="jijiang.liu@intel.com"
> > --cc="huawei.xie@intel.com" -1
> > /tmp/ZAW8ErlHWe/0001-vhost-add-missing-build-dependency-on-librte_net.patch
> > 
> > From: Panu Matilainen <pmatilai@redhat.com>
> > To: dev@dpdk.org
> > Cc: jijiang.liu@intel.com,
> > 	huawei.xie@intel.com
> > Subject: [PATCH] vhost: add missing build dependency on librte_net
> > Date: Thu, 18 Feb 2016 11:47:43 +0200
> > Message-Id:
> > <eef2b50186eea076a3a3ff9f10bd8c310a036549.1455788863.git.pmatilai@redhat.com>
> > X-Mailer: git-send-email 2.5.0
> > 
> > Send this email? ([y]es|[n]o|[q]uit|[a]ll): a
> > OK. Log says:
> > Server: smtp.corp.redhat.com
> > MAIL FROM:<pmatilai@redhat.com>
> > RCPT TO:<dev@dpdk.org>
> > RCPT TO:<jijiang.liu@intel.com>
> > RCPT TO:<huawei.xie@intel.com>
> > From: Panu Matilainen <pmatilai@redhat.com>
> > To: dev@dpdk.org
> > Cc: jijiang.liu@intel.com,
> > 	huawei.xie@intel.com
> > Subject: [PATCH] vhost: add missing build dependency on librte_net
> > Date: Thu, 18 Feb 2016 11:47:43 +0200
> > Message-Id:
> > <eef2b50186eea076a3a3ff9f10bd8c310a036549.1455788863.git.pmatilai@redhat.com>
> > X-Mailer: git-send-email 2.5.0
> > 
> > So where do the CC's vanish?
> 
> No idea. I also have met this issue __many__ times before: I made a
> group reply, with lots of people CC'ed, later I then received a copy
> (from the mailing list) with all cc list being vanished -- only
> dev@dpdk.org is left. However, I found the CC list was there while
> I checked the sent box.
> 
> I was firstly thinking it might be an issue of my email client. However,
> I also found same phenomenon from other's reply. Just not sure whether
> they removed the cc list on purpose or not, though. IIRC, this also
> happened to Bruce (CC'ed).
> 

And I thought it was just me! :-)

/Bruce