From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id BA13BC3FC for ; Thu, 18 Feb 2016 20:28:06 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id c200so43950551wme.0 for ; Thu, 18 Feb 2016 11:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=jdjmg1ExXVgDrQQO0vSzhCIXqLb9RSHl9Bqp/xoIdVc=; b=i/XbUsXkzZ5Ft/wYHfeNNu3sr9oR9wBhs5j910e8anFpON1B8QQclHIE2uwYqB+RtM qaZ4s442PssoAk4B3wdZtNAWrbpV7bjW46ZWWivbF4wkZbDp9N1V3XVRR/U+sQKdtFr/ I2hAvYcxI3+n6DUDq4VGCd4RkK0VFF4wnVzLB1okHB+5cxhx7QNwJYrNXOBTqwSFAMfS 2a3ExssXAgUhG+t0ReDFA5n+NopxcPAhDKlKBtxs1SAPfVrl5OZbHMaudOHsDbL1oadn G3OltcSpgs+8C3JjtJ+UEnx/ZV2Dk3rhKM1zJBsJyszJeTEavfyh7EaokJjkx/Cf4Hs+ 6UcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=jdjmg1ExXVgDrQQO0vSzhCIXqLb9RSHl9Bqp/xoIdVc=; b=gbLYSe6ZmrUK8WTOB3cVZNqA3vNQWB9FJiLFWB2xfOiGmTLuC0Hs0/G1TlfxoKqi06 kjww9xTru9qKYkMcMBker9DSzE3h2rcumR9al2aZQdku62S6dG6NYPe7bf2xJvt6NxlB Tgz4q7tN+ujTjI67PWyyboFbrQn/zKZ8lVcrYq2/oI/hyCELBCp7pIGW7dp/tWFIAM9H iWAP4lco726ez0NowyagR/XA5DJOR0PC+fu+Lo/hg/xmA+P/4FqglwwgLpB1KcjWMJle eEQOHMrM3VXdN3ijCJYwBBz9c9ethc2ylPFcpCtjWMtaZr5C36hZELeyUIhZH8/3huHw o7nw== X-Gm-Message-State: AG10YOQsq0AswHRf1D5QYrH8qd3l8YUJ2JahfspWfj8qHpppKqoEtvIS2NUH7F6YVog+ky7a X-Received: by 10.28.88.81 with SMTP id m78mr5326258wmb.58.1455823686590; Thu, 18 Feb 2016 11:28:06 -0800 (PST) Received: from xps13.localnet (112.202.154.77.rev.sfr.net. [77.154.202.112]) by smtp.gmail.com with ESMTPSA id n131sm4359019wmf.9.2016.02.18.11.28.05 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 18 Feb 2016 11:28:05 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Thu, 18 Feb 2016 20:26:32 +0100 Message-ID: <1593893.DkKoCMf5f8@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160218132549.GN21426@yliu-dev.sh.intel.com> References: <20160218132549.GN21426@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 19:28:06 -0000 2016-02-18 21:25, Yuanhan Liu: > On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: > > Commit d0cf91303d73 added dependency on librte_net headers to vhost > > but did not add this to the Makefile, which makes builds > > non-deterministic. Curiously it is non-parallel build that is > > consistently broken by this missing dependency, usually it's the other > > way around, but trying to build without -j(n) fails with: > > Yeah, I have confirmed it; I was wondering why I didn't meet such build > error. > > > > > dpdk/lib/librte_vhost/vhost_rxtx.c:41:20: > > fatal error: rte_ip.h: No such file or directory > > > > Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") > > Signed-off-by: Panu Matilainen > > Acked-by: Yuanhan Liu Applied, thanks