From: Thomas Monjalon <thomas@monjalon.net>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>, rasland@mellanox.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen
Date: Thu, 03 Aug 2017 22:32:29 +0200 [thread overview]
Message-ID: <1594412.gasu7JyoN7@xps> (raw)
In-Reply-To: <20170803135831.GG8124@bidouze.vm.6wind.com>
03/08/2017 15:58, Gaëtan Rivet:
> Hi Raslan,
>
> I sent a patch earlier regarding this but we will use yours.
> Two small nits below.
>
> On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasland@mellanox.com wrote:
> > From: Raslan Darawsheh <rasland@mellanox.com>
> >
> > When there is no prefered device, failsafe will always
> > try to scan for prefered device. And if there is no device
> > found with the exec option, popen() will get an empty output.
> > In this case, it was forgotten to close the file descriptor.o
> > it is fixed by closing the file descriptor even if the output is emtpy.
> >
>
> Good job on finding the issue and fixing it.
> It has been assigned a coverity ID:
>
> Coverity issue: 158633
> > Fixes: a0194d82 ("net/failsafe: add flexible device definition")
> >
>
> The fixline should be 12-char long I think:
> Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
>
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
>
> Otherwise:
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
prev parent reply other threads:[~2017-08-03 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 13:09 rasland
2017-08-03 13:58 ` Gaëtan Rivet
2017-08-03 20:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594412.gasu7JyoN7@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=rasland@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).