From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2A8412C16 for ; Thu, 3 Aug 2017 22:32:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B36642088A; Thu, 3 Aug 2017 16:32:31 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 16:32:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=PJLvA45n24V6USN gTX9X0oigwelBs3TKYU9rF4uRqtk=; b=Yi6eOz6HlHxMhnJ/aaQNlLHP/U+N5Mb 3Vivnn4cD4ejx7tGaDPLiO10v9zbnvBOu4puN7/X3B5175xIDZZA3xGLNKOnedCs 738UX0yViLFU6q/CgqtsC4PHM79eWiScdgjWEzYJhm4+qKRzrDu2fDjWDzp5sRs1 BXAWh9P1pqY0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=PJLvA45n24V6USNgTX9X0oigwelBs3TKYU9rF4uRqtk=; b=kBYdC5rb eGg9J0MFsgILqtMZ6OQKZp0cDYPIiRXOSMl59HqQgDqtoCm6GiErNJUGU1Ciws1A NSkkujUXNiXC0hxnqGMK4Sg3Z4/iZZBjSqHxTtEcQV7ww238DmTVZ8sARSO+XGXk lgLO+rZx7O31TbzHZvWAalbs1pKxrxCeLu3teYgRMdF0srBufp/eADsIofrRiuBG dWJKs0ljEmiI54YRT2wdxCp4vG4Otw4gEAjEqml2huxt1QbUqseFY8Bj61RQinz/ GUe/oV8cRuSNpro9Ea37e/wapT89uxp3XiZRghZ9wnAaTFS+9LyFtmvyvQTq1Lah osod0ufgFUAIGQ== X-ME-Sender: X-Sasl-enc: CFyjov2jmnRLBdJIB1+gfNvI9FGL3NKLk5oWeDHfxXYg 1501792351 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 49B712456C; Thu, 3 Aug 2017 16:32:31 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , rasland@mellanox.com Cc: dev@dpdk.org Date: Thu, 03 Aug 2017 22:32:29 +0200 Message-ID: <1594412.gasu7JyoN7@xps> In-Reply-To: <20170803135831.GG8124@bidouze.vm.6wind.com> References: <1501765798-14200-1-git-send-email-rasland@mellanox.com> <20170803135831.GG8124@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix for missing pclose after popen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 20:32:32 -0000 03/08/2017 15:58, Ga=EBtan Rivet: > Hi Raslan, >=20 > I sent a patch earlier regarding this but we will use yours. > Two small nits below. >=20 > On Thu, Aug 03, 2017 at 04:09:58PM +0300, rasland@mellanox.com wrote: > > From: Raslan Darawsheh > >=20 > > When there is no prefered device, failsafe will always > > try to scan for prefered device. And if there is no device > > found with the exec option, popen() will get an empty output. > > In this case, it was forgotten to close the file descriptor.o > > it is fixed by closing the file descriptor even if the output is emtpy. > >=20 >=20 > Good job on finding the issue and fixing it. > It has been assigned a coverity ID: >=20 > Coverity issue: 158633 > > Fixes: a0194d82 ("net/failsafe: add flexible device definition") > >=20 >=20 > The fixline should be 12-char long I think: > Fixes: a0194d828100 ("net/failsafe: add flexible device definition") >=20 > > Signed-off-by: Raslan Darawsheh >=20 > Otherwise: >=20 > Acked-by: Gaetan Rivet Applied, thanks