From: Thomas Monjalon <thomas@monjalon.net>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
ferruh.yigit@intel.com, adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix crash on deleting flow drop queue
Date: Fri, 05 May 2017 17:48:37 +0200 [thread overview]
Message-ID: <1596826.VfqBUcD350@xps> (raw)
In-Reply-To: <20170502064515.GE31330@autoinstall.dev.6wind.com>
02/05/2017 08:45, Nélio Laranjeiro:
> On Mon, May 01, 2017 at 02:05:42PM -0700, Yongseok Koh wrote:
> > If mlx5_dev_start() fails, it tries to rollback data structures related to
> > rte_flow including drop queue. The destruction code doesn't assume the
> > structures are created but priv_flow_delete_drop_queue() never does sanity
> > check. This can cause a crash.
> >
> > Fixes: 028761059aeb ("net/mlx5: use an RSS drop queue")
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied, thanks
prev parent reply other threads:[~2017-05-05 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 21:05 Yongseok Koh
2017-05-02 6:45 ` Nélio Laranjeiro
2017-05-05 15:48 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596826.VfqBUcD350@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).