From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 55F674CE4
 for <dev@dpdk.org>; Fri,  5 May 2017 17:48:39 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id F13532085C;
 Fri,  5 May 2017 11:48:38 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Fri, 05 May 2017 11:48:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=LNeUnl57Ia1O2Ah
 Vj0bQEbrKp7bO33NFBIN1cj8vBAI=; b=h1wLSlOp1b8ontLKOZOtI9IBcsi4Mex
 /jaVYqZLziMTsddwn/hw+efNsyOlKwZwUueRjpgTzXqkYk8wQicFIYXp6QQysmpA
 bR1oOfbAq29LOpuW+mEoEdjux3lpAkrVJs+of1d2etOAk0ko5JV+cUHSuYhxkArC
 s9iqRknHQvNc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=LNeUnl57Ia1O2AhVj0bQEbrKp7bO33NFBIN1cj8vBAI=; b=W9jb8nq/
 WEhoFCGFInv0WfgZWVPCmjw5tlVu6RV1Bfkbys6TpPg6W82bzco43SkfXfUyd4aY
 vrcNmJRwoLH0MTKVD4mqIn7DfPQdMVQd/nwlH+ZpdIUGI/HqGofkOmRZWdFNaxug
 Qf9HERFbdDHTgWkqFSB9H/1/PShvH34pmWnGKBMeJD22VAHrrBi5TfihtLnc8gwW
 jCgZJp/w5JyK1eaYmUEp5BFlJ1hUxqKY91j8vmrqhIBknQOCKACsvZaB7gCgBXh3
 lHHWJGnBC8bL67NYEMSHcM0WEwC1GZMpjZdIn2FZhR4JVgSC4oW+f4xeDDVtktk2
 7fxDcHDKrP2NQg==
X-ME-Sender: <xms:1p4MWRkTbAXmo6cMyEqwHXxkqKga0_m_W9zpRv1AJf9ugfF3t-bD5w>
X-Sasl-enc: Kyz4+OdZx6k+2HNh/oSUgMoUlDZ4kn8mBLc6wRbvp8my 1493999318
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id A74307E316;
 Fri,  5 May 2017 11:48:38 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org,
 =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>,
 ferruh.yigit@intel.com, adrien.mazarguil@6wind.com
Date: Fri, 05 May 2017 17:48:37 +0200
Message-ID: <1596826.VfqBUcD350@xps>
In-Reply-To: <20170502064515.GE31330@autoinstall.dev.6wind.com>
References: <20170501210542.5032-1-yskoh@mellanox.com>
 <20170502064515.GE31330@autoinstall.dev.6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix crash on deleting flow drop
	queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 May 2017 15:48:39 -0000

02/05/2017 08:45, N=E9lio Laranjeiro:
> On Mon, May 01, 2017 at 02:05:42PM -0700, Yongseok Koh wrote:
> > If mlx5_dev_start() fails, it tries to rollback data structures related=
 to
> > rte_flow including drop queue. The destruction code doesn't assume the
> > structures are created but priv_flow_delete_drop_queue() never does san=
ity
> > check. This can cause a crash.
> >=20
> > Fixes: 028761059aeb ("net/mlx5: use an RSS drop queue")
> >=20
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>=20
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied, thanks