* [dpdk-dev] [PATCH] vfio: fix compilation errors in bsdapp
@ 2018-01-17 16:23 Moti Haimovsky
2018-01-17 17:07 ` Burakov, Anatoly
2018-01-17 17:24 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
0 siblings, 2 replies; 4+ messages in thread
From: Moti Haimovsky @ 2018-01-17 16:23 UTC (permalink / raw)
To: thomasm; +Cc: dev, Moti Haimovsky, Hemant Agrawal
This patch fixes the following compilation errors in bsdapp
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5:
error: no previous prototype for function 'rte_vfio_clear_group'
[-Werror,-Wmissing-prototypes]
int rte_vfio_clear_group(int vfio_group_fd)
^
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30:
error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter]
int rte_vfio_clear_group(int vfio_group_fd)
^
Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages")
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
lib/librte_eal/bsdapp/eal/eal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 7239243..cf72537 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -70,6 +70,7 @@
#include <rte_version.h>
#include <rte_atomic.h>
#include <malloc_heap.h>
+#include <rte_vfio.h>
#include "eal_private.h"
#include "eal_thread.h"
@@ -779,7 +780,7 @@ int rte_vfio_noiommu_is_enabled(void)
return 0;
}
-int rte_vfio_clear_group(int vfio_group_fd)
+int rte_vfio_clear_group(__rte_unused int vfio_group_fd)
{
return 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] vfio: fix compilation errors in bsdapp
2018-01-17 16:23 [dpdk-dev] [PATCH] vfio: fix compilation errors in bsdapp Moti Haimovsky
@ 2018-01-17 17:07 ` Burakov, Anatoly
2018-01-17 17:24 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
1 sibling, 0 replies; 4+ messages in thread
From: Burakov, Anatoly @ 2018-01-17 17:07 UTC (permalink / raw)
To: Moti Haimovsky, thomasm; +Cc: dev, Hemant Agrawal
On 17-Jan-18 4:23 PM, Moti Haimovsky wrote:
> This patch fixes the following compilation errors in bsdapp
> /home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5:
> error: no previous prototype for function 'rte_vfio_clear_group'
> [-Werror,-Wmissing-prototypes]
> int rte_vfio_clear_group(int vfio_group_fd)
> ^
> /home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30:
> error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter]
> int rte_vfio_clear_group(int vfio_group_fd)
> ^
> Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages")
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] vfio: fix compilation errors in bsdapp
2018-01-17 16:23 [dpdk-dev] [PATCH] vfio: fix compilation errors in bsdapp Moti Haimovsky
2018-01-17 17:07 ` Burakov, Anatoly
@ 2018-01-17 17:24 ` Moti Haimovsky
2018-01-17 17:50 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Moti Haimovsky @ 2018-01-17 17:24 UTC (permalink / raw)
To: thomas; +Cc: dev, Moti Haimovsky, Hemant Agrawal
This patch fixes the following compilation errors in bsdapp
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5:
error: no previous prototype for function 'rte_vfio_clear_group'
[-Werror,-Wmissing-prototypes]
int rte_vfio_clear_group(int vfio_group_fd)
^
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30:
error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter]
int rte_vfio_clear_group(int vfio_group_fd)
^
Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages")
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
V2:
* Added a stub routine instead of including the rte_vfio.h file which is only valid
in Linux applications
---
lib/librte_eal/bsdapp/eal/eal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 7239243..04cbd81 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -748,6 +748,7 @@ int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
int rte_vfio_enable(const char *modname);
int rte_vfio_is_enabled(const char *modname);
int rte_vfio_noiommu_is_enabled(void);
+int rte_vfio_clear_group(int vfio_group_fd);
int rte_vfio_setup_device(__rte_unused const char *sysfs_base,
__rte_unused const char *dev_addr,
@@ -779,7 +780,7 @@ int rte_vfio_noiommu_is_enabled(void)
return 0;
}
-int rte_vfio_clear_group(int vfio_group_fd)
+int rte_vfio_clear_group(__rte_unused int vfio_group_fd)
{
return 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] vfio: fix compilation errors in bsdapp
2018-01-17 17:24 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
@ 2018-01-17 17:50 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-01-17 17:50 UTC (permalink / raw)
To: Moti Haimovsky; +Cc: dev, Hemant Agrawal
17/01/2018 18:24, Moti Haimovsky:
> This patch fixes the following compilation errors in bsdapp
> /home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5:
> error: no previous prototype for function 'rte_vfio_clear_group'
> [-Werror,-Wmissing-prototypes]
> int rte_vfio_clear_group(int vfio_group_fd)
> ^
> /home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30:
> error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter]
> int rte_vfio_clear_group(int vfio_group_fd)
> ^
> Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages")
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-17 17:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 16:23 [dpdk-dev] [PATCH] vfio: fix compilation errors in bsdapp Moti Haimovsky
2018-01-17 17:07 ` Burakov, Anatoly
2018-01-17 17:24 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
2018-01-17 17:50 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).