From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 72B3F2C74 for ; Tue, 14 Feb 2017 09:50:29 +0100 (CET) Received: by mail-wr0-f170.google.com with SMTP id k90so164604613wrc.3 for ; Tue, 14 Feb 2017 00:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=EUJ7KYuRwMcDt87W0p+qLJvT5YtRDhdsC8P/+1xh0AQ=; b=i86QsTQ6N9g4OYN0Hgg+kVFEPMT0V9zfa10rEEPp9lbiXltI5iAgA2nlWqUlMU7MzH uE0ZL2tKjkVuVnr1zjyJE3fqITJjzmcxnnK/hJIz2SwHbXOdptUKdX9lk9s4PxBKZQr0 CfMcG23O9wlzFf3Lz2tP6Mi1dln63dFMDoj7zGUG2/uQ+16GJr0aO5/NgbdH4D3FRo5B 0dYp3dfGnPWjrAcKwkWq0ZkdM38Nc7ovuhLe2rfN9vmvLVq5hdUXSyyNUF591XROSd9E YxN6gjPcuq5PoRxXnvSVZQ7j14ySzhAYPs3FeR0Gqmuo672s/PULIToohK3jM60kBZjN JNKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=EUJ7KYuRwMcDt87W0p+qLJvT5YtRDhdsC8P/+1xh0AQ=; b=aKUrm3hu359wUn31A2lFQ5kfOgEAhFlYyxqKZS1kIgtmavfHq/Gndl942bcKJMr5eF ol1PvQjriDIoloN1yxxiNYVQJPY+yEvEqYN/Pfxr4jYxvrTzgz6OsFMz8v9BMGzJxaCG YkZgcow8KPn9R5OJJ69bJKzElkxsrM1Kx96hiCvNihenK0jXJwC4tDdsMrrLqTVmJF0B 4ynw/H7Ol/NEkYx700iLxSTsMekltsyhq1JwItfdjOf8b5Ga9O6oSPDyvbMcnVX7ZfkT /PgDqNUxjvJ8305NVhusq3NF1Gd+n9nnjPEVQXZCbAphczT5x9zXcmdg6JBuOHsQZQO7 AhIQ== X-Gm-Message-State: AMke39nVX4vpsf2tbNREd8go/0Te4/a6rdPHLo/wOuNulI1vQXkgfAAvf2SVP+LkxTD4uisB X-Received: by 10.223.130.111 with SMTP id 102mr26286042wrb.59.1487062229019; Tue, 14 Feb 2017 00:50:29 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id n10sm17030508wrb.9.2017.02.14.00.50.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Feb 2017 00:50:28 -0800 (PST) From: Thomas Monjalon To: Yong Wang Cc: dev@dpdk.org, wenzhuo.lu@intel.com Date: Tue, 14 Feb 2017 09:50:27 +0100 Message-ID: <1597373.SEVY7yqftY@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1487063647-16263-1-git-send-email-wang.yong19@zte.com.cn> References: <1487063647-16263-1-git-send-email-wang.yong19@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] e1000/base: fix the wrong assignment to msgbuf[0] X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 08:50:29 -0000 2017-02-14 04:14, Yong Wang: > In function e1000_update_mc_addr_list_vf(), "msgbuf[0]" is used prior > to initialization at "msgbuf[0] |= E1000_VF_SET_MULTICAST_OVERFLOW". > And "msgbuf[0]" is overwritten at "msgbuf[0] = E1000_VF_SET_MULTICAST". > Fix it by moving the second line prior to the first one that mentioned > above. > > Signed-off-by: Yong Wang Note about the title: msgbuf[0] does not explain anything in the title because we have no context when browsing the titles. It could be "e1000/base: fix multicast setting in VF".