From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
Gagandeep Singh <G.Singh@nxp.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Nipun Gupta <nipun.gupta@nxp.com>,
honnappa.nagarahalli@arm.com, Steve Capper <steve.capper@arm.com>,
jerinj@marvell.com, bruce.richardson@intel.com, gavin.hu@arm.com,
konstantin.ananyev@intel.com, drc@linux.vnet.ibm.com
Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4
Date: Thu, 08 Aug 2019 09:31:47 +0200 [thread overview]
Message-ID: <15982978.NnXy4IA2Yx@xps> (raw)
In-Reply-To: <VI1PR0401MB25416710B44AAD881BED4D1389D40@VI1PR0401MB2541.eurprd04.prod.outlook.com>
07/08/2019 15:28, Hemant Agrawal:
> HI Thomas,
>
> > > > DPDK currently is supporting maximum 3 hugepage, sizes whereas
> > > > system can support more than this e.g.
> > > > 64K, 2M, 32M and 1G.
> > >
> > > You can mention ARM platform here, and that this issue starts with
> > > kernel 5.2 (and I would try to mention this in the title as well).
> > > This is better than an annotation that will be lost.
> > >
> > >
> > > > Having these four hugepage sizes available to use by DPDK, which is
> > > > valid in case of '--in-memory' EAL option or using 4 separate mount
> > > > points for each hugepage size;
> > > > hugepage_info_init() API reports an error.
> > >
> > > Can you describe what is the impact from a user point of view rather
> > > than mentioning this internal function?
> >
> > Yes please, we need to understand how much it is critical.
> > Should we Cc stable@dpdk.org for backport?
> > Should it be merged at the last minute in 19.08?
>
> VPP usages in-memory option. So, VPP on ARM with kernel 5.2 wont' work without this patch.
Do you want to send a v2 with a better explanation?
I would suggest to restrict the change to Arm only with an ifdef,
in order to limit the risk for this release.
We can think about a dynamic hugepage scan in the next release.
next prev parent reply other threads:[~2019-08-08 7:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 10:12 Gagandeep Singh
2019-08-07 12:00 ` David Marchand
2019-08-07 12:07 ` Thomas Monjalon
2019-08-07 13:28 ` Hemant Agrawal
2019-08-08 7:31 ` Thomas Monjalon [this message]
2019-08-12 9:43 ` Burakov, Anatoly
2019-08-12 9:49 ` David Marchand
2019-08-12 10:01 ` Thomas Monjalon
2019-08-12 10:38 ` Burakov, Anatoly
2019-08-08 7:33 ` David Marchand
2019-08-08 9:00 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-08-08 10:37 ` [dpdk-dev] " Hemant Agrawal
2019-08-08 12:29 ` Steve Capper
2019-08-08 12:39 ` David Marchand
2019-08-12 9:42 ` Burakov, Anatoly
2019-08-07 15:27 ` Stephen Hemminger
2019-08-08 12:13 ` [dpdk-dev] [PATCH v2] eal: change max hugepage sizes to 4 for ARM platforms Gagandeep Singh
2019-08-08 12:37 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-08-08 15:26 ` Thomas Monjalon
2019-08-07 12:47 [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 Gagandeep Singh
2019-08-07 12:53 Gagandeep Singh
2019-08-07 14:09 ` Honnappa Nagarahalli
2019-08-08 9:00 Gagandeep Singh
2019-08-08 9:22 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15982978.NnXy4IA2Yx@xps \
--to=thomas@monjalon.net \
--cc=G.Singh@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=steve.capper@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).