From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id DCA319AA7 for ; Wed, 22 Jun 2016 14:21:02 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id v199so85162517wmv.0 for ; Wed, 22 Jun 2016 05:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uz2Enpkt97dEkf+BXAGMg0JqIFcgTI28OQsQNd6fL0M=; b=XOFIRtsPWmwSmBol6RQt1vfyVPaLJLoPj2NP82K18DRPAYzkb56xtnft0VbXbqU4pT dAz8+4GBl8225W25lYEe1Z3cFTWNzVLEgLtsTdR0DVWI+fsXVP6/aA71e259Qj6GHS4x WG4b0NFBlB1zwHUkmkenc1rsVv2LxTeoWI3Xq4PVJLOUClA0dNXMITB88aSzhpLakTKp Jgi9r8DKq2gdhkM9ceFNUn1PnkI1aqW6wLhR8Tf2acjlT6PxkTsfMbHsndfQJT1nVfJr G1oOOqXVqUIdchbdzBujP3vJ8oHzHAI6SQjJQU+azk30EoYbXywhjaHzRDW4S62mDbVI V5gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Uz2Enpkt97dEkf+BXAGMg0JqIFcgTI28OQsQNd6fL0M=; b=DY9WsagwhsBPP2IMzptknR306Rb4cBbo5u1/P9X3S8lAq1FzJeExCGQkRu+hj2RIL0 yg8kKVPzIldw90AH83bb2NENpbOfuRpPMbAh6aouX++DzgZbZE5Z8UQYRvxYNnULlRxb LUFXlO0huWEWxixwI1sfcyOG2s2d+0FZsiucYYBD4th7HGImWr7eMWtZkMpZ7xc7P685 HOxj5Hweb1RiIxh07pexwS1oXait74+J3lVs8PjQH/L87eb2n30IYG76HYePlFsdt+WW O98FyD6SthmW+tllbGPm/+Bo7kkxX2jBrTcYzUIIhDdryBXwuNd+q3+q3sA/yxp1zsV1 OREQ== X-Gm-Message-State: ALyK8tJJAedTImJtktmUNGgnnypGx2C2zXmzbP/W5/2g9OUAH4eNOtQJ/+FyTdQEGNXsIkNC X-Received: by 10.28.129.208 with SMTP id c199mr7976212wmd.79.1466598062690; Wed, 22 Jun 2016 05:21:02 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d192sm386128wmd.14.2016.06.22.05.21.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jun 2016 05:21:00 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: Panu Matilainen , dev@dpdk.org, cristian.dumitrescu@intel.com, zhuangwj@gmail.com Date: Wed, 22 Jun 2016 14:20:59 +0200 Message-ID: <1598312.eZ7tuG1m5F@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <576A7D20.4030801@6wind.com> References: <191edb8105649612fab5f0e691f587715b78e664.1466595242.git.pmatilai@redhat.com> <293319946.9flpxUKHBY@xps13> <576A7D20.4030801@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] port: fix build when KNI support is not enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 12:21:03 -0000 2016-06-22 13:57, Olivier Matz: > Hi Thomas, > > On 06/22/2016 01:49 PM, Thomas Monjalon wrote: > > 2016-06-22 14:34, Panu Matilainen: > >> --- a/lib/librte_port/Makefile > >> +++ b/lib/librte_port/Makefile > >> @@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mempool > >> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ether > >> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ip_frag > >> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_sched > >> +ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) > >> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_kni > >> +endif > > > > I do not remember why $(CONFIG_RTE_LIBRTE_PORT) is needed in its Makefile. > > I think we can do > > DEPDIRS-$(CONFIG_RTE_LIBRTE_KNI) += lib/librte_kni > > and set DEPDIRS-y everywhere else. > > > > It's probably not much used, but the build framework allows to do > the following to build only one directory: > > make lib/librte_port_sub > > This directly jumps to the librte_port Makefile, bypassing parent > directories. I think that's why the config check is duplicated in the > Makefile. If we want to specifically build this directory, why preventing us to do so with CONFIG_RTE_LIBRTE_PORT?