From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2AA3A04C4; Wed, 20 Nov 2019 21:10:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86C372AB; Wed, 20 Nov 2019 21:10:52 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 061FE271 for ; Wed, 20 Nov 2019 21:10:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 65ED021EAF; Wed, 20 Nov 2019 15:10:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 20 Nov 2019 15:10:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Yaxsg6vyY2Q27l3OtYkd6sArh1B5XlaShRkt8EdO7gw=; b=ruQbhXg9XaIN RdhiVzzB1ntV4tNoSMFgFNVDbd2nR/svrQ0LcHq8+uyBzwq6vvvAOehn4JnY9iAr BmXYzKGXx1dB2bO4/V6L2u7ur67g/bblpXFZKDV24AmIgpmmfAuiF+EF4YO2FVl8 nDwUEmWWm4sF0xm2TxsT4welJp7NF58= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Yaxsg6vyY2Q27l3OtYkd6sArh1B5XlaShRkt8EdO7 gw=; b=pO4wWZz1HavsuRYM60rtXWvtZwvsi0x2vD1DkMY//UHDTkqHkOl7qj6OX qMrY24Tvo11EOBqjnp+uDZyw49zTsBJlbqYX8VwU2OEDEmBqcth6o96W2sew/X35 dye7501u31BiGh1Oxtb+TJZu2qev602Sl/iIa1Lg8Jfl503nrW8bajZWv4AL8obE YLTLks8ZTRX6iZ2lwQ5TABvbBRKzfQDmPJFLQUOVGK/223vlnoFqjqEWFodS0IIO JJswo5x0gvv/1/iJNxQrkcI0mNSTdKrxDzK4HINWecPNjj6qFdg05zI/kpWpM2Ty lFMdinFf85fY5Evx4fxDl0MZRzI8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehtddgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B18948005B; Wed, 20 Nov 2019 15:10:48 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Reshma Pattan Cc: dev@dpdk.org, ferruh.yigit@intel.com, ktraynor@redhat.com Date: Wed, 20 Nov 2019 21:10:47 +0100 Message-ID: <1599153.cD6TPcZsql@xps> In-Reply-To: <20191119112235.GA1536@bricha3-MOBL.ger.corp.intel.com> References: <20191119110357.24019-1-reshma.pattan@intel.com> <20191119112235.GA1536@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/11/2019 12:22, Bruce Richardson: > On Tue, Nov 19, 2019 at 11:03:57AM +0000, Reshma Pattan wrote: > > --- a/doc/guides/contributing/patches.rst > > +++ b/doc/guides/contributing/patches.rst > > - git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" > > + git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae%nCc: stable@dpdk.org'" > > > > The output of ``git fixline `` must then be added to the commit message:: > > While a good idea, we don't always want to CC stable for all fixes, as > fixes for commits in the current release obviously don't need backports. I've done something which proposes some Cc, some time ago: fixline = "!f () { git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' $1 ; ( git tag -l --contains $1 | head -n1 | sed 's,^v,,' | sed 's,-rc.*,,' ; for i in 1 2 ; do make showversion | cut -d'.' -f-2 ; done ) | uniq -u | head -n1 | sed 's,.*,Cc: stable@dpdk.org,' ;}; f" > I suggest the stable maintainers comment on whether receiving these > additional patches would be a problem for them, or if their tooling is > sufficiency advanced for them to ignore these without issue... Anyway, the developer must think about when backport is really needed. It is a bad idea to document it as automatic.