* [dpdk-dev] [PATCH] net/sfc/base: fix tunnel configuration failure
@ 2020-08-06 13:43 Andrew Rybchenko
2020-09-08 9:20 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2020-08-06 13:43 UTC (permalink / raw)
To: dev; +Cc: Igor Romanov, stable
From: Igor Romanov <igor.romanov@oktetlabs.ru>
Tunnel configuration may fail because of insufficient access rights
on a virtual function. Ignore the failure if a tunnel configuration
with empty UDP ports is requrested.
Fixes: 17551f6dffcc ("net/sfc/base: add API to control UDP tunnel ports")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/efx_tunnel.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/sfc/base/efx_tunnel.c b/drivers/net/sfc/base/efx_tunnel.c
index 3a03441..1cc072f 100644
--- a/drivers/net/sfc/base/efx_tunnel.c
+++ b/drivers/net/sfc/base/efx_tunnel.c
@@ -421,7 +421,7 @@
{
efx_tunnel_cfg_t *etcp = &enp->en_tunnel_cfg;
efx_rc_t rc;
- boolean_t resetting;
+ boolean_t resetting = B_FALSE;
efsys_lock_state_t state;
efx_tunnel_cfg_t etc;
@@ -446,8 +446,14 @@
*/
rc = efx_mcdi_set_tunnel_encap_udp_ports(enp, &etc, B_FALSE,
&resetting);
- if (rc != 0)
- goto fail2;
+ if (rc != 0) {
+ /*
+ * Do not fail if the access is denied when no
+ * tunnel encap UDP ports are configured.
+ */
+ if (rc != EACCES || etc.etc_udp_entries_num != 0)
+ goto fail2;
+ }
/*
* Although the caller should be able to handle MC reboot,
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH v2] net/sfc/base: fix tunnel configuration failure
2020-08-06 13:43 [dpdk-dev] [PATCH] net/sfc/base: fix tunnel configuration failure Andrew Rybchenko
@ 2020-09-08 9:20 ` Andrew Rybchenko
2020-09-18 12:02 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2020-09-08 9:20 UTC (permalink / raw)
To: dev; +Cc: Igor Romanov, stable
From: Igor Romanov <igor.romanov@oktetlabs.ru>
Tunnel configuration may fail because of insufficient access rights
on a virtual function. Ignore the failure if a tunnel configuration
with empty UDP ports is requested.
Fixes: 17551f6dffcc ("net/sfc/base: add API to control UDP tunnel ports")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/efx_tunnel.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/sfc/base/efx_tunnel.c b/drivers/net/sfc/base/efx_tunnel.c
index 3a034412cd..1cc072f0d9 100644
--- a/drivers/net/sfc/base/efx_tunnel.c
+++ b/drivers/net/sfc/base/efx_tunnel.c
@@ -421,7 +421,7 @@ ef10_tunnel_reconfigure(
{
efx_tunnel_cfg_t *etcp = &enp->en_tunnel_cfg;
efx_rc_t rc;
- boolean_t resetting;
+ boolean_t resetting = B_FALSE;
efsys_lock_state_t state;
efx_tunnel_cfg_t etc;
@@ -446,8 +446,14 @@ ef10_tunnel_reconfigure(
*/
rc = efx_mcdi_set_tunnel_encap_udp_ports(enp, &etc, B_FALSE,
&resetting);
- if (rc != 0)
- goto fail2;
+ if (rc != 0) {
+ /*
+ * Do not fail if the access is denied when no
+ * tunnel encap UDP ports are configured.
+ */
+ if (rc != EACCES || etc.etc_udp_entries_num != 0)
+ goto fail2;
+ }
/*
* Although the caller should be able to handle MC reboot,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/sfc/base: fix tunnel configuration failure
2020-09-08 9:20 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
@ 2020-09-18 12:02 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-09-18 12:02 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: Igor Romanov, stable
On 9/8/2020 10:20 AM, Andrew Rybchenko wrote:
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> Tunnel configuration may fail because of insufficient access rights
> on a virtual function. Ignore the failure if a tunnel configuration
> with empty UDP ports is requested.
>
> Fixes: 17551f6dffcc ("net/sfc/base: add API to control UDP tunnel ports")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-18 12:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 13:43 [dpdk-dev] [PATCH] net/sfc/base: fix tunnel configuration failure Andrew Rybchenko
2020-09-08 9:20 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2020-09-18 12:02 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).