From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C91D81B1AB for ; Tue, 9 Jan 2018 15:38:05 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C463699DA8; Tue, 9 Jan 2018 14:38:04 +0000 (UTC) Received: from [10.36.112.39] (ovpn-112-39.ams2.redhat.com [10.36.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 946F67C665; Tue, 9 Jan 2018 14:38:02 +0000 (UTC) To: Xiao Wang , yliu@fridaylinux.org, thomas@monjalon.net Cc: tiwei.bie@intel.com, dev@dpdk.org, stephen@networkplumber.org References: <20180109142651.84582-4-xiao.w.wang@intel.com> <20180109132654.3504-1-xiao.w.wang@intel.com> From: Maxime Coquelin Message-ID: <15b1a2d8-7b9f-46fa-a3f0-d2451bfba9dc@redhat.com> Date: Tue, 9 Jan 2018 15:38:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180109132654.3504-1-xiao.w.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 09 Jan 2018 14:38:05 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v8 0/5] net/virtio: support GUEST ANNOUNCE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 14:38:06 -0000 On 01/09/2018 02:26 PM, Xiao Wang wrote: > v8: > - Add a helper in lib/librte_net to make rarp packet, it's used by > both vhost and virtio. > > v7: > - Improve comment for state_lock. > - Rename spinlock variable 'sl' to 'lock'. > > v6: > - Use rte_pktmbuf_alloc() instead of rte_mbuf_raw_alloc(). > - Remove the 'len' parameter in calling virtio_send_command(). > - Remove extra space between typo and var. > - Improve comment and alignment. > - Remove the unnecessary header file. > - A better usage of 'unlikely' indication. > > v5: > - Remove txvq parameter in virtio_inject_pkts. > - Zero hw->special_buf after using it. > - Return the retval of tx_pkt_burst(). > - Allocate a mbuf pointer on stack directly. > > v4: > - Move spinlock lock/unlock into dev_pause/resume. > - Separate out a patch for packet injection. > > v3: > - Remove Tx function code duplication, use a special pointer for rarp > injection. > - Rename function generate_rarp to virtio_notify_peers, replace > 'virtnet_' with 'virtio_'. > - Add comment for state_lock. > - Typo fix and comment improvement. > > v2: > - Use spaces instead of tabs between the code and comments. > - Remove unnecessary parentheses. > - Use rte_pktmbuf_mtod directly to get eth_hdr addr. > - Fix virtio_dev_pause return value check. > > Xiao Wang (5): > net/virtio: make control queue thread-safe > net/virtio: add packet injection method > net: add a helper for making RARP packet For for handling the change! > vhost: use lib API to make RARP packet > net/virtio: support GUEST ANNOUNCE > > drivers/net/virtio/virtio_ethdev.c | 118 +++++++++++++++++++++++++++++++- > drivers/net/virtio/virtio_ethdev.h | 6 ++ > drivers/net/virtio/virtio_pci.h | 7 ++ > drivers/net/virtio/virtio_rxtx.c | 3 +- > drivers/net/virtio/virtio_rxtx.h | 1 + > drivers/net/virtio/virtio_rxtx_simple.c | 2 +- > drivers/net/virtio/virtqueue.h | 11 +++ > lib/Makefile | 3 +- > lib/librte_net/Makefile | 1 + > lib/librte_net/rte_arp.c | 42 ++++++++++++ > lib/librte_net/rte_arp.h | 14 ++++ > lib/librte_net/rte_net_version.map | 6 ++ > lib/librte_vhost/Makefile | 2 +- > lib/librte_vhost/virtio_net.c | 41 +---------- > 14 files changed, 210 insertions(+), 47 deletions(-) > create mode 100644 lib/librte_net/rte_arp.c > For the series: Reviewed-by: Maxime Coquelin Maxime