From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 556481CAA7 for <dev@dpdk.org>; Sat, 7 Apr 2018 11:18:29 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id D463C4C0059; Sat, 7 Apr 2018 09:18:27 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 7 Apr 2018 10:18:23 +0100 From: Andrew Rybchenko <arybchenko@solarflare.com> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org> References: <20180404150312.12304-1-adrien.mazarguil@6wind.com> <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180406131736.19145-2-adrien.mazarguil@6wind.com> <804ca327-c2d8-4ef8-dd15-7ddcefc7ac99@solarflare.com> Message-ID: <15bb95cd-4c7a-673f-85c2-c798724b6417@solarflare.com> Date: Sat, 7 Apr 2018 12:18:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <804ca327-c2d8-4ef8-dd15-7ddcefc7ac99@solarflare.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23768.003 X-TM-AS-Result: No--12.127500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523092708-9kfj72y6OVrA Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 01/15] ethdev: add error types to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 07 Apr 2018 09:18:29 -0000 On 04/07/2018 12:15 PM, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: >> These enable more precise reporting of objects responsible for errors. >> >> This breaks ABI compatibility for the following public functions: >> >> - rte_flow_create() >> - rte_flow_destroy() >> - rte_flow_error_set() >> - rte_flow_flush() >> - rte_flow_isolate() >> - rte_flow_query() >> - rte_flow_validate() >> >> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> >> --- >> app/test-pmd/config.c | 4 ++++ >> lib/librte_ether/rte_ethdev_version.map | 20 +++++++++++++------- >> lib/librte_ether/rte_flow.h | 4 ++++ >> 3 files changed, 21 insertions(+), 7 deletions(-) > > I think PMD maintainers with flow API support should be additionally > notified and encouraged to refine error reporting. Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>