From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 4BB857CE2 for ; Fri, 2 Jun 2017 01:49:12 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id b84so6905376wmh.0 for ; Thu, 01 Jun 2017 16:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:date:message-id:in-reply-to:references:user-agent :subject:mime-version:content-transfer-encoding; bh=ZNwtDDk2YubSd827VtoqnyTfnztqJ9ek/TwoVHIPKEA=; b=IDFdwm3HppiCVHrdTa7pGMrcjXe041C+mUFXLSc+w5AFE7FjvuzJS7rAqqJ6+855VO egU6a+UxOtY9MiDEy51VCyYm8jp1ABxS6B4bB/ZB5eZeNto+Vbg9Ee6fO/AhJiCz0OyM a8cDe4vfY/VJ9WPTKJ91nJTnmjVWDdaKaNntec4TSbL4lXmi0cB9QhwbsyCMzHJU9/M7 Zslu+xAjs7eqnMeif7FxRRFhcm/ujIojn2OPI422yGSz3ZIPcLCdQZwG6pSMLwADVXrV I2mPogc832TlenqfPW1skm/GaqyR3T65AYHvve2Y4GZVeb/rYt49IQlm2yAbFLuTxa0Z rOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:user-agent:subject:mime-version :content-transfer-encoding; bh=ZNwtDDk2YubSd827VtoqnyTfnztqJ9ek/TwoVHIPKEA=; b=RtOgeUbsqiFirtni5H8dhEJeR1QF/eat40NNyH9KCTvp7bN6GMZaNn2N4ygUZD0Abd C8vAI28FDldXCGkgWyJbliHCZ1k+6qhm2LHelHBCT1As428VVc59SZ1zc7eVKCJF3GCF 9g1o+kTxUKCMBYfEzREBPNWz0KaJifhLxVZNV8IxNuMSmnd651nmhvu0Sk4mhKimiqUt ccJwyGLviDkNL/ORJMVEGYhilAWb7nOLpr9mDHlTslCIvTDVJtXan/CXaws73u6l/MX+ t2gtBaxFFgBLITbnlEq9icTQMcRmbqRwy3PtOhXuq17r8fCsLdym0eVgSABClP59/Zun SegQ== X-Gm-Message-State: AODbwcBj7fgtXlbUQs7eV2rQ4xcUoHW5Vqp3C/FXjRzlZLHhz34SdD/E ywJuiCQzR8Hiofo2ooq2UA== X-Received: by 10.28.23.131 with SMTP id 125mr924190wmx.42.1496360952009; Thu, 01 Jun 2017 16:49:12 -0700 (PDT) Received: from [192.168.8.100] ([80.215.140.117]) by smtp.gmail.com with ESMTPSA id p65sm18007133wrb.64.2017.06.01.16.49.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jun 2017 16:49:11 -0700 (PDT) From: Vincent Jardin To: "Wang, Yipeng1" CC: , "Gobriel, Sameh" , "Wang, Ren" , "Tai, Charlie" Date: Fri, 02 Jun 2017 01:48:55 +0200 Message-ID: <15c660fde58.27fc.bb328046f2889bc8f44aafa891a44dd2@6wind.com> In-Reply-To: References: <1495848888-54621-1-git-send-email-yipeng1.wang@intel.com> <15c49491fa0.27fc.bb328046f2889bc8f44aafa891a44dd2@6wind.com> User-Agent: AquaMail/1.10.0-403 (build: 101000001) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] Add Membership Library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 23:49:12 -0000 Le 1 juin 2017 03:03:39 "Wang, Yipeng1" a écrit : > Hi Vincent, > > Thanks for the comments and some quick responses below: > > - DPDK Bloom Filter is derived from the libbloom (as shown by the included > BSD license), but optimized for performance with various DPDK goodness such > as rte_zmalloc, rte_bitmap, rte_jhash, etc. It doesn't seem appropriate to > bring those DPDK specific features into libbloom, which is designed for > more generic environments. Did you try and ask to the original author? > - DPDK Bloom Filter is just one very basic mode among other more > sophisticated ones in the DPDK Membership Library, which supports a > different set of APIs (e.g., bulk lookup, multi-match, etc.) than those > supported in libbloom. How does it justify forking the code? > - It may make sense to bring some generic (i.e., non DPDK specific) > improvements back to libbloom once identified. So let's start first with contributions to libbloom, please. > > Thanks > Yipeng > >> -----Original Message----- >> From: Vincent Jardin [mailto:vincent.jardin@6wind.com] >> Sent: Saturday, May 27, 2017 2:42 AM >> To: Wang, Yipeng1 >> Cc: dev@dpdk.org; Gobriel, Sameh ; Wang, Ren >> ; Tai, Charlie >> Subject: Re: [dpdk-dev] [RFC] Add Membership Library >> >> Why duplicating Jyri's libbloom - https://github.com/jvirkki/libbloom - for >> this >> DPDK capability? Why not showing that you can contribute to libbloom and >> make it linkable with the DPDK? >> >> There are so many duplicated code... >> >> Thank you, >> Vincent >> >