From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D1ADA0C43; Tue, 16 Nov 2021 10:32:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 243B74115F; Tue, 16 Nov 2021 10:32:45 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6FD5B41149 for ; Tue, 16 Nov 2021 10:32:43 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="294474140" X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208";a="294474140" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 01:32:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208";a="454187113" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 16 Nov 2021 01:32:22 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 16 Nov 2021 01:32:22 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 16 Nov 2021 01:32:22 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 16 Nov 2021 01:32:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZdoJF2oiqUCfu2lxoqSZfh0jC1PTPMnEXVCoyEyXzOGod3IiV92m+BX0zIX2W56vZWaYTuzCzAiXyGfcRmp+x+aoMUo7kjtHpUuAaf6Otq6HC8CDAN3SGwTuySoLkrOZSNlcXiav5L+JA9CEHADmyDu1BTQgMn/JTNHsCYqmmAgzfTEaOnb6f/uhcVE6QT2IGFw2Ld9v+EsykDl7O8hjYCdQQ5z7Ya4FdR/hAueo/sdYQAFnxgwnkEhAjFI0gR5R76+/YaxfFDXrp0KXGaWNVoacP3B4tk9qGEfwdf1EbxcZQq4NIGS6kZSY1iO6c2lR87IATKhwZj+b+lBzSLtEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/c0SVqMVMtV7lvjBzwfnvTQcgsEsBQZFsJA0xAuECk=; b=kW8WgzwbEbTVhvmNqe5NbdXTNuviOccQZSksKBOIdtgCnjhPbs9ijTCmzfV7IAt8i3aTzs4EEIJQSjhmtCW4r25hN7CnbrXyzXdJuXI5EUKEupGMGb9R9fz0z0D+/0LnCrObSzeS9oZUHY1qazbjJ5dVKY770yCZO++X+2uMUuG4ZHzphsdnCoHk6Exd9YaI2I57DTS/cmPmSdK8FCUdcaAs7CdWXCc2DZpCyNsNnnXFrwOLuecbUp5+cOCbaOIeCsa24agR4M0kNKz0K+rrDLOJ7Gg/yoa5MWZgAS/soE6SeQK3b16PEyf9+ygU7nkrDiJcuGxgt4eEthi4/MQESQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/c0SVqMVMtV7lvjBzwfnvTQcgsEsBQZFsJA0xAuECk=; b=bHtzAskCCwFxTVJ7zKDeDUvKnG0puC2pxh8y81kQkZ88MTB71S7TzTTI8bmpcKjaRNcvGaxC2VmidGUeTUv8H7pFTh0YW8rGCzf/ZELbu1tnE6ROojrkI0MWugNsDx4Sif0EiW6vuqa6TeQF9UWcf+VSRRZ14XWi7RSA8Qsq3lc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Tue, 16 Nov 2021 09:32:21 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 09:32:21 +0000 Message-ID: <15f9b491-6c36-dc85-6348-d746196d4374@intel.com> Date: Tue, 16 Nov 2021 09:32:15 +0000 Content-Language: en-US To: Tyler Retzlaff References: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: Ferruh Yigit CC: Konstantin Ananyev , Subject: Re: ethdev: hide internal structures X-User: ferruhy In-Reply-To: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0100.eurprd07.prod.outlook.com (2603:10a6:6:2c::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0100.eurprd07.prod.outlook.com (2603:10a6:6:2c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.16 via Frontend Transport; Tue, 16 Nov 2021 09:32:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 917a94d3-bb95-44ca-a740-08d9a8e3fd55 X-MS-TrafficTypeDiagnostic: PH0PR11MB5832: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UIAx/4IcDMLKmDrnJq24GVcn1MP911F7hu7AE6Q/nSo9PpiEv4U5omR9N/lnk6/Y5by+9n9b5cGb94sGMKBA8+MfdgbHO01aAhY74joxvj9JQt7QQV3HfDmhsaAeYJZMcXBQTHJstUeubtKSM5fBtLLT6JTYQVEcbgncorw/Kfn9MU8r285vJNxCWTgiGgPQflBz/QLduQ/r20RQUyK3go0MQ2pP7VNkCTxsvDfH3uSzt7ErbYTuAaJTA0Zsg2rfmNN6XUam6bd4wkuOzGcIjtmlRUcCkQGpRDQTtiDQjFDYdc2AKJ5GuwUAVBUkKgd9ATQ5eVqPizbRTk88mbkAvEkoa7wgTsvH1fpM9F+yM0C+T+yoM/s2HnhVuGBoaf1tsSuGFyutMryuxJSfLPTqP7uJO8v1u+Uk9nGA3YgcUrR9DGkF/AuLFnkPV7cpRIE1YGO5wFB+O5/KASsMDeVwhb6AaFYSbvt3ofyiADldXTpPhFmZuz5IIe9ItIalag4PWx4hqTCA8RXoqyhAK1DTR/qcd/UDfLg5yQFtKuRY1+6+Ms5PCKQ+s4vfES/faZ1wYzhFPFw7aUwJgPQ8Cbd/slBcqRCXGC4CLgkoFMZB8ucwdrA2bUqTgXIjWTzgbYrQiyVpVV2wBpwlQbEALY7IgpSJxI87vK/vdW4e1lrP+J92a8ObXlEcRnL/93hDthybQSQVBkGw+KdSbcQsb1pDlg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(6486002)(26005)(2906002)(83380400001)(8936002)(6666004)(53546011)(86362001)(66476007)(66556008)(31686004)(82960400001)(44832011)(16576012)(508600001)(31696002)(6916009)(956004)(5660300002)(38100700002)(2616005)(8676002)(186003)(316002)(4326008)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVcrTjZHMkVRaHdSeFRhc0R5WWhQMGRHN1ViSzRjMXB6UFlYOGd4L2JCVlhC?= =?utf-8?B?WnlSQ3RxdE1NaStWUW1jZVNja0Z0MmlQbVpBUHpwenpoQUJGL3NNc0t0TGZx?= =?utf-8?B?Y3hiNkNOT05JYXB3Tzg1Tk82Qm1qVXdxT1luVjMwVDVkaVAxNmsxQWMxUStv?= =?utf-8?B?VUYxK2pmcVJRdnhiQ1lFTm5iS1ZvalViMlowYjExUGlYUHdCTU1HRXJISzJm?= =?utf-8?B?QTN4OEVYdkhCRnpoS2pJV2dJRmhsZXZSWHdyTTNNamZWN3QyWDg0Tlo5cWh3?= =?utf-8?B?SXdVVnV1UjFGS2ZTUHRlamNsS3ZGRmU5M3pFVVR0WUJNNlFkMEovZmFISzlJ?= =?utf-8?B?M25WSXNSRG9ON0kwc2svVmpzQkpldlFxUEl3eVhpNFF6L1ROdVZ4TzZtK0gx?= =?utf-8?B?aTFsb3FUNjk4UCtDTXlZSGNmV3ZFUGRMNGNsRUlyc2VEdmlqMlg3TjM2ckxK?= =?utf-8?B?SFV0UFRpbGgxR1RYb3djSnZkcE9uaFR4WlFzUXdkQWxHdjZVL2JmTEpmcm5r?= =?utf-8?B?Q2NZNFAxOHFVQ2VObk1pNE5xTjd6eFZ3MnBLMHZvcDdzWFNhbGZyU2NHT0x1?= =?utf-8?B?dnl1R0toOEdYVzh5a3A3VVJDYWtEYm1SZVpMVURXeWhHaTlHUkZCSkdlazF2?= =?utf-8?B?ZlplRTROUjRSdy9tNTJEV3pTRW9IMDVpNitqNVB6YW9aTWYyMUJhTTFUMWFY?= =?utf-8?B?UmM0eHkzbUdiZDhZUGFYcWxHMFFnR3hidlVpcjRBL3RUMENwbnZVT3BEeUJO?= =?utf-8?B?RG1DRFJ5Y3plSTdqNHpVTy9pWUxCWDFqV3J0YW1LWVhiTjZVOE1HeEp3R2lU?= =?utf-8?B?MTN4NHMyOEFGUHFBQ1dJd2J5dmhXbFgyNUtCbWpvRGE2Z0lJTWxqNlhIVVly?= =?utf-8?B?YThseHZHSkE0Nk54b1NadDVlMXc2cmdCdWFsdC9EeE5XNFJYUGNIdFRtUXFz?= =?utf-8?B?aDN0Rk9QYXFETEE4SjlPNEFmdDA0TzQ5OHU5Sm9Ia0RtMDFJMWx2U3plallp?= =?utf-8?B?dFV0VFcyQmJpazJmNzZjeDJ0R3A0TWNzZUdNd1NOWlc5ZFUvU1kycVpENlA1?= =?utf-8?B?ODhLMDJTZTJyOS94NjFoK3FCSndRdS9Ua1RQcStETlU4YzlwZE1OaUsxblYr?= =?utf-8?B?U3FnTGoydUtra2JSNUllTWk0SUpWTVlJdlFxRm5STitoVFlsOHVmbDFZZlpw?= =?utf-8?B?c1hSbWc4M0tqVWJZMVRWTHNkM0UrNWh5Mzd5Z0lzQlU1eDBDZ3hiVFI3aHhE?= =?utf-8?B?dmxsWG5sc1hjdlU2QmFJaWJvZWR6RkFsYzdMYVp0UXk4TGRZT0RhMHFNQm01?= =?utf-8?B?cEw0ZlFhMmh0eTFwcUV3YjlLdTZwZHBJM2dqMnRZLy9WM3NBN2ZlZXd4SHdv?= =?utf-8?B?VW95RHJZbmtLRnJZTm0rT3RMajZQOFhINWZJcGJ1Y21WMzQxTW90dkpDNngr?= =?utf-8?B?bHdNcklXdXZPUUJXY0M5cHhYRnVKK1hoNEVTL1BYdFJaWkhMYmU3M1BuVzRG?= =?utf-8?B?Zzk4OGNCU0YrRFF0T2Q5RU40L2IrUm9oUFhZemdqZ2pPMVRtZHpWOXEzbWV4?= =?utf-8?B?MVprR3hIZW1rdnl6eDNodG8zOWVLamNhOHh2VWF1blBJUGVTNkJIaUxXRXBO?= =?utf-8?B?ZFRjSG1jTjh6b2VpYUxCeTU4amlvYmIwb2RxVk44WEt6Z2lyVDREcmplS1Na?= =?utf-8?B?NWtIMTZ1MktzRkNPbWtXcnVoOFhzZWtqYU1qOWlrTkZ0ZzRrZ3V1Q1dxZm5B?= =?utf-8?B?U3VIRzJQR09zLzgzQmVxNndYbmVnZkw4TEhCci9FVkFna29DbXB4dTE0M3Vy?= =?utf-8?B?SUYxbVV0Yi82NC8wNUFVS2RMUWc2Z244NzNPQk1XRXF6OTNSVFU0WFdMbmYy?= =?utf-8?B?UGw1SnJPdFkwbEtuZkdoNGZ4aFB3eEJEUm5Eby9ZV3dQeWg3L09UUGpSSDM5?= =?utf-8?B?bUErcFpnMkN2NTJMYktReUo3Njl1ZXdxMU1nb0dTSG1Hak92RmI1ZWM4YlJU?= =?utf-8?B?OHBlcE9mbm03bkNQajRqNFhaaGREV3VDSE9LWkkxMENZS05KeXJiWGpteEN4?= =?utf-8?B?L1NmY09mVTFiUXZWaDlZOHVBaCtiRGdOQ2VVdnJJVjQxWFNQV20rSjQwb1lD?= =?utf-8?B?blFraHlPN1BydDNXNkd0SXdoVzF3WmlpRXMxcmFBUVdTNWdaWGFwSEdNL1p6?= =?utf-8?Q?2OkUv78S4HLgcB3g+86Was0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 917a94d3-bb95-44ca-a740-08d9a8e3fd55 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 09:32:21.3326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5t/CZx5zJhFSTDzFuvH6WEmUxFgWOr+1j00a4viib8eUpcj6aOnzWsD6yxOLA7MqFBj74XPMEdAmwPx4aiFooQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5832 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/16/2021 12:24 AM, Tyler Retzlaff wrote: > hi folks, > > I don't understand the text of this change. would you mind explaining? > > commit f9bdee267ab84fd12dc288419aba341310b6ae08 > Author: Konstantin Ananyev > Date: Wed Oct 13 14:37:04 2021 +0100 > ethdev: hide internal structures > > +* ethdev: Made ``rte_eth_dev``, ``rte_eth_dev_data``, ``rte_eth_rxtx_callback`` > + private data structures. ``rte_eth_devices[]`` can't be accessed directly > + by user any more. While it is an ABI breakage, this change is intended > + to be transparent for both users (no changes in user app is required) and> + PMD developers (no changes in PMD is required). > > > if it is an ABI break (and it is also an API break) how is it that > this change could be "transparent" to the user application? > > * existing binaries will not run. (they need to be recompiled) > * existing code will not compile. (code changes are required) > > in order to cope with this change an application will have to have the > code modified and will need to be re-compiled. so i don't understand how > that is transparent? > Hi Tyler, It shouldn't be an API change, which API is changed? Existing binaries won't run and needs recompile, but shouldn't need to change the code. Unless application is accessing *internal* DPDK structs (which were exposed to application because of some technical issues that above commit fixes). What code change do you require, in driver or application?