From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2679CA0350; Thu, 7 May 2020 16:31:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4671A1DC9D; Thu, 7 May 2020 16:31:29 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7CFDD1DBE9 for ; Thu, 7 May 2020 16:31:26 +0200 (CEST) IronPort-SDR: hD9oMtltVoQM84YXo3PYqt9h2cTOF1GS/vo7JLZaf6M2r/9iXSrLYUFXw0NSH1oyj6kxAKTxEa OKCJVLJ0OtTQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 07:31:13 -0700 IronPort-SDR: 9CKZeZR8Yl8GzxzMNMiD6HHjQNsyT5Wc5ve6lTkINUYW5Cc1mXonoeAM6Ivsx0P+l081vMGzlf xiV+2ZXc26DA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,364,1583222400"; d="scan'208";a="462160793" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.197.159]) ([10.213.197.159]) by fmsmga006.fm.intel.com with ESMTP; 07 May 2020 07:31:12 -0700 To: Hemant Agrawal , dev@dpdk.org Cc: Nipun Gupta References: <20200504124118.22877-1-hemant.agrawal@nxp.com> <20200507104645.31990-1-hemant.agrawal@nxp.com> <20200507104645.31990-6-hemant.agrawal@nxp.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <15f9ca53-9c9b-4d9e-136b-95517d090da5@intel.com> Date: Thu, 7 May 2020 15:31:11 +0100 MIME-Version: 1.0 In-Reply-To: <20200507104645.31990-6-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 5/9] drivers: dpaa2 enhance portal alloc failure log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/7/2020 11:46 AM, Hemant Agrawal wrote: > From: Nipun Gupta > > The change adds printing the thread id when portal allocation > failure occurs Not just adds the tid, also changes the log itself. > > Signed-off-by: Nipun Gupta > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 ++++++-- > drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++++-- > drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 +++++++++--- > drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++- > drivers/net/dpaa2/dpaa2_rxtx.c | 16 ++++++++++++---- > drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 8 ++++++-- > drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 12 +++++++++--- > 7 files changed, 51 insertions(+), 17 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 0919f3bf47..256a9a1955 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -1459,7 +1459,9 @@ dpaa2_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops, > if (!DPAA2_PER_LCORE_DPIO) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_SEC_ERR("Failure in affining portal"); > + DPAA2_SEC_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -1641,7 +1643,9 @@ dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops, > if (!DPAA2_PER_LCORE_DPIO) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_SEC_ERR("Failure in affining portal"); > + DPAA2_SEC_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c > index 2be6e12f66..a196ad4c64 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -74,7 +74,9 @@ dpaa2_eventdev_enqueue_burst(void *port, const struct rte_event ev[], > /* Affine current thread context to a qman portal */ > ret = dpaa2_affine_qbman_swp(); > if (ret < 0) { > - DPAA2_EVENTDEV_ERR("Failure in affining portal"); > + DPAA2_EVENTDEV_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -273,7 +275,9 @@ dpaa2_eventdev_dequeue_burst(void *port, struct rte_event ev[], > /* Affine current thread context to a qman portal */ > ret = dpaa2_affine_qbman_swp(); > if (ret < 0) { > - DPAA2_EVENTDEV_ERR("Failure in affining portal"); > + DPAA2_EVENTDEV_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c > index 48887beb7e..fa9b53e64d 100644 > --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c > +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c > @@ -69,7 +69,9 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp) > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_MEMPOOL_ERR("Failure in affining portal"); > + DPAA2_MEMPOOL_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > goto err1; > } > } > @@ -198,7 +200,9 @@ rte_dpaa2_mbuf_release(struct rte_mempool *pool __rte_unused, > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret != 0) { > - DPAA2_MEMPOOL_ERR("Failed to allocate IO portal"); > + DPAA2_MEMPOOL_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return; > } > } > @@ -317,7 +321,9 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool, > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret != 0) { > - DPAA2_MEMPOOL_ERR("Failed to allocate IO portal"); > + DPAA2_MEMPOOL_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return ret; > } > } > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > index b70a2ac01c..817e9e0316 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -903,7 +903,9 @@ dpaa2_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id) > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_PMD_ERR("Failure in affining portal"); > + DPAA2_PMD_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return -EINVAL; > } > } > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c > index 89a8221cb8..630f8c73c7 100644 > --- a/drivers/net/dpaa2/dpaa2_rxtx.c > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c > @@ -762,7 +762,9 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_PMD_ERR("Failure in affining portal\n"); > + DPAA2_PMD_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -882,7 +884,9 @@ uint16_t dpaa2_dev_tx_conf(void *queue) > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_PMD_ERR("Failure in affining portal\n"); > + DPAA2_PMD_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -1021,7 +1025,9 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_PMD_ERR("Failure in affining portal"); > + DPAA2_PMD_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -1282,7 +1288,9 @@ dpaa2_dev_tx_ordered(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_PMD_ERR("Failure in affining portal"); > + DPAA2_PMD_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > index 997d1c8739..7c21c6a528 100644 > --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > +++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > @@ -70,7 +70,9 @@ dpaa2_cmdif_enqueue_bufs(struct rte_rawdev *dev, > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_CMDIF_ERR("Failure in affining portal\n"); > + DPAA2_CMDIF_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -133,7 +135,9 @@ dpaa2_cmdif_dequeue_bufs(struct rte_rawdev *dev, > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_CMDIF_ERR("Failure in affining portal\n"); > + DPAA2_CMDIF_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > index c905954004..d5202d6522 100644 > --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > @@ -666,7 +666,9 @@ dpdmai_dev_enqueue_multi(struct dpaa2_dpdmai_dev *dpdmai_dev, > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_QDMA_ERR("Failure in affining portal"); > + DPAA2_QDMA_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -788,7 +790,9 @@ dpdmai_dev_dequeue_multijob_prefetch( > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_QDMA_ERR("Failure in affining portal"); > + DPAA2_QDMA_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } > @@ -929,7 +933,9 @@ dpdmai_dev_dequeue_multijob_no_prefetch( > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > ret = dpaa2_affine_qbman_swp(); > if (ret) { > - DPAA2_QDMA_ERR("Failure in affining portal"); > + DPAA2_QDMA_ERR( > + "Failed to allocate IO portal, tid: %d\n", > + rte_gettid()); > return 0; > } > } >