* [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check
@ 2020-09-13 19:33 Viacheslav Ovsiienko
2020-09-17 11:20 ` Matan Azrad
2020-09-23 7:37 ` Raslan Darawsheh
0 siblings, 2 replies; 3+ messages in thread
From: Viacheslav Ovsiienko @ 2020-09-13 19:33 UTC (permalink / raw)
To: dev; +Cc: rasland
The Rx queue start/stop feature is not supported if vectorized
rx_burst routine is engaged. There was a routine address typo
and rx_burst type check was wrong.
Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0b3e813..1aee6d1 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -562,7 +562,7 @@
* The routine pointer depends on the process
* type, should perform check there.
*/
- if (pkt_burst == mlx5_rx_burst) {
+ if (pkt_burst == mlx5_rx_burst_vec) {
DRV_LOG(ERR, "Rx queue stop is not supported "
"for vectorized Rx");
rte_errno = EINVAL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check
2020-09-13 19:33 [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check Viacheslav Ovsiienko
@ 2020-09-17 11:20 ` Matan Azrad
2020-09-23 7:37 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Matan Azrad @ 2020-09-17 11:20 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Raslan Darawsheh
From: Viacheslav Ovsiienko
> The Rx queue start/stop feature is not supported if vectorized rx_burst
> routine is engaged. There was a routine address typo and rx_burst type
> check was wrong.
>
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check
2020-09-13 19:33 [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check Viacheslav Ovsiienko
2020-09-17 11:20 ` Matan Azrad
@ 2020-09-23 7:37 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-09-23 7:37 UTC (permalink / raw)
To: Slava Ovsiienko, dev
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Sunday, September 13, 2020 10:34 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH] net/mlx5: fix vectorized Rx burst check
>
> The Rx queue start/stop feature is not supported if vectorized
> rx_burst routine is engaged. There was a routine address typo
> and rx_burst type check was wrong.
>
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 0b3e813..1aee6d1 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -562,7 +562,7 @@
> * The routine pointer depends on the process
> * type, should perform check there.
> */
> - if (pkt_burst == mlx5_rx_burst) {
> + if (pkt_burst == mlx5_rx_burst_vec) {
> DRV_LOG(ERR, "Rx queue stop is not supported "
> "for vectorized Rx");
> rte_errno = EINVAL;
> --
> 1.8.3.1
Patch applied to next-net-mxl,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-23 7:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-13 19:33 [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check Viacheslav Ovsiienko
2020-09-17 11:20 ` Matan Azrad
2020-09-23 7:37 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).