From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Fiona Trahe <fiona.trahe@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to support future extensions
Date: Tue, 08 Mar 2016 15:10:32 +0100 [thread overview]
Message-ID: <1600295.xLGLO1O6Fu@xps13> (raw)
In-Reply-To: <1457351422-7617-2-git-send-email-fiona.trahe@intel.com>
Hi,
2016-03-07 11:50, Fiona Trahe:
> This patch splits symmetric specific definitions and
> functions away from the common crypto APIs to facilitate the future extension
> and expansion of the cryptodev framework, in order to allow asymmetric
> crypto operations to be introduced at a later date, as well as to clean the
> logical structure of the public includes. The patch also introduces the _sym
> prefix to symmetric specific structure and functions to improve clarity in
> the API.
It seems you need to update the examples in the same patch, they do not compile
anymore after these changes.
Again, it would be easier to review if you had split the changes to several
patches: one for the sym suffix, others for more tidying.
next prev parent reply other threads:[~2016-03-08 14:12 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 13:07 [dpdk-dev] [PATCH] cryptodev: API change to rte_crypto_op bursts Declan Doherty
2016-02-08 17:50 ` Trahe, Fiona
2016-02-19 11:01 ` [dpdk-dev] [PATCH v2 0/2] cryptodev API changes Declan Doherty
2016-02-19 11:01 ` [dpdk-dev] [PATCH v2 1/2] cryptodev: API tidy and changes to support future extensions Declan Doherty
2016-02-19 11:01 ` [dpdk-dev] [PATCH v2 2/2] cryptodev: change burst API to be crypto op oriented Declan Doherty
2016-02-22 11:17 ` Trahe, Fiona
2016-02-22 18:23 ` Trahe, Fiona
2016-02-22 18:56 ` Trahe, Fiona
2016-02-26 17:30 ` [dpdk-dev] [PATCH v3 0/2] cryptodev API changes Declan Doherty
2016-02-26 17:30 ` [dpdk-dev] [PATCH v3 1/2] cryptodev: API tidy and changes to support future extensions Declan Doherty
2016-02-26 17:30 ` [dpdk-dev] [PATCH v3 2/2] cryptodev: change burst API to be crypto op oriented Declan Doherty
2016-02-29 16:00 ` [dpdk-dev] [PATCH v3 0/2] cryptodev API changes Declan Doherty
2016-02-29 16:52 ` [dpdk-dev] [PATCH v4 " Declan Doherty
2016-02-29 16:52 ` [dpdk-dev] [PATCH v4 1/2] cryptodev: API tidy and changes to support future extensions Declan Doherty
2016-03-04 14:43 ` Thomas Monjalon
2016-02-29 16:52 ` [dpdk-dev] [PATCH v4 2/2] cryptodev: change burst API to be crypto op oriented Declan Doherty
2016-02-29 17:47 ` [dpdk-dev] [PATCH v4 0/2] cryptodev API changes Trahe, Fiona
2016-03-04 17:17 ` [dpdk-dev] [PATCH v5 " Fiona Trahe
2016-03-04 17:38 ` Thomas Monjalon
2016-03-04 17:43 ` Trahe, Fiona
2016-03-04 17:45 ` Thomas Monjalon
2016-03-04 18:01 ` Trahe, Fiona
2016-03-04 17:39 ` Trahe, Fiona
2016-03-15 6:48 ` Cao, Min
2016-03-04 17:17 ` [dpdk-dev] [PATCH v5 1/2] This patch splits symmetric specific definitions and functions away from the common crypto APIs to facilitate the future extension and expansion of the cryptodev framework, in order to allow asymmetric crypto operations to be introduced at a later date, as well as to clean the logical structure of the public includes. The patch also introduces the _sym prefix to symmetric specific structure and functions to improve clarity in the API Fiona Trahe
2016-03-04 17:17 ` [dpdk-dev] [PATCH v5 2/2] This patch modifies the crypto burst enqueue/dequeue APIs to operate on bursts rte_crypto_op's rather than the current implementation which operates on rte_mbuf bursts, this simplifies the burst processing in the crypto PMDs and the use of crypto operations in general Fiona Trahe
2016-03-04 18:29 ` [dpdk-dev] [PATCH v6 0/2] cryptodev API changes Fiona Trahe
2016-03-07 11:50 ` [dpdk-dev] [PATCH v7 " Fiona Trahe
2016-03-07 13:23 ` De Lara Guarch, Pablo
2016-03-07 13:53 ` Jain, Deepak K
2016-03-10 13:42 ` [dpdk-dev] [PATCH v8 0/5] " Fiona Trahe
2016-03-10 14:05 ` De Lara Guarch, Pablo
2016-03-10 15:41 ` [dpdk-dev] [PATCH v9 " Fiona Trahe
2016-03-10 16:14 ` Thomas Monjalon
2016-03-10 15:41 ` [dpdk-dev] [PATCH v9 1/5] cryptodev: code cleanup Fiona Trahe
2016-03-10 15:41 ` [dpdk-dev] [PATCH v9 2/5] cryptodev: refactor to partition common from symmetric-specific code Fiona Trahe
2016-03-10 15:41 ` [dpdk-dev] [PATCH v9 3/5] cryptodev: remove unused phys_addr field from key Fiona Trahe
2016-03-10 15:41 ` [dpdk-dev] [PATCH v9 4/5] cryptodev: change burst API to be crypto op oriented Fiona Trahe
2016-03-10 16:03 ` Thomas Monjalon
2016-03-10 16:13 ` Trahe, Fiona
2016-03-10 15:41 ` [dpdk-dev] [PATCH v9 5/5] mbuf_offload: remove library Fiona Trahe
2016-03-14 8:59 ` [dpdk-dev] [PATCH v8 0/5] cryptodev API changes Cao, Min
2016-03-10 13:42 ` [dpdk-dev] [PATCH v8 1/5] cryptodev: code cleanup Fiona Trahe
2016-03-10 13:42 ` [dpdk-dev] [PATCH v8 2/5] cryptodev: refactor to partition common from symmetric-specific code Fiona Trahe
2016-03-10 13:42 ` [dpdk-dev] [PATCH v8 3/5] cryptodev: remove unused phys_addr field from key Fiona Trahe
2016-03-10 13:43 ` [dpdk-dev] [PATCH v8 4/5] cryptodev: change burst API to be crypto op oriented Fiona Trahe
2016-03-10 14:03 ` Thomas Monjalon
2016-03-10 13:43 ` [dpdk-dev] [PATCH v8 5/5] mbuf_offload: remove library Fiona Trahe
2016-03-15 5:21 ` [dpdk-dev] [PATCH v7 0/2] cryptodev API changes Cao, Min
2016-03-07 11:50 ` [dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to support future extensions Fiona Trahe
2016-03-08 14:10 ` Thomas Monjalon [this message]
2016-03-10 10:30 ` Trahe, Fiona
2016-03-07 11:50 ` [dpdk-dev] [PATCH v7 2/2] cryptodev: change burst API to be crypto op oriented Fiona Trahe
2016-03-08 14:32 ` Thomas Monjalon
2016-03-09 12:55 ` Trahe, Fiona
2016-03-10 10:28 ` Trahe, Fiona
2016-03-15 6:46 ` [dpdk-dev] [PATCH v6 0/2] cryptodev API changes Cao, Min
2016-03-04 18:29 ` [dpdk-dev] [PATCH v6 1/2] cryptodev: API tidy and changes to support future extensions Fiona Trahe
2016-03-04 18:29 ` [dpdk-dev] [PATCH v6 2/2] cryptodev: change burst API to be crypto op oriented Fiona Trahe
2016-03-15 6:57 ` [dpdk-dev] [PATCH v4 0/2] cryptodev API changes Cao, Min
2016-03-15 7:07 ` [dpdk-dev] [PATCH v3 " Cao, Min
2016-03-15 7:48 ` [dpdk-dev] [PATCH v2 " Cao, Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600295.xLGLO1O6Fu@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).