From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 0EC772C59 for ; Tue, 8 Mar 2016 15:12:11 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id n186so133497249wmn.1 for ; Tue, 08 Mar 2016 06:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=AIr806xY55TewkynzxQoCgXyvfXsY4SvVuUne2ryptc=; b=cT2RifdlgCrmE5tMcRkj+St4WCrHjmAIeSIPSvxlZMQOilK+H4IJvDfh0a5Ft62/ap bVIZpvj00Y8fHA7ggWFykesclFRpM+GaDyGqFJuP6DBQi4iEAduxv2/pfPkP+ie4TYcE oudGWJzcnOZ5yW77WfpkTFHx8aYCsQ8IkQubxsN0X8ZUY5VOKHj+EmSj2WMHVCTutZMt AOIJEJVKE1Ob10rzVW2x2qn9gFrm8w0iG/5kWSidMytHz0P9zYyMRCY9P5yxaVy2wOx0 DHPsz7G2RoKjua9UmjtrZlx7HPBVp1WGIToR5RcbtAdEQKw+6wNFGdE7ZgePPyZdjtxs 46cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=AIr806xY55TewkynzxQoCgXyvfXsY4SvVuUne2ryptc=; b=WbUY/JSKqm/ViG0fgGPh4fA0CccETVRjUWQh1YhhL5wP1j6Fk6DUzk7V6tLTbeYknl gQsMpH1HWbypniqZ6ael9biQd1210NeONuCXc+S3mUf+VuuoQMtePDokKBUE5LwfmLI5 3s1JPglv5e+za7Y8p9V4NWKRci3+1k6dyW1zQ7j/Z3/0lyC0H+Tvh8ZhrXcN75GbAjh9 NbPln5aNGjDE07Ksx6CeUJwDu6yC//BHryAAFGH8+ad0ZT76/7BFAxOmJkodH6GFjKg8 CXtait09ZXruTeKj4Z//iIli1yUJSneGw3qdj49cyt0Hvbks2lRafxjImSCOlcexVrhR SYqA== X-Gm-Message-State: AD7BkJIqgyzjyqZScsYOeuFipiPZ961Rdf1UQVfoRTJtztkJsZGwVyOWJHUdA1b68tKCVL3T X-Received: by 10.194.191.199 with SMTP id ha7mr29248503wjc.128.1457446330868; Tue, 08 Mar 2016 06:12:10 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id q139sm3642096wmd.2.2016.03.08.06.12.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2016 06:12:10 -0800 (PST) From: Thomas Monjalon To: Fiona Trahe Date: Tue, 08 Mar 2016 15:10:32 +0100 Message-ID: <1600295.xLGLO1O6Fu@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457351422-7617-2-git-send-email-fiona.trahe@intel.com> References: <1457116189-10226-1-git-send-email-fiona.trahe@intel.com> <1457351422-7617-2-git-send-email-fiona.trahe@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to support future extensions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 14:12:11 -0000 Hi, 2016-03-07 11:50, Fiona Trahe: > This patch splits symmetric specific definitions and > functions away from the common crypto APIs to facilitate the future extension > and expansion of the cryptodev framework, in order to allow asymmetric > crypto operations to be introduced at a later date, as well as to clean the > logical structure of the public includes. The patch also introduces the _sym > prefix to symmetric specific structure and functions to improve clarity in > the API. It seems you need to update the examples in the same patch, they do not compile anymore after these changes. Again, it would be easier to review if you had split the changes to several patches: one for the sym suffix, others for more tidying.