From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B946A04B6; Thu, 17 Sep 2020 08:38:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6539E1D5D2; Thu, 17 Sep 2020 08:35:52 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 9D2131D519 for ; Thu, 17 Sep 2020 08:35:30 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.60]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 208346005E for ; Thu, 17 Sep 2020 06:35:30 +0000 (UTC) Received: from us4-mdac16-35.ut7.mdlocal (unknown [10.7.66.154]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2006A2009A for ; Thu, 17 Sep 2020 06:35:30 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.30]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 2F4A01C0052 for ; Thu, 17 Sep 2020 06:35:24 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id DABA610005E for ; Thu, 17 Sep 2020 06:35:23 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Sep 2020 07:35:12 +0100 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 17 Sep 2020 07:35:12 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08H6ZCwX002515 for ; Thu, 17 Sep 2020 07:35:12 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 9D8791613AB for ; Thu, 17 Sep 2020 07:35:12 +0100 (BST) From: Andrew Rybchenko To: Date: Thu, 17 Sep 2020 07:34:41 +0100 Message-ID: <1600324483-23153-16-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1600324483-23153-1-git-send-email-arybchenko@solarflare.com> References: <1599556475-27820-1-git-send-email-arybchenko@solarflare.com> <1600324483-23153-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25670.003 X-TM-AS-Result: No-4.214500-8.000000-10 X-TMASE-MatchedRID: eciAImCBKNA5s4xK97Sm/x23b+lJHvPAAp+UH372RZXjIxFSDv7HToWi qUsiuZWpnb6Z+uUpsD0Wsp6eJb7A26H2g9syPs88nFVnNmvv47tLXPA26IG0hNVTZaI6TuNoD2V MA3hbGfGBoPqFiWWY1ue40v4bMUWP++XBDev6r0wkOFAoKA9tAti5W7Rf+s6QnyW4d6TKNpCjxY yRBa/qJcFwgTvxipFajoczmuoPCq19MVeTat8blRfgvD9PwrWadJRZ1VPYUgjVyC1amZPFktCaL pDHUriZoBW7lRysbr+9VEqXstCDWlah0ebfizTiH70wGipsuds3I8DUyOoaeU+wJNKvG6HQ1PNk ozhRY3HUNR3AhwxI7LAXtf+fj2qblExlQIQeRG0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.214500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25670.003 X-MDID: 1600324524-hocAXOJuFA5t Subject: [dpdk-dev] [PATCH v2 15/17] net/sfc: add MCDI callback to poll management event queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Management event queue polling is required in the case of MCDI proxy authentication (client driver code). Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mcdi.c | 14 ++++++++++++-- drivers/net/sfc/sfc_mcdi.h | 3 +++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc/sfc_mcdi.c index 73dbd8194b..fa9160f6d3 100644 --- a/drivers/net/sfc/sfc_mcdi.c +++ b/drivers/net/sfc/sfc_mcdi.c @@ -70,7 +70,7 @@ sfc_efx_mcdi_proxy_event_available(struct sfc_adapter *sa) mcdi->proxy_handle = 0; mcdi->proxy_result = ETIMEDOUT; - sfc_ev_mgmt_qpoll(sa); + mcdi->ops->mgmt_evq_poll(mcdi->ops_cookie); if (mcdi->proxy_result != ETIMEDOUT) return B_TRUE; @@ -286,7 +286,7 @@ sfc_efx_mcdi_init(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi, int rc; if (ops->dma_alloc == NULL || ops->dma_free == NULL || - ops->sched_restart == NULL) + ops->sched_restart == NULL || ops->mgmt_evq_poll == NULL) return EINVAL; SFC_ASSERT(mcdi->state == SFC_EFX_MCDI_UNINITIALIZED); @@ -382,10 +382,20 @@ sfc_mcdi_sched_restart(void *cookie) sfc_schedule_restart(sa); } +static sfc_efx_mcdi_mgmt_evq_poll_cb sfc_mcdi_mgmt_evq_poll; +static void +sfc_mcdi_mgmt_evq_poll(void *cookie) +{ + struct sfc_adapter *sa = cookie; + + sfc_ev_mgmt_qpoll(sa); +} + static const struct sfc_efx_mcdi_ops sfc_mcdi_ops = { .dma_alloc = sfc_mcdi_dma_alloc, .dma_free = sfc_mcdi_dma_free, .sched_restart = sfc_mcdi_sched_restart, + .mgmt_evq_poll = sfc_mcdi_mgmt_evq_poll, }; int diff --git a/drivers/net/sfc/sfc_mcdi.h b/drivers/net/sfc/sfc_mcdi.h index 8f9b1991be..e3a637aeb7 100644 --- a/drivers/net/sfc/sfc_mcdi.h +++ b/drivers/net/sfc/sfc_mcdi.h @@ -39,10 +39,13 @@ typedef void (sfc_efx_mcdi_dma_free_cb)(void *cookie, efsys_mem_t *esmp); typedef void (sfc_efx_mcdi_sched_restart_cb)(void *cookie); +typedef void (sfc_efx_mcdi_mgmt_evq_poll_cb)(void *cookie); + struct sfc_efx_mcdi_ops { sfc_efx_mcdi_dma_alloc_cb *dma_alloc; sfc_efx_mcdi_dma_free_cb *dma_free; sfc_efx_mcdi_sched_restart_cb *sched_restart; + sfc_efx_mcdi_mgmt_evq_poll_cb *mgmt_evq_poll; }; struct sfc_efx_mcdi { -- 2.17.1