From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 917B345DAB; Tue, 26 Nov 2024 15:04:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25C7C40A71; Tue, 26 Nov 2024 15:04:03 +0100 (CET) Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by mails.dpdk.org (Postfix) with ESMTP id A9B364064A for ; Tue, 26 Nov 2024 15:04:01 +0100 (CET) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id 374DC1380497; Tue, 26 Nov 2024 09:04:01 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Tue, 26 Nov 2024 09:04:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1732629841; x=1732716241; bh=arsxJ55xb1rVhUAyDJy4MS8KTqHpgDKBDCEA8PxIWIM=; b= NWF1j2VvfIuNKP1V3aGBoGZpwM3LDTGnxaJ2ZTJ0Tpca1SzT2mWjIUtymDRKL3V9 nG1PQzj7t3LMh2T6juKjVlewq3+Bos8WRvDBKyG+uQR1RGUIH89eQD6nCoxuiZH3 B05zkgol6oUcTYr8iPkJ84snmZEflKVU/qe44rYwqWFHJKgs0QttzFVY016CDLJm 0NYUXWRsiRy6Z2FfccOlfcRSUltk9vubONHsXx5AtHb6lF1J+qwhjmxKgjml5LAl 5F+PUzL2031hQgN7tnuZiqaTcFucMKLBHgNasfPbT4CcDNftohcO1x+3CP/6yh4P E//fZhjBjMp2xWJhEK6z5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732629841; x= 1732716241; bh=arsxJ55xb1rVhUAyDJy4MS8KTqHpgDKBDCEA8PxIWIM=; b=u X0PuDM3xOOCygPolTUXNuirIXRJqPujGLb6fUA2PJQ1+Eu0KvHoc8/dqAWMlgjZH 5a/fKsH0XutkRcgOFACr+wwgziQcSXpcRlvPW+HxdKQEazdEZII+493CJKIvcbz9 2ZuxHiSsiZxvHqoeysDJselZiPwcJRWMF8JcqUQbsxNTVtHdvXKNAKmkiVRGrJjV rSGksSn7+m+UxE62A3HGN2fmPoiCRm4fnQ6i41cIrzrCQ3QF7deA+1wEb2IVa7+y M/qkCV8n2lgQjqJWwMajlo/gXyhjlZBa24cfWzbMw6b5VLPoU74ppGwimBZ+KcoO pZDCHhPajnsZzxmHlHqeQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeejgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprhhjrghrrh ihsehrvgguhhgrthdrtghomhdprhgtphhtthhopehsthgvphhhvghnsehnvghtfihorhhk phhluhhmsggvrhdrohhrghdprhgtphhtthhopeguvghvseguphgukhdrohhrgh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Nov 2024 09:03:59 -0500 (EST) From: Thomas Monjalon To: Robin Jarry , Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [PATCH] devtools: download scripts from linux if not found Date: Tue, 26 Nov 2024 15:03:57 +0100 Message-ID: <16017055.uLZWGnKmhe@thomas> In-Reply-To: <20241004093128.5932a84e@hermes.local> References: <20240315141441.259594-2-rjarry@redhat.com> <20241004093128.5932a84e@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/10/2024 18:31, Stephen Hemminger: > On Fri, 15 Mar 2024 15:14:42 +0100 > Robin Jarry wrote: > > > Both checkpatches.sh and get-maintainer.sh require scripts that come > > from the linux sources. And they require DPDK_*_PATH variables to be set > > to point at these scripts locally. For new contributors this can be > > tedious since they will have to clone the whole linux sources just to > > have simple perl scripts. > > > > Update checkpatches.sh and get-maintainer.sh to have them download the > > upstream scripts if they are not found locally. Store the downloaded > > scripts in the .git/ folder so that they are found for future runs. > > > > If either DPDK_CHECKPATCH_PATH or DPDK_GETMAINTAINER_PATH are set, they > > will be used in priority. > > > > Signed-off-by: Robin Jarry > > This makes live easier for new contributors. > Not sure if is the best way to autodownload, or where to put the scripts > but something is better than the current way. > > Acked-by: Stephen Hemminger I would prefer we host our own fork of checkpatch.pl. There are too many irrelevant checks that we should drop.