From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76369A04AB; Wed, 6 Nov 2019 12:02:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B78001BF71; Wed, 6 Nov 2019 12:02:46 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 09E761BF51 for ; Wed, 6 Nov 2019 12:02:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9F16521B0E; Wed, 6 Nov 2019 06:02:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 06 Nov 2019 06:02:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ZAlnwv4GN3HzBKm+7ENsLUHm79C2i+1pacURfOiLmY4=; b=Nc1z8/wgfPtV wXv5tnJFaVr4/3VtQnalA/rVnyIzUgvpFQ0e/hwCvJi75aHru4c6W/wUQmMe4CRJ eYurE4908Npoqtl2BvDiNqr6PFgcn/btdeELRoSDJZaSL7LwjMo5wiDFO7QmV5gx gk/8D6rmhpQMBaQyIQ5Gdsz6gpv6sbs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ZAlnwv4GN3HzBKm+7ENsLUHm79C2i+1pacURfOiLm Y4=; b=eVCbP5QvVld+X86XyQPTh2dYbUrnadCuhIT0rIKRl1v5q2nGJXDKKJ7OV lwlkKhnYQYVLVjDgJTbLlAohdyLGxgKLeJTLQwFNIYZbVBnJbB6uXXLMfr/jD2Eh 3eouPoJRHAVV/bNwCOaMQtj//XH/Lojgvh67fU/83KaAj3hMbqf373/KMrgt1crn Jh+ltLUAekzOYsiYOD9Nn1W9bYuEmRtgTywi72bEz86osP+wlJiJBA781KKBCqqW hQufLyOQRaqEun6s6hidxULIgi2B6pN9N6Xl3iTIFhIwd3d3evawSkB2hHgZJbxp S6duTXq2pO3hhcL9FVEfRJDYye4Hw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddujedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehhuhgrrhhmrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeen ucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth enucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 69E868005C; Wed, 6 Nov 2019 06:02:44 -0500 (EST) From: Thomas Monjalon To: Rasesh Mody Cc: dev@dpdk.org, Bruce Richardson , Ferruh Yigit , Jerin Jacob Kollanukkaran , GR-Everest-DPDK-Dev Date: Wed, 06 Nov 2019 12:02:43 +0100 Message-ID: <1602077.SlinmuVpUp@xps> In-Reply-To: <20191106054520.19580-1-rmody@marvell.com> References: <20191101060228.23271-1-rmody@marvell.com> <20191106054520.19580-1-rmody@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: fix meson build failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/11/2019 06:45, Rasesh Mody: > Use kernel headers for __le* types to avoid potential conflicts > resulting in redefinition errors for Linux build environments. Errors happen only with "some" Linux environments. > Add check for FreeBSD execution environments. >=20 > Without this fix, aarch64 builds can fail with error [1] below. >=20 > [1] > In file included from ../drivers/net/bnx2x/bnx2x.h:22, > from ../drivers/net/bnx2x/bnx2x_ethdev.c:8: > ../drivers/net/bnx2x/bnx2x_osal.h:27:17: error: conflicting types for > =E2=80=98uint64_t=E2=80=99 > #define __le64 uint64_t > ^~~~~~~~ > In file included from /usr/include/stdint.h:37, > from > /usr/lib/gcc/aarch64-linux-gnu/8/include/stdint.h:9, > from > ../lib/librte_eal/common/include/arch/arm/rte_byteorder.h:16, > from ../drivers/net/bnx2x/bnx2x.h:17, > from ../drivers/net/bnx2x/bnx2x_ethdev.c:8: > /usr/include/aarch64-linux-gnu/bits/stdint-uintn.h:27:20: note: previous > declaration of =E2=80=98uint64_t=E2=80=99 was here > typedef __uint64_t uint64_t; > ^~~~~~~~ >=20 > Fixes: 38dff79ba736 ("net/bnx2x: update HSI") >=20 > v2: > Use RTE_EXEC_ENV_FREEBSD in place of __FreeBSD__ It's a bit strange to change the existing __FreeBSD__ in this patch. I'll add a note to mention this change in the commit. > Signed-off-by: Rasesh Mody > Tested-by: Dharmik Thakkar > Tested-by: Gavin Hu Applied, thanks