DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
	Junfeng Guo <junfeng.guo@intel.com>,
	arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add new RSS types for IPv6 prefix
Date: Wed, 08 Jul 2020 16:27:40 +0200	[thread overview]
Message-ID: <1602929.xpCJ37cAdX@thomas> (raw)
In-Reply-To: <20200708133703.48945-1-qi.z.zhang@intel.com>

08/07/2020 15:37, Qi Zhang:
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> +/*
> + * Only select IPV6 address prefix as RSS input set according to
> + * https://tools.ietf.org/html/rfc6052
> + * Must be combined with ETH_RSS_IPV6, ETH_RSS_NONFRAG_IPV6_UDP,
> + * ETH_RSS_NONFRAG_IPV6_TCP, ETH_RSS_NONFRAG_IPV6_SCTP.
> + */
> +#define ETH_RSS_L3_PRE32     (1ULL << 57)
> +#define ETH_RSS_L3_PRE40     (1ULL << 56)
> +#define ETH_RSS_L3_PRE48     (1ULL << 55)
> +#define ETH_RSS_L3_PRE56     (1ULL << 54)
> +#define ETH_RSS_L3_PRE64     (1ULL << 53)
> +#define ETH_RSS_L3_PRE96     (1ULL << 52)

I still think names should start with RTE_ for new additions.

Please Cc Andrew as well as he is a maintainer of ethdev.



  parent reply	other threads:[~2020-07-08 14:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 13:37 Qi Zhang
2020-07-08 13:37 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: support extended RSS offload types Qi Zhang
2020-07-08 13:37 ` [dpdk-dev] [PATCH v5 3/3] net/ice: add RSS support for IPv6 prefix Qi Zhang
2020-07-08 14:27 ` Thomas Monjalon [this message]
2020-07-09  2:06 ` [dpdk-dev] [PATCH v6 1/3] ethdev: add new RSS types " Qi Zhang
2020-07-09  2:06   ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: support extended RSS offload types Qi Zhang
2020-07-10 15:48     ` Ferruh Yigit
2020-07-09  2:06   ` [dpdk-dev] [PATCH v6 3/3] net/ice: add RSS support for IPv6 prefix Qi Zhang
2020-07-10 15:47   ` [dpdk-dev] [PATCH v6 1/3] ethdev: add new RSS types " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1602929.xpCJ37cAdX@thomas \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=junfeng.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).