From: Kevin Laatz <kevin.laatz@intel.com>
To: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>,
"Conor Walsh" <conor.walsh@intel.com>
Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows
Date: Mon, 25 Oct 2021 21:00:26 +0100 [thread overview]
Message-ID: <16030071-ad06-f902-8e64-cbca78d1d41a@intel.com> (raw)
In-Reply-To: <CAJFAV8yVYP6f1eXrBa2wA=Jf+hTsP=xBFD55194vBhhX=VoN5g@mail.gmail.com>
On 23/10/2021 11:18, David Marchand wrote:
> On Sat, Oct 23, 2021 at 8:56 AM David Marchand
> <david.marchand@redhat.com> wrote:
>> Windows compilation gives us a splat:
>> In file included from ../drivers/dma/idxd/idxd_pci.c:10:
>> In file included from ..\drivers\dma\idxd/idxd_internal.h:11:
>> ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or
>> ';' after declaration specifiers
>> uint16_t __reserved[13];
>> ~~~~~~~~ ^
>> 1 error generated.
>>
>> Ironically, __reserved is probably a reserved token.
>> Some drivers that build fine on Windows have structs with a "reserved"
>> field, let's go with this.
>>
>> Fixes: 82147042d062 ("dma/idxd: add datapath structures")
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Tested via CI@UNH.
>
> Applied.
Thanks for investigating and sending the fix for this, David.
/Kevin
prev parent reply other threads:[~2021-10-25 20:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 6:55 David Marchand
2021-10-23 8:37 ` Dmitry Kozlyuk
2021-10-23 10:20 ` David Marchand
2021-10-23 10:18 ` David Marchand
2021-10-25 20:00 ` Kevin Laatz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16030071-ad06-f902-8e64-cbca78d1d41a@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).