From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71D0BA0C4E; Mon, 25 Oct 2021 22:03:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53B0D40E3C; Mon, 25 Oct 2021 22:03:16 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 073C44003E for ; Mon, 25 Oct 2021 22:03:14 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="228508666" X-IronPort-AV: E=Sophos;i="5.87,181,1631602800"; d="scan'208";a="228508666" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 13:00:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,181,1631602800"; d="scan'208";a="664208169" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga005.jf.intel.com with ESMTP; 25 Oct 2021 13:00:34 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 25 Oct 2021 13:00:34 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 25 Oct 2021 13:00:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 25 Oct 2021 13:00:33 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 25 Oct 2021 13:00:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhoVZ54kc+cYHs8uZyYa3QNXephWcocOe+pYT6tpWz9WHtxDRaoLT1altGrYyzxheUcfA1DdUyStMA90qMlUoeAfwcYc04fH+xVh+kc7ZO4BsUbVt4/oR5/7DLvMvGC0kzG694gHC5MEzWnDoSLoghXRkIyCd+g1SmokZey0LoCpi4qMtnvudGpkqvt6xCvDcEMkZcLqzwA6wVpYtcpfaSBkUwVrtw7ujHiSnnvkf/I3MQxI4YimK37eksbx7Ze115RVfePQzf8Rv1FrccuPiC5svYpir2b3oUcK71ghPUG2I2skc2xTM9lF76mOJqf4UkFY756Uvx8zQfjA2b9msA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aS2VQXenRIKZc9yBipQ5utintvfTflmulGuqPm5pkBw=; b=e5bBk46SYB9D6swaG94t7MrnD5kBwl3v36KDyuutTHZac2VmaFSnazgdMcLfqx6q4TfcA5YzWJupO4ZkKzovLCiJwWdfjIoPaw8/jtj0exdmJ9v7I9kC4r52lCdVEDlZKjibkgP7buDYfCmzIcRzMXV35xEvvAItIPOAviErWgbVdz4r1JT3pIv6/fH0GpdK7K5HfGGks/xz9rcjLW4heBEz3EZTuUntqVqh1PxjZhungYZe4llJGjMfdj8d4Zzk6szuGpJ12hUMyJpxsmcNVFEnxniwy6Qe8Y9FdioHCdU1m9mHIw/49+6IxaOEnlcFkguyjTq7flVC126JJq+c0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aS2VQXenRIKZc9yBipQ5utintvfTflmulGuqPm5pkBw=; b=swGCIzFVj0tCv+Q/qcYH2eB4lDCSEorRFkjxaEGrvW9j41/joqEk4SXXj3iAR+KAtWxzk8iZgx8ZRXf36O+uonYlPFA6OWUH8mgGaBDly5xWjj6gl6SSYErzSG9PNrFAcUS6ua79mk/JLr7pZhokvqrJ5VOyyhxORuqowKhN3H8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5055.namprd11.prod.outlook.com (2603:10b6:a03:2d9::10) by SJ0PR11MB4975.namprd11.prod.outlook.com (2603:10b6:a03:2d0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Mon, 25 Oct 2021 20:00:31 +0000 Received: from SJ0PR11MB5055.namprd11.prod.outlook.com ([fe80::78d4:6f82:aa87:c271]) by SJ0PR11MB5055.namprd11.prod.outlook.com ([fe80::78d4:6f82:aa87:c271%6]) with mapi id 15.20.4628.020; Mon, 25 Oct 2021 20:00:31 +0000 To: David Marchand , dev CC: Thomas Monjalon , Bruce Richardson , Chengwen Feng , "Conor Walsh" References: <20211023065558.818-1-david.marchand@redhat.com> From: Kevin Laatz Message-ID: <16030071-ad06-f902-8e64-cbca78d1d41a@intel.com> Date: Mon, 25 Oct 2021 21:00:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB6PR0601CA0035.eurprd06.prod.outlook.com (2603:10a6:4:17::21) To SJ0PR11MB5055.namprd11.prod.outlook.com (2603:10b6:a03:2d9::10) MIME-Version: 1.0 Received: from [192.168.1.20] (109.79.53.214) by DB6PR0601CA0035.eurprd06.prod.outlook.com (2603:10a6:4:17::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Mon, 25 Oct 2021 20:00:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f66914a-4101-42bf-d135-08d997f2192e X-MS-TrafficTypeDiagnostic: SJ0PR11MB4975: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xC/Alr+YcNPZZl6sQWkORG1etN1IgA0d6UOIG6GIO7xYyBp/Cy8Rp+IsSAYMjxs72ufHEVcnkcpeQZTIDbejobyG8l9A+d/5ZymgOxJ62d5Vy2pQD+OB4Hgyt/ot8jHjMlKuDlHzOJwphhORJfF3nGoTM8mWIcqtchlbzykA3HERjkbzQUKCgIf604SQfjwFFJ05yFxBqsSsxoHwFh3Da1xE6UIgW6wMHTnB1nC9z/sjKIkJ9MHr6ihsO22lTLZH9kpNQCBuCPnmopGYfKRDqVgICPstxv2PXcpmfvJR0xJd9lPetpaDctQElmmZFI9KV3zpVCq+4Fg9XDvNgFXGRsKlplaNNMPb+bc9PeiLiMBQe6KOZgfV1nOgydOjMKIim6D9zg/qzLHQ0kxys6ypjotYP1hQ1TAoR4wNIv57bdCLwbADhVx+DD7/uUWTxHOjLRnzIZqwY9XDu/LmELdq0kzcupAjon3GqjWTmxcRkmPOlu0IYjLWsYPi/RMA1oxl9eY/WWtNfj+rq2PLK2pLFGos+gyLW7IQlYvyTiZ7u4XbuwdbD5klG0yW4laRxTlA93dxMjAdYyKYaynu2tDrp6gI8d5q8tplU7UCVU/CeawPmBrjSVIP9Mzt272sd0z4wGN+2fi5JaaB2WM8LlKHX6m108BTe+BUoQQazfjnUIs7mEdb3MgNPLH7fcwtqq37H0w2x21w+TAHGUmLEECJfda94LhaPNAul8+1sB/l8s8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5055.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(66476007)(8936002)(66556008)(2906002)(16576012)(82960400001)(54906003)(4744005)(66946007)(186003)(38100700002)(508600001)(5660300002)(36756003)(8676002)(6666004)(6486002)(956004)(4326008)(86362001)(53546011)(31686004)(107886003)(26005)(44832011)(110136005)(31696002)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFhGYkFXUUNDbUpVL0xXWGFCdGp5L2tqcnBnT0h5eUZHeHAvZ3MwUG9CRG5K?= =?utf-8?B?Nm0xelVEdzZTbm1MZ2NnblBUUkRac05MeEdGV05GMGdLckdZUmYrcmhHdkpi?= =?utf-8?B?bVgzUUV4YTdnWlFvVEF1V1JYem1kRnNQdzh4OUR1T2l1cHFtN2UrL0YrbExa?= =?utf-8?B?Vzl3RGRmSS9xL25FMk1QS1dITVU5TndIam9tQWpqV2FicENaZzh6eWg1S2dh?= =?utf-8?B?ZEt1ZzFWNHhkMkRsb1JZNC8rVWZRazl3K0NvYjVvNS9GUDlOcnAwYXlkZFVy?= =?utf-8?B?LzJqVXRtNC9aUkZHY2ZOSXNzcm9adFhiVnJNazBUY1RhTDN1RUFETjE5YUxr?= =?utf-8?B?ZlpHRGFtQjFvUzhxTUlwVUUzVmJXOUYyay9ZSzN4a0NHbHpQSjhvdXZxa3NK?= =?utf-8?B?Zlo5K0VYVHl6dEN2bDJMM3BtVSsvRE81OXZXS0gySHdEdmsyMUhjZHJnVzJ3?= =?utf-8?B?dkdiYWNWT2N4YVRwNDJhc0MzMHpzNlJicFVNYUFYYkVXOFBsVS9jNDZqN1pL?= =?utf-8?B?U1VLS1JNRTcxNHo4YlZaK0RnTTRzOEplbjErN1JOZFRUb0ozaTZ5RXp6REhF?= =?utf-8?B?RUlra2Y2dmFRamhpRi9Qcmo3QjB4TGNJMTBNNVREQmZWUXdqZFRhTUUzV3pM?= =?utf-8?B?VEJaRHpHbFlUNHZEc3hwTDlZYzdVeVl0UnkrNUpRclJFVHJCdlhTeEh5ZTZW?= =?utf-8?B?WE9qQkxlQXZYSnQzdlZ1MnVuUjJkdW9sMmxOWFZWWTZmQ2hpMlVsVXY4bFpO?= =?utf-8?B?L1BWOWJYMndpV0NrZ0dvOE5TS2Q2ZnVwRUdmRTluNHZCckRRbUt6cDhjSW5C?= =?utf-8?B?eFBmMXYzeGRXR2RQTlBhb2FxY1I5cnpRZkcrTzdqcXFTQkY5OXZHUUc1Ymdn?= =?utf-8?B?cTRIdFpWdTl0TTd6Qm9iMHNSbFRFL3prZmJreSs2WmZLOEh0MldkTHFORXZn?= =?utf-8?B?djhkN09heGFIbjJ5dDFSQ0FuRFBQTUtEZ3hURVJBbXpsb1ludGhVcXE2YVNl?= =?utf-8?B?OTd1ZEZjS0RNM2ZTeGJwZU1kUGU1VlFCeTIxNFg0T0RudzJpaGxudVN0eUZi?= =?utf-8?B?K2YvQ3dSb3UwSGl6RG9kc0plNyszeDJPbk9BSkxqZnVvaVFlS0RIaDliWjM0?= =?utf-8?B?QTFkekF4UUVTR3p2aXFZRnh6eDVkZHhDS3JuQ3ZqNk15L1laMjlkTVF4RFFJ?= =?utf-8?B?eGNtNUFBTnVia2o2cVVpSnVUZzdzYk1vZDlOWTNZQ1hjUEFPeXNNQ04rM3Ar?= =?utf-8?B?eEFMU0pZdkNxZkM3UlE2S3lSRlFISU12aWZvQUxibjc4b1hpUlJWNCtCbFg3?= =?utf-8?B?dEVjcFZ1andvSEdoMlJzeGdGQytISStQbzh0WU9ROVpQNTJkL0FYbkdnNWJK?= =?utf-8?B?M3gwT2lTTG9XSFBCcmp6dnNHNnZTT0NyL0FiL2I4b2ltT0ZIQ1pKZVVwS0g5?= =?utf-8?B?K2JnQm1HaHBPa09lZS9JdzZhTUQwcnB3ZzVxejJsMElhN1ZXemh0Q3hZUTZ6?= =?utf-8?B?a3lLaDJ4TkhhdnRSU2psdExFM2twd1Ura2w5Sml5Vk91Z2dYQTIzRzEzcXpi?= =?utf-8?B?Vjhvd1ZpV3FJb2ZSOXQ2QTVrZzQ3WWRuSWdLMlowdk1BV1prNkR0b2dwTzFy?= =?utf-8?B?WXNIeUxkR1EvL1cyYkdubmR6WUFUeXA4bzErQjhQTzQ3SlZnQzJ4V0YxeFNJ?= =?utf-8?B?WTM3NmxiQWZWQ0Y4b1U5cU9Md1o3WkpNVEx4UkpqcGZhbVdsNDltNjN0akU5?= =?utf-8?B?akJCUmJjZzFxV1FOYlF2MmY3bzdITEFFZUJVMllEcm5CNGk1RDVqUTNrNS9s?= =?utf-8?B?czlDWFRSZ3Roc3VwQ1Z2TFBubWtNaVZTOWQ2blNFbDM3bGp2eHVwVmQ0ejdj?= =?utf-8?B?Rm9XeVEyaHJxZ2duRE4wNHp5UGtkcVkwVUJyQ0NqMWo2RTd0a2dXY3hRT2dX?= =?utf-8?B?REp1RHNIWDB1VTdFRmpxcXNFQ0VFalozNURKRzNEOEI0NUdHZEgyNXd3RHVV?= =?utf-8?B?ZUsrMHE0dDM1KzV5dCsvaEpVbXdOUENYbHRIL1JFZE1ad0JzZkU1b2NOY2la?= =?utf-8?B?Q2tPMUhJZ3htZDYreDVsS24wTHowU09Vc1VjZkl2ejJwMkVoTW0xSDFnaVRp?= =?utf-8?B?QmptUHB2a0ZndTErYzhra0toTGkwTkZKUFo0dlZuREs3TGZKMVpEMlZIZmtu?= =?utf-8?Q?skbkCyMmMqvAGpvqvhF1rMg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4f66914a-4101-42bf-d135-08d997f2192e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5055.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 20:00:31.1099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vBfHkg4iNmWqiJpmfdUE3jpZrY0iZb9dVHpMtijtZre8EHkj8VRpPyK6WCvzp4kRva6S9+n9gok6rN9UeaZeIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4975 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 23/10/2021 11:18, David Marchand wrote: > On Sat, Oct 23, 2021 at 8:56 AM David Marchand > wrote: >> Windows compilation gives us a splat: >> In file included from ../drivers/dma/idxd/idxd_pci.c:10: >> In file included from ..\drivers\dma\idxd/idxd_internal.h:11: >> ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or >> ';' after declaration specifiers >> uint16_t __reserved[13]; >> ~~~~~~~~ ^ >> 1 error generated. >> >> Ironically, __reserved is probably a reserved token. >> Some drivers that build fine on Windows have structs with a "reserved" >> field, let's go with this. >> >> Fixes: 82147042d062 ("dma/idxd: add datapath structures") >> >> Signed-off-by: David Marchand > Tested via CI@UNH. > > Applied. Thanks for investigating and sending the fix for this, David. /Kevin