From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 397559404 for ; Mon, 7 Dec 2015 03:17:31 +0100 (CET) Received: by wmww144 with SMTP id w144so132003597wmw.0 for ; Sun, 06 Dec 2015 18:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=9+seGR+qWijf4aNfsOilfioJzEzpHLmaJe04imX9yxg=; b=HPGWBrSBpMeMArYXIKTcFWGShxgg5VWxnYLBPdmktcwwnEjFtpDC6nUh1lDaDVRgF7 l4TRNRJtKegTC/pP99PJ442Vvw0RfAn5AqzXValVIwJdXo68gTvRjGj5ZioHco+8Lh6/ av6K5a2WtQEqdOPkZCSCb2SHUfn72gWCQnml/wKFmFHavebgl8qEEoW6K0GjHktGTgmF HCoVqVkUM//sfUdtC6+eefsnvH0Va/ndn7qMc8C66lQxoQb0KjmxA6p2vmSfM3MPShcI KZMGKCaWegO5tGa6RvrkNcvIVv4T8JhRyfVniE58tuH+DhtDq0oEHAKRmQOQIHv9vhz8 8XHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9+seGR+qWijf4aNfsOilfioJzEzpHLmaJe04imX9yxg=; b=JPbRaBW35x+N/6+fVU1pAPXUomHiAXrEJZTMG+AyoNkOhXzgsfKSw3/f4ZVoseeJHR Hp5Dq+7YF3Js7CCtlgG9XWmillniFQTmXvlMKPdeFPxdpe3xybcnSY+5pU0UazwOK1Vg 0p9K0312+n6nUBJffD4rimCCqreN3w5vGsrzDgyfTe8+ked9HEbKKTSqt1r+Ehk8e4Qo 6OpWFLPNn1Wlrjrgcu9B348et3L6yq7UeKHvEAIV2HxBCrzv9c0qEk+RKmQIiy8fKEfO eW0B+4uaLVnOdAxe3mqgCGWpzp4ceMBWd2Z1qzPF4yzwvhjNfFXdiuHjPd0hH0I++cvE UxVw== X-Gm-Message-State: ALoCoQkbpFmP2eIAXE1EkZofjQVaQy5Rm0/2CnCOcgkRrCAHMhq6sxxXo29OFm8aWofPkJltdZqO X-Received: by 10.194.19.168 with SMTP id g8mr30113805wje.38.1449454651113; Sun, 06 Dec 2015 18:17:31 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id u4sm22813226wjz.4.2015.12.06.18.17.30 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Dec 2015 18:17:30 -0800 (PST) From: Thomas Monjalon To: harish.patil@qlogic.com Date: Mon, 07 Dec 2015 03:16:19 +0100 Message-ID: <1603158.UYlFNfLQMJ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836AC87E4@irsmsx105.ger.corp.intel.com> References: <1447011596-2993-1-git-send-email-harish.patil@qlogic.com> <2601191342CEEE43887BDE71AB97725836AC87E4@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] l3fwd: Fix l3fwd crash due to unaligned load/store intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 02:17:31 -0000 > > l3fwd app expects PMDs to return packets whose L2 header is > > 16-byte aligned due to usage of _mm_load_si128()/_mm_store_si128() > > intrinsics in the app. However, most of the protocol stacks expects > > packets such that its IP/L3 header be aligned on a 16-byte boundary. > > > > Based on the recommendations received on dpdk-dev, we are changing > > the l3fwd app to use _mm_loadu_si128()/_mm_loadu_si128() so that the > > address need not be 16-byte aligned and thereby preventing crash. > > We have tested that there is no performance impact due to this > > change. > > > > Signed-off-by: Harish Patil > > Acked-by: Konstantin Ananyev Applied, thanks