From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id E28CD5A69 for ; Thu, 29 Oct 2015 19:19:43 +0100 (CET) Received: by wikq8 with SMTP id q8so292662284wik.1 for ; Thu, 29 Oct 2015 11:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=DITlLKETv33i9jLiBaAii0DXQhcZNL9xoHcftRkVH/o=; b=w1PtQNASoOLlSimlA0lx+aSEdRMdLvFgLP9dcMwDvQF5G11r4bCyrwV6Qmnpb6L+UW EtklJwTz7a+45LKCiknFsF9TAio9SjR0W2/HPPOp5Il5oefCDF1uxIcxQK0WsfHpa8LF 7r2ZqzYlzcLpqNPysCcXndYdJpM5AlrYW9esSgwy6eLcsTBE1iEwcxounyn4djSdkK2X /rmYKQjKHNp0a5PGoiwzzsLqZUaZZUqWD1rZqhBDzXbOROa5ZZidJIwiBfpYVepoSEg/ P5Q9aKLofoFYfFUvgWnA+a6qXZA/f9TzcmLBQ/PLl/ABXIKisbW0NB11eVCReX+5ul6k nV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DITlLKETv33i9jLiBaAii0DXQhcZNL9xoHcftRkVH/o=; b=DtCsPYJtVgauRzYPuh8dhvu2ydJ7LgdU5+YQq0gX0SCMFiJH6jwCQeob3CuG7RX+6+ LNN1b1NBU1qBPVOA+C0xprIFoQh3ogZUg/OGkK7bCiM4uM+9xV3G6duHjeJT2umSb95h 8LOxWIH4o7kjI4D6eq9gopezLQH05r+l1O0I0qfcYtS4qhiKM97mRiQAecyFIOfDSl6/ qzDFfroRpVuvdn1ZNjtSQj5+A55OYtP8L8E4HFzSKODptvvklyIAxRx0jslNfkv60YAn 85pJj0sSGQoNIiXHxt4f3Q2RgrDLRLAR5T7WTUVY7CES4oIn0kXPawHqnTg/QPV2rT73 1UaA== X-Gm-Message-State: ALoCoQkABwgOGiDRjrCdI2tsVNVDOfd50GxQ7ylfX5YZPblWewCKIlyZtzNQiHtN9Mc0Tfho6gyf X-Received: by 10.194.115.100 with SMTP id jn4mr4304545wjb.155.1446142783692; Thu, 29 Oct 2015 11:19:43 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id d10sm3026614wje.14.2015.10.29.11.19.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Oct 2015 11:19:42 -0700 (PDT) From: Thomas Monjalon To: Yong Liu Date: Thu, 29 Oct 2015 19:18:32 +0100 Message-ID: <1603993.a4RWodNe3S@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446134187-4573-1-git-send-email-yong.liu@intel.com> References: <1446134187-4573-1-git-send-email-yong.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/7] e1000: add rx interrupt support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 18:19:44 -0000 2015-10-29 23:56, Yong Liu: > This patch set will enable interrup for physical and emulated e1000 device. > Rx queue interrupt will work with uio driver or vfio driver with msi mode. > l3fwd-power will disable interrupt immediately when wake-up for that e1000 not > support interrupt auto clear. > LSC and rxq interrupt will be seperated for e1000 can only support one > interrupt cause in the same time. Don't you think it should be explained in a doc? doc/guides/nics/e1000em.rst I'm especially confused by the need of changing an example for this PMD. Does it mean the API behaviour must be changed? [...] > Marvin Liu (7): > e1000: add rx interrupt support > e1000: separate lsc and rxq interrupt disable function > e1000: add ethdev rxq enable and disable function > e1000: add rxq interrupt handler > e1000: check lsc and rxq not enable in the same time > e1000: lsc interrupt setup function only enable itself > l3fwd-power: disable interrupt when wake up from sleep Announcing a support in first patch and making it work later is a strange logic to review. You forgot to keep the Acked-by: Cunming Liang Applied in this order: e1000: restrict link interrupt setup scope e1000: separate link and Rx interrupt disabling e1000: support Rx interrupt setup e1000: add Rx interrupt handler l3fwd-power: disable Rx interrupt when waking up Thanks