From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFC5FA04DD; Fri, 30 Oct 2020 09:35:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EAB6BA54B; Fri, 30 Oct 2020 09:35:12 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 70E006CA9; Fri, 30 Oct 2020 09:35:09 +0100 (CET) IronPort-SDR: DiSnbvtPIVnTUl/6uhRm5DISVlupE/iBO4c8nT7pbML1UTEM7WH+ZfHYZ2+oaK5SP+S606X5xu mwfQxJibqMew== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="155551050" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="155551050" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 01:35:08 -0700 IronPort-SDR: +HAld7jDt29j9jeTlgKfVOsXGnGw+j6UsCFeorirTXQ9Uz8nQ4CG4CISs+zwheN9RglGG49g9U Qmd0g5FK4+3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="536991614" Received: from unknown (HELO sh_lab5_1.sh.intel.com) ([10.238.175.190]) by orsmga005.jf.intel.com with ESMTP; 30 Oct 2020 01:35:07 -0700 From: Wei Huang To: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com Cc: stable@dpdk.org, Wei Huang Date: Fri, 30 Oct 2020 03:35:06 -0400 Message-Id: <1604043307-20730-2-git-send-email-wei.huang@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1604043307-20730-1-git-send-email-wei.huang@intel.com> References: <1604043307-20730-1-git-send-email-wei.huang@intel.com> Subject: [dpdk-dev] [PATCH v3 1/2] raw/ifpga: terminate string filled by readlink with null X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" readlink() does not terminate string, add a null character at the end of the string if readlink() succeeds. Coverity issue: 362820 Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Signed-off-by: Wei Huang --- v2: fix coding style issue v3: add coverity issue number --- drivers/raw/ifpga/ifpga_rawdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index 0385514..f9de167 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -230,8 +230,9 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev *ifpga_dev, memset(link, 0, sizeof(link)); memset(link1, 0, sizeof(link1)); ret = readlink(path, link, (sizeof(link)-1)); - if (ret == -1) + if ((ret < 0) || ((unsigned int)ret > (sizeof(link)-1))) return -1; + link[ret] = 0; /* terminate string with null character */ strlcpy(link1, link, sizeof(link1)); memset(ifpga_dev->parent_bdf, 0, 16); point = strlen(link); -- 2.7.3