From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 000B6A04B5; Thu, 29 Oct 2020 18:39:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DC8DC31F; Thu, 29 Oct 2020 18:39:28 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id F2D9CC30F for ; Thu, 29 Oct 2020 18:39:25 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 4F45A580541; Thu, 29 Oct 2020 13:39:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 29 Oct 2020 13:39:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= M6il0+7B5WASv1oWuVB4+TNg8KvBC9wcd3A+ym6PdPs=; b=EmPneZ6GDEqMu6VH 2XG7gKDPEt03NiS+9qoPOiTrYaLTzWyrFKN4ciCEeTtbfuJQoDMm1a4ZOqP77Dbt Nm8eJc4K5Wxlu3evik8FKVIM1nb5VWKxWnjj/QudAMdrGh/pU1nQ0SdFBJVWeHHQ 9DLts2Ui8Q5WWFl0Rmid8ayvVjrsAvIUTmOMq/tYnZLRLg+ldtCT15AB56jouPOA 0SInzQ+CIwFxokZUNlznzn2lf3zfiOWDwbanQoGGRconzNKRr9GD8XvrHtwH4DfQ QAN8j0xgul24Z76c4sR+5YwKToKKEbMpMFgeixCXECSLMD4aa3J2zw4uVinKy1bq d8DJDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=M6il0+7B5WASv1oWuVB4+TNg8KvBC9wcd3A+ym6Pd Ps=; b=eCheEU+dMcVbYciYr+9EAILpM8uBOz9eTaNi0+quD1HtMIw27GFuSnGDT +CNB/lRCv4N7gXTKonQ8wivsDYr36r1XGKdewJdXASNebtx7rq2mneFvjN8zHT/d Vcuvg6e3eFpjX9xGjsk/Vv4eecp39HBqs8PV3BfvcrllfmbzJSwMzsXP2r+g9mdo tjnBfeeOFbmN92erhQc/Fh4AZQGTtEq9dpNrqkqkTF/+g7hrHAmV8Z8QucEWJyad w+tAe85OulVMz94yjryG5C/XzLyaAVCD2mMy+gYVKUFtrIx8Nvk0Dx/juMY+TMAj iYWBZ+PzF0Kk+y49PKXB+3ifyZXvw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E7363064686; Thu, 29 Oct 2020 13:39:21 -0400 (EDT) From: Thomas Monjalon To: Liang Ma Cc: dev@dpdk.org, ruifeng.wang@arm.com, haiyue.wang@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, david.hunt@intel.com, jerinjacobk@gmail.com, nhorman@tuxdriver.com, timothy.mcdaniel@intel.com, gage.eads@intel.com, mw@semihalf.com, gtzalik@amazon.com, ajit.khaparde@broadcom.com, hkalra@marvell.com, johndale@cisco.com, xavier.huwei@huawei.com, xuanziyang2@huawei.com, matan@nvidia.com, yongwang@vmware.com, Anatoly Burakov , Jerin Jacob , Jan Viktorin , David Christensen , david.marchand@redhat.com Date: Thu, 29 Oct 2020 18:39:19 +0100 Message-ID: <16041065.rxK84FDPHi@thomas> In-Reply-To: <1603810749-22285-3-git-send-email-liang.j.ma@intel.com> References: <1603810749-22285-1-git-send-email-liang.j.ma@intel.com> <1603810749-22285-3-git-send-email-liang.j.ma@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 2/9] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 15:59, Liang Ma: > +static inline uint64_t > +__get_umwait_val(const volatile void *p, const uint8_t sz) > +{ > + switch (sz) { > + case sizeof(uint8_t): > + return *(const volatile uint8_t *)p; > + case sizeof(uint16_t): > + return *(const volatile uint16_t *)p; > + case sizeof(uint32_t): > + return *(const volatile uint32_t *)p; > + case sizeof(uint64_t): > + return *(const volatile uint64_t *)p; > + default: > + /* this is an intrinsic, so we can't have any error handling */ > + RTE_ASSERT(0); > + return 0; > + } > +} This function is going to pollute the namespace. I will fix it to __rte_power_get_umwait_val().