DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: support age shared action context
@ 2020-11-01 17:48 Matan Azrad
  2020-11-02 18:50 ` Ferruh Yigit
  2020-11-05 21:32 ` [dpdk-dev] [PATCH v2] " Matan Azrad
  0 siblings, 2 replies; 17+ messages in thread
From: Matan Azrad @ 2020-11-01 17:48 UTC (permalink / raw)
  To: Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

When an age action becomes aged-out the rte_flow_get_aged_flows should
return the action context supplied by the configuration structure.

In case the age action created by the shared action API, the shared
action context of the Testpmd application was not set.

In addition, the application handler of the contexts returned by the
rte_flow_get_aged_flows API didn't consider the fact that the action
could be set by the shared action API and considered it as regular flow
context.

This caused a crash in Testpmd when the context is parsed.

This patch set context type in the flow and shared action context and
uses it to parse the aged-out contexts correctly.

Signed-off-by: Matan Azrad <matan@nvidia.com>
Acked-by: Dekel Peled <dekelp@nvidia.com>
---
 app/test-pmd/config.c  | 57 ++++++++++++++++++++++++++++++++++++--------------
 app/test-pmd/testpmd.h |  7 +++++++
 2 files changed, 48 insertions(+), 16 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index e0203f0..3581f3d 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1665,8 +1665,10 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
 		return NULL;
 	}
 	if (rte_flow_conv(RTE_FLOW_CONV_OP_RULE, &pf->rule, ret, &rule,
-			  error) >= 0)
+			  error) >= 0) {
+		pf->ctype = CONTEXT_TYPE_FLOW;
 		return pf;
+	}
 	free(pf);
 	return NULL;
 }
@@ -1831,6 +1833,7 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
 	}
 	psa->next = *ppsa;
 	psa->id = id;
+	psa->ctype = CONTEXT_TYPE_SHARED_ACTION;
 	*ppsa = psa;
 	*action = psa;
 	return 0;
@@ -1849,6 +1852,12 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
 	ret = action_alloc(port_id, id, &psa);
 	if (ret)
 		return ret;
+	if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
+		struct rte_flow_action_age *age =
+				(void *)(uintptr_t)(action->conf);
+
+		age->context = psa;
+	}
 	/* Poisoning to make sure PMDs update it in case of error. */
 	memset(&error, 0x22, sizeof(error));
 	psa->action = rte_flow_shared_action_create(port_id, conf, action,
@@ -2379,7 +2388,10 @@ struct rte_flow_shared_action *
 	void **contexts;
 	int nb_context, total = 0, idx;
 	struct rte_flow_error error;
-	struct port_flow *pf;
+	union {
+		struct port_flow *pf;
+		struct port_shared_action *psa;
+	} ctx;
 
 	if (port_id_is_invalid(port_id, ENABLED_WARN) ||
 	    port_id == (portid_t)RTE_PORT_ALL)
@@ -2397,7 +2409,7 @@ struct rte_flow_shared_action *
 		printf("Cannot allocate contexts for aged flow\n");
 		return;
 	}
-	printf("ID\tGroup\tPrio\tAttr\n");
+	printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
 	nb_context = rte_flow_get_aged_flows(port_id, contexts, total, &error);
 	if (nb_context != total) {
 		printf("Port:%d get aged flows count(%d) != total(%d)\n",
@@ -2406,18 +2418,31 @@ struct rte_flow_shared_action *
 		return;
 	}
 	for (idx = 0; idx < nb_context; idx++) {
-		pf = (struct port_flow *)contexts[idx];
-		if (!pf) {
+		ctx.pf = (struct port_flow *)contexts[idx];
+		if (!ctx.pf) {
 			printf("Error: get Null context in port %u\n", port_id);
 			continue;
 		}
-		printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
-		       pf->id,
-		       pf->rule.attr->group,
-		       pf->rule.attr->priority,
-		       pf->rule.attr->ingress ? 'i' : '-',
-		       pf->rule.attr->egress ? 'e' : '-',
-		       pf->rule.attr->transfer ? 't' : '-');
+		switch (ctx.pf->ctype) {
+		case CONTEXT_TYPE_FLOW:
+			printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
+								 "\t%c%c%c\t\n",
+			       "Flow",
+			       ctx.pf->id,
+			       ctx.pf->rule.attr->group,
+			       ctx.pf->rule.attr->priority,
+			       ctx.pf->rule.attr->ingress ? 'i' : '-',
+			       ctx.pf->rule.attr->egress ? 'e' : '-',
+			       ctx.pf->rule.attr->transfer ? 't' : '-');
+			break;
+		case CONTEXT_TYPE_SHARED_ACTION:
+			printf("%-20s\t%" PRIu32 "\n", "Shared action",
+			       ctx.psa->id);
+			break;
+		default:
+			printf("Error: invalid context type %u\n", port_id);
+			break;
+		}
 	}
 	if (destroy) {
 		int ret;
@@ -2426,15 +2451,15 @@ struct rte_flow_shared_action *
 		total = 0;
 		printf("\n");
 		for (idx = 0; idx < nb_context; idx++) {
-			pf = (struct port_flow *)contexts[idx];
-			if (!pf)
+			ctx.pf = (struct port_flow *)contexts[idx];
+			if (!ctx.pf || ctx.pf->ctype != CONTEXT_TYPE_FLOW)
 				continue;
-			flow_id = pf->id;
+			flow_id = ctx.pf->id;
 			ret = port_flow_destroy(port_id, 1, &flow_id);
 			if (!ret)
 				total++;
 		}
-		printf("%d flows be destroyed\n", total);
+		printf("%d flows destroyed\n", total);
 	}
 	free(contexts);
 }
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 519d551..92aaa19 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -143,8 +143,14 @@ struct fwd_stream {
 	struct pkt_burst_stats tx_burst_stats;
 };
 
+enum testpmd_context_type {
+	CONTEXT_TYPE_FLOW,
+	CONTEXT_TYPE_SHARED_ACTION,
+};
+
 /** Descriptor for a single flow. */
 struct port_flow {
+	enum testpmd_context_type ctype; /**< Context type. */
 	struct port_flow *next; /**< Next flow in list. */
 	struct port_flow *tmp; /**< Temporary linking. */
 	uint32_t id; /**< Flow rule ID. */
@@ -155,6 +161,7 @@ struct port_flow {
 
 /* Descriptor for shared action */
 struct port_shared_action {
+	enum testpmd_context_type ctype; /**< Context type. */
 	struct port_shared_action *next; /**< Next flow in list. */
 	uint32_t id; /**< Shared action ID. */
 	enum rte_flow_action_type type; /**< Action type. */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context
  2020-11-01 17:48 [dpdk-dev] [PATCH] app/testpmd: support age shared action context Matan Azrad
@ 2020-11-02 18:50 ` Ferruh Yigit
  2020-11-03  7:33   ` Matan Azrad
  2020-11-05 21:32 ` [dpdk-dev] [PATCH v2] " Matan Azrad
  1 sibling, 1 reply; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-02 18:50 UTC (permalink / raw)
  To: Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

On 11/1/2020 5:48 PM, Matan Azrad wrote:
> When an age action becomes aged-out the rte_flow_get_aged_flows should
> return the action context supplied by the configuration structure.
> 
> In case the age action created by the shared action API, the shared
> action context of the Testpmd application was not set.
> 
> In addition, the application handler of the contexts returned by the
> rte_flow_get_aged_flows API didn't consider the fact that the action
> could be set by the shared action API and considered it as regular flow
> context.
> 
> This caused a crash in Testpmd when the context is parsed.
> 
> This patch set context type in the flow and shared action context and
> uses it to parse the aged-out contexts correctly.
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Dekel Peled <dekelp@nvidia.com>
> ---
>   app/test-pmd/config.c  | 57 ++++++++++++++++++++++++++++++++++++--------------
>   app/test-pmd/testpmd.h |  7 +++++++
>   2 files changed, 48 insertions(+), 16 deletions(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index e0203f0..3581f3d 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1665,8 +1665,10 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
>   		return NULL;
>   	}
>   	if (rte_flow_conv(RTE_FLOW_CONV_OP_RULE, &pf->rule, ret, &rule,
> -			  error) >= 0)
> +			  error) >= 0) {
> +		pf->ctype = CONTEXT_TYPE_FLOW;
>   		return pf;
> +	}
>   	free(pf);
>   	return NULL;
>   }
> @@ -1831,6 +1833,7 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
>   	}
>   	psa->next = *ppsa;
>   	psa->id = id;
> +	psa->ctype = CONTEXT_TYPE_SHARED_ACTION;
>   	*ppsa = psa;
>   	*action = psa;
>   	return 0;
> @@ -1849,6 +1852,12 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
>   	ret = action_alloc(port_id, id, &psa);
>   	if (ret)
>   		return ret;
> +	if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
> +		struct rte_flow_action_age *age =
> +				(void *)(uintptr_t)(action->conf);
> +
> +		age->context = psa;
> +	}

The port flow is using 'update_age_action_context()' function, can same function 
be utilized to update age context for shared action too?

btw, not sure why 'update_age_action_context()' is not static, if you will touch 
it can you please make it static function?

And overall this context setting for the age action is requiring the special 
conditions in the flow create path, can you please check if it can be moved to 
'cmdline_flow.c' for age parsing code somehow?

>   	/* Poisoning to make sure PMDs update it in case of error. */
>   	memset(&error, 0x22, sizeof(error));
>   	psa->action = rte_flow_shared_action_create(port_id, conf, action,
> @@ -2379,7 +2388,10 @@ struct rte_flow_shared_action *
>   	void **contexts;
>   	int nb_context, total = 0, idx;
>   	struct rte_flow_error error;
> -	struct port_flow *pf;
> +	union {
> +		struct port_flow *pf;
> +		struct port_shared_action *psa;
> +	} ctx;
>   
>   	if (port_id_is_invalid(port_id, ENABLED_WARN) ||
>   	    port_id == (portid_t)RTE_PORT_ALL)
> @@ -2397,7 +2409,7 @@ struct rte_flow_shared_action *
>   		printf("Cannot allocate contexts for aged flow\n");
>   		return;
>   	}
> -	printf("ID\tGroup\tPrio\tAttr\n");
> +	printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
>   	nb_context = rte_flow_get_aged_flows(port_id, contexts, total, &error);
>   	if (nb_context != total) {
>   		printf("Port:%d get aged flows count(%d) != total(%d)\n",
> @@ -2406,18 +2418,31 @@ struct rte_flow_shared_action *
>   		return;
>   	}
>   	for (idx = 0; idx < nb_context; idx++) {
> -		pf = (struct port_flow *)contexts[idx];
> -		if (!pf) {
> +		ctx.pf = (struct port_flow *)contexts[idx];
> +		if (!ctx.pf) {
>   			printf("Error: get Null context in port %u\n", port_id);
>   			continue;
>   		}
> -		printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
> -		       pf->id,
> -		       pf->rule.attr->group,
> -		       pf->rule.attr->priority,
> -		       pf->rule.attr->ingress ? 'i' : '-',
> -		       pf->rule.attr->egress ? 'e' : '-',
> -		       pf->rule.attr->transfer ? 't' : '-');
> +		switch (ctx.pf->ctype) {


At this stage you don't know if the context is 'pf' or 'psa', but you rely that 
both structure first element is "enum testpmd_context_type" and this requirement 
is completely undocumented.

Why don't create a common context and pass that one the the age action for both 
'pf' & 'psa', like

struct port_flow_age_action_context {
     enum testpmd_context_type ctype;
     union {
         struct port_flow *pf;
         struct port_shared_action *psa;
     } ctx;
};

I think this also prevents to corrupt 'pf' and 'psa' just for age action.

> +		case CONTEXT_TYPE_FLOW:
> +			printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
> +								 "\t%c%c%c\t\n",
> +			       "Flow",
> +			       ctx.pf->id,
> +			       ctx.pf->rule.attr->group,
> +			       ctx.pf->rule.attr->priority,
> +			       ctx.pf->rule.attr->ingress ? 'i' : '-',
> +			       ctx.pf->rule.attr->egress ? 'e' : '-',
> +			       ctx.pf->rule.attr->transfer ? 't' : '-');
> +			break;
> +		case CONTEXT_TYPE_SHARED_ACTION:
> +			printf("%-20s\t%" PRIu32 "\n", "Shared action",
> +			       ctx.psa->id);
> +			break;
> +		default:
> +			printf("Error: invalid context type %u\n", port_id);
> +			break;
> +		}
>   	}
>   	if (destroy) {
>   		int ret;
> @@ -2426,15 +2451,15 @@ struct rte_flow_shared_action *
>   		total = 0;
>   		printf("\n");
>   		for (idx = 0; idx < nb_context; idx++) {
> -			pf = (struct port_flow *)contexts[idx];
> -			if (!pf)
> +			ctx.pf = (struct port_flow *)contexts[idx];
> +			if (!ctx.pf || ctx.pf->ctype != CONTEXT_TYPE_FLOW)
>   				continue;

When the context is 'CONTEXT_TYPE_SHARED_ACTION', who destroys it?

> -			flow_id = pf->id;
> +			flow_id = ctx.pf->id;
>   			ret = port_flow_destroy(port_id, 1, &flow_id);
>   			if (!ret)
>   				total++;
>   		}
> -		printf("%d flows be destroyed\n", total);
> +		printf("%d flows destroyed\n", total);
>   	}
>   	free(contexts);
>   }
> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> index 519d551..92aaa19 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -143,8 +143,14 @@ struct fwd_stream {
>   	struct pkt_burst_stats tx_burst_stats;
>   };
>   
> +enum testpmd_context_type {
> +	CONTEXT_TYPE_FLOW,
> +	CONTEXT_TYPE_SHARED_ACTION,
> +};
> +

The enum prefix is too generic, 'CONTEXT_TYPE_', what do you think clarifying 
what context we are talking about?

>   /** Descriptor for a single flow. */
>   struct port_flow {
> +	enum testpmd_context_type ctype; /**< Context type. */
>   	struct port_flow *next; /**< Next flow in list. */
>   	struct port_flow *tmp; /**< Temporary linking. */
>   	uint32_t id; /**< Flow rule ID. */
> @@ -155,6 +161,7 @@ struct port_flow {
>   
>   /* Descriptor for shared action */
>   struct port_shared_action {
> +	enum testpmd_context_type ctype; /**< Context type. */
>   	struct port_shared_action *next; /**< Next flow in list. */
>   	uint32_t id; /**< Shared action ID. */
>   	enum rte_flow_action_type type; /**< Action type. */
> 


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context
  2020-11-02 18:50 ` Ferruh Yigit
@ 2020-11-03  7:33   ` Matan Azrad
  2020-11-04 12:58     ` Ferruh Yigit
  0 siblings, 1 reply; 17+ messages in thread
From: Matan Azrad @ 2020-11-03  7:33 UTC (permalink / raw)
  To: Ferruh Yigit, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

Hi Ferruh

Thank you for the fast review.
Please see inline

From: Ferruh Yigit
> On 11/1/2020 5:48 PM, Matan Azrad wrote:
> > When an age action becomes aged-out the rte_flow_get_aged_flows should
> > return the action context supplied by the configuration structure.
> >
> > In case the age action created by the shared action API, the shared
> > action context of the Testpmd application was not set.
> >
> > In addition, the application handler of the contexts returned by the
> > rte_flow_get_aged_flows API didn't consider the fact that the action
> > could be set by the shared action API and considered it as regular
> > flow context.
> >
> > This caused a crash in Testpmd when the context is parsed.
> >
> > This patch set context type in the flow and shared action context and
> > uses it to parse the aged-out contexts correctly.
> >
> > Signed-off-by: Matan Azrad <matan@nvidia.com>
> > Acked-by: Dekel Peled <dekelp@nvidia.com>
> > ---
> >   app/test-pmd/config.c  | 57 ++++++++++++++++++++++++++++++++++++-----
> ---------
> >   app/test-pmd/testpmd.h |  7 +++++++
> >   2 files changed, 48 insertions(+), 16 deletions(-)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > e0203f0..3581f3d 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1665,8 +1665,10 @@ void port_flow_tunnel_create(portid_t port_id,
> const struct tunnel_ops *ops)
> >               return NULL;
> >       }
> >       if (rte_flow_conv(RTE_FLOW_CONV_OP_RULE, &pf->rule, ret, &rule,
> > -                       error) >= 0)
> > +                       error) >= 0) {
> > +             pf->ctype = CONTEXT_TYPE_FLOW;
> >               return pf;
> > +     }
> >       free(pf);
> >       return NULL;
> >   }
> > @@ -1831,6 +1833,7 @@ void port_flow_tunnel_create(portid_t port_id,
> const struct tunnel_ops *ops)
> >       }
> >       psa->next = *ppsa;
> >       psa->id = id;
> > +     psa->ctype = CONTEXT_TYPE_SHARED_ACTION;
> >       *ppsa = psa;
> >       *action = psa;
> >       return 0;
> > @@ -1849,6 +1852,12 @@ void port_flow_tunnel_create(portid_t port_id,
> const struct tunnel_ops *ops)
> >       ret = action_alloc(port_id, id, &psa);
> >       if (ret)
> >               return ret;
> > +     if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
> > +             struct rte_flow_action_age *age =
> > +                             (void *)(uintptr_t)(action->conf);
> > +
> > +             age->context = psa;
> > +     }
> 
> The port flow is using 'update_age_action_context()' function, can same
> function be utilized to update age context for shared action too?

For updating flow context, the code iterates all actions to find the age action - so it worth to call dedicate function.
For updating  shared action context - it a direct access.
So, they have different search method.


> 
> btw, not sure why 'update_age_action_context()' is not static, if you will touch
> it can you please make it static function?
> 
> And overall this context setting for the age action is requiring the special
> conditions in the flow create path, can you please check if it can be moved to
> 'cmdline_flow.c' for age parsing code somehow?
> 
> >       /* Poisoning to make sure PMDs update it in case of error. */
> >       memset(&error, 0x22, sizeof(error));
> >       psa->action = rte_flow_shared_action_create(port_id, conf,
> > action, @@ -2379,7 +2388,10 @@ struct rte_flow_shared_action *
> >       void **contexts;
> >       int nb_context, total = 0, idx;
> >       struct rte_flow_error error;
> > -     struct port_flow *pf;
> > +     union {
> > +             struct port_flow *pf;
> > +             struct port_shared_action *psa;
> > +     } ctx;
> >
> >       if (port_id_is_invalid(port_id, ENABLED_WARN) ||
> >           port_id == (portid_t)RTE_PORT_ALL) @@ -2397,7 +2409,7 @@
> > struct rte_flow_shared_action *
> >               printf("Cannot allocate contexts for aged flow\n");
> >               return;
> >       }
> > -     printf("ID\tGroup\tPrio\tAttr\n");
> > +     printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
> >       nb_context = rte_flow_get_aged_flows(port_id, contexts, total, &error);
> >       if (nb_context != total) {
> >               printf("Port:%d get aged flows count(%d) !=
> > total(%d)\n", @@ -2406,18 +2418,31 @@ struct rte_flow_shared_action *
> >               return;
> >       }
> >       for (idx = 0; idx < nb_context; idx++) {
> > -             pf = (struct port_flow *)contexts[idx];
> > -             if (!pf) {
> > +             ctx.pf = (struct port_flow *)contexts[idx];
> > +             if (!ctx.pf) {
> >                       printf("Error: get Null context in port %u\n", port_id);
> >                       continue;
> >               }
> > -             printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
> > -                    pf->id,
> > -                    pf->rule.attr->group,
> > -                    pf->rule.attr->priority,
> > -                    pf->rule.attr->ingress ? 'i' : '-',
> > -                    pf->rule.attr->egress ? 'e' : '-',
> > -                    pf->rule.attr->transfer ? 't' : '-');
> > +             switch (ctx.pf->ctype) {
> 
> 
> At this stage you don't know if the context is 'pf' or 'psa', but you rely that both
> structure first element is "enum testpmd_context_type" and this requirement is
> completely undocumented.

Yes, will add a comment.

> 
> Why don't create a common context and pass that one the the age action for
> both 'pf' & 'psa', like
> 
> struct port_flow_age_action_context {
>      enum testpmd_context_type ctype;
>      union {
>          struct port_flow *pf;
>          struct port_shared_action *psa;
>      } ctx;
> };

We considered this option too,
It looked us more optimized to not utilize more memory and alloc\free time for each age context.

One more option we considered:

Use age action context pointer as uint32_t\uintptr_t - use 2 bits for type and others for pf->id psa->id.
What do you think about this?


> I think this also prevents to corrupt 'pf' and 'psa' just for age action.


> 
> > +             case CONTEXT_TYPE_FLOW:
> > +                     printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
> > +                                                              "\t%c%c%c\t\n",
> > +                            "Flow",
> > +                            ctx.pf->id,
> > +                            ctx.pf->rule.attr->group,
> > +                            ctx.pf->rule.attr->priority,
> > +                            ctx.pf->rule.attr->ingress ? 'i' : '-',
> > +                            ctx.pf->rule.attr->egress ? 'e' : '-',
> > +                            ctx.pf->rule.attr->transfer ? 't' : '-');
> > +                     break;
> > +             case CONTEXT_TYPE_SHARED_ACTION:
> > +                     printf("%-20s\t%" PRIu32 "\n", "Shared action",
> > +                            ctx.psa->id);
> > +                     break;
> > +             default:
> > +                     printf("Error: invalid context type %u\n", port_id);
> > +                     break;
> > +             }
> >       }
> >       if (destroy) {
> >               int ret;
> > @@ -2426,15 +2451,15 @@ struct rte_flow_shared_action *
> >               total = 0;
> >               printf("\n");
> >               for (idx = 0; idx < nb_context; idx++) {
> > -                     pf = (struct port_flow *)contexts[idx];
> > -                     if (!pf)
> > +                     ctx.pf = (struct port_flow *)contexts[idx];
> > +                     if (!ctx.pf || ctx.pf->ctype !=
> > + CONTEXT_TYPE_FLOW)
> >                               continue;
> 
> When the context is 'CONTEXT_TYPE_SHARED_ACTION', who destroys it?

Destroy request is optional, I didn't add a support to destroy something here:
1 options here is to save all the flows assigned to the age shared action inside the shared action context and destroy all of them + the shared aged action.
It can be step 2 later.

> 
> > -                     flow_id = pf->id;
> > +                     flow_id = ctx.pf->id;
> >                       ret = port_flow_destroy(port_id, 1, &flow_id);
> >                       if (!ret)
> >                               total++;
> >               }
> > -             printf("%d flows be destroyed\n", total);
> > +             printf("%d flows destroyed\n", total);
> >       }
> >       free(contexts);
> >   }
> > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index
> > 519d551..92aaa19 100644
> > --- a/app/test-pmd/testpmd.h
> > +++ b/app/test-pmd/testpmd.h
> > @@ -143,8 +143,14 @@ struct fwd_stream {
> >       struct pkt_burst_stats tx_burst_stats;
> >   };
> >
> > +enum testpmd_context_type {
> > +     CONTEXT_TYPE_FLOW,
> > +     CONTEXT_TYPE_SHARED_ACTION,
> > +};
> > +
> 
> The enum prefix is too generic, 'CONTEXT_TYPE_', what do you think clarifying
> what context we are talking about?

enum flow_age_action_context_type {
	FLOW_AGE_ACTION_CTX_FLOW,
	FLOW_AGE_ACTION_CTX_SHARED_ACTION,
}

?
> 
> >   /** Descriptor for a single flow. */
> >   struct port_flow {
> > +     enum testpmd_context_type ctype; /**< Context type. */
> >       struct port_flow *next; /**< Next flow in list. */
> >       struct port_flow *tmp; /**< Temporary linking. */
> >       uint32_t id; /**< Flow rule ID. */ @@ -155,6 +161,7 @@ struct
> > port_flow {
> >
> >   /* Descriptor for shared action */
> >   struct port_shared_action {
> > +     enum testpmd_context_type ctype; /**< Context type. */
> >       struct port_shared_action *next; /**< Next flow in list. */
> >       uint32_t id; /**< Shared action ID. */
> >       enum rte_flow_action_type type; /**< Action type. */
> >


What do you think about changing the rte_flow_get_aged_flows API name to rte_flow_get_aged_contexts ?

Matan

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context
  2020-11-03  7:33   ` Matan Azrad
@ 2020-11-04 12:58     ` Ferruh Yigit
  2020-11-04 13:28       ` Matan Azrad
  0 siblings, 1 reply; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-04 12:58 UTC (permalink / raw)
  To: Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

On 11/3/2020 7:33 AM, Matan Azrad wrote:
> Hi Ferruh
> 
> Thank you for the fast review.
> Please see inline
> 
> From: Ferruh Yigit
>> On 11/1/2020 5:48 PM, Matan Azrad wrote:
>>> When an age action becomes aged-out the rte_flow_get_aged_flows should
>>> return the action context supplied by the configuration structure.
>>>
>>> In case the age action created by the shared action API, the shared
>>> action context of the Testpmd application was not set.
>>>
>>> In addition, the application handler of the contexts returned by the
>>> rte_flow_get_aged_flows API didn't consider the fact that the action
>>> could be set by the shared action API and considered it as regular
>>> flow context.
>>>
>>> This caused a crash in Testpmd when the context is parsed.
>>>
>>> This patch set context type in the flow and shared action context and
>>> uses it to parse the aged-out contexts correctly.
>>>
>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
>>> Acked-by: Dekel Peled <dekelp@nvidia.com>
>>> ---
>>>    app/test-pmd/config.c  | 57 ++++++++++++++++++++++++++++++++++++-----
>> ---------
>>>    app/test-pmd/testpmd.h |  7 +++++++
>>>    2 files changed, 48 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>>> e0203f0..3581f3d 100644
>>> --- a/app/test-pmd/config.c
>>> +++ b/app/test-pmd/config.c
>>> @@ -1665,8 +1665,10 @@ void port_flow_tunnel_create(portid_t port_id,
>> const struct tunnel_ops *ops)
>>>                return NULL;
>>>        }
>>>        if (rte_flow_conv(RTE_FLOW_CONV_OP_RULE, &pf->rule, ret, &rule,
>>> -                       error) >= 0)
>>> +                       error) >= 0) {
>>> +             pf->ctype = CONTEXT_TYPE_FLOW;
>>>                return pf;
>>> +     }
>>>        free(pf);
>>>        return NULL;
>>>    }
>>> @@ -1831,6 +1833,7 @@ void port_flow_tunnel_create(portid_t port_id,
>> const struct tunnel_ops *ops)
>>>        }
>>>        psa->next = *ppsa;
>>>        psa->id = id;
>>> +     psa->ctype = CONTEXT_TYPE_SHARED_ACTION;
>>>        *ppsa = psa;
>>>        *action = psa;
>>>        return 0;
>>> @@ -1849,6 +1852,12 @@ void port_flow_tunnel_create(portid_t port_id,
>> const struct tunnel_ops *ops)
>>>        ret = action_alloc(port_id, id, &psa);
>>>        if (ret)
>>>                return ret;
>>> +     if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
>>> +             struct rte_flow_action_age *age =
>>> +                             (void *)(uintptr_t)(action->conf);
>>> +
>>> +             age->context = psa;
>>> +     }
>>
>> The port flow is using 'update_age_action_context()' function, can same
>> function be utilized to update age context for shared action too?
> 
> For updating flow context, the code iterates all actions to find the age action - so it worth to call dedicate function.
> For updating  shared action context - it a direct access.
> So, they have different search method.
> 

Just to reduce the age action related churn in the code, if it can be abstracted 
in to a single function I prefer it, if that doesn't make sense it is OK.

> 
>>
>> btw, not sure why 'update_age_action_context()' is not static, if you will touch
>> it can you please make it static function?
>>
>> And overall this context setting for the age action is requiring the special
>> conditions in the flow create path, can you please check if it can be moved to
>> 'cmdline_flow.c' for age parsing code somehow?
>>
>>>        /* Poisoning to make sure PMDs update it in case of error. */
>>>        memset(&error, 0x22, sizeof(error));
>>>        psa->action = rte_flow_shared_action_create(port_id, conf,
>>> action, @@ -2379,7 +2388,10 @@ struct rte_flow_shared_action *
>>>        void **contexts;
>>>        int nb_context, total = 0, idx;
>>>        struct rte_flow_error error;
>>> -     struct port_flow *pf;
>>> +     union {
>>> +             struct port_flow *pf;
>>> +             struct port_shared_action *psa;
>>> +     } ctx;
>>>
>>>        if (port_id_is_invalid(port_id, ENABLED_WARN) ||
>>>            port_id == (portid_t)RTE_PORT_ALL) @@ -2397,7 +2409,7 @@
>>> struct rte_flow_shared_action *
>>>                printf("Cannot allocate contexts for aged flow\n");
>>>                return;
>>>        }
>>> -     printf("ID\tGroup\tPrio\tAttr\n");
>>> +     printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
>>>        nb_context = rte_flow_get_aged_flows(port_id, contexts, total, &error);
>>>        if (nb_context != total) {
>>>                printf("Port:%d get aged flows count(%d) !=
>>> total(%d)\n", @@ -2406,18 +2418,31 @@ struct rte_flow_shared_action *
>>>                return;
>>>        }
>>>        for (idx = 0; idx < nb_context; idx++) {
>>> -             pf = (struct port_flow *)contexts[idx];
>>> -             if (!pf) {
>>> +             ctx.pf = (struct port_flow *)contexts[idx];
>>> +             if (!ctx.pf) {
>>>                        printf("Error: get Null context in port %u\n", port_id);
>>>                        continue;
>>>                }
>>> -             printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
>>> -                    pf->id,
>>> -                    pf->rule.attr->group,
>>> -                    pf->rule.attr->priority,
>>> -                    pf->rule.attr->ingress ? 'i' : '-',
>>> -                    pf->rule.attr->egress ? 'e' : '-',
>>> -                    pf->rule.attr->transfer ? 't' : '-');
>>> +             switch (ctx.pf->ctype) {
>>
>>
>> At this stage you don't know if the context is 'pf' or 'psa', but you rely that both
>> structure first element is "enum testpmd_context_type" and this requirement is
>> completely undocumented.
> 
> Yes, will add a comment.
> 
>>
>> Why don't create a common context and pass that one the the age action for
>> both 'pf' & 'psa', like
>>
>> struct port_flow_age_action_context {
>>       enum testpmd_context_type ctype;
>>       union {
>>           struct port_flow *pf;
>>           struct port_shared_action *psa;
>>       } ctx;
>> };
> 
> We considered this option too,
> It looked us more optimized to not utilize more memory and alloc\free time for each age context.
> 
> One more option we considered:
> 
> Use age action context pointer as uint32_t\uintptr_t - use 2 bits for type and others for pf->id psa->id.
> What do you think about this?
> 

Will 'id' be enough? I see other information is used, though not sure if it is 
only for print.

I will be unexpected to use the pointer for id but it works, can you please add 
enough comment to clarify the usage?

> 
>> I think this also prevents to corrupt 'pf' and 'psa' just for age action.
> 
> 
>>
>>> +             case CONTEXT_TYPE_FLOW:
>>> +                     printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
>>> +                                                              "\t%c%c%c\t\n",
>>> +                            "Flow",
>>> +                            ctx.pf->id,
>>> +                            ctx.pf->rule.attr->group,
>>> +                            ctx.pf->rule.attr->priority,
>>> +                            ctx.pf->rule.attr->ingress ? 'i' : '-',
>>> +                            ctx.pf->rule.attr->egress ? 'e' : '-',
>>> +                            ctx.pf->rule.attr->transfer ? 't' : '-');
>>> +                     break;
>>> +             case CONTEXT_TYPE_SHARED_ACTION:
>>> +                     printf("%-20s\t%" PRIu32 "\n", "Shared action",
>>> +                            ctx.psa->id);
>>> +                     break;
>>> +             default:
>>> +                     printf("Error: invalid context type %u\n", port_id);
>>> +                     break;
>>> +             }
>>>        }
>>>        if (destroy) {
>>>                int ret;
>>> @@ -2426,15 +2451,15 @@ struct rte_flow_shared_action *
>>>                total = 0;
>>>                printf("\n");
>>>                for (idx = 0; idx < nb_context; idx++) {
>>> -                     pf = (struct port_flow *)contexts[idx];
>>> -                     if (!pf)
>>> +                     ctx.pf = (struct port_flow *)contexts[idx];
>>> +                     if (!ctx.pf || ctx.pf->ctype !=
>>> + CONTEXT_TYPE_FLOW)
>>>                                continue;
>>
>> When the context is 'CONTEXT_TYPE_SHARED_ACTION', who destroys it?
> 
> Destroy request is optional, I didn't add a support to destroy something here:
> 1 options here is to save all the flows assigned to the age shared action inside the shared action context and destroy all of them + the shared aged action.
> It can be step 2 later.
> 

OK

>>
>>> -                     flow_id = pf->id;
>>> +                     flow_id = ctx.pf->id;
>>>                        ret = port_flow_destroy(port_id, 1, &flow_id);
>>>                        if (!ret)
>>>                                total++;
>>>                }
>>> -             printf("%d flows be destroyed\n", total);
>>> +             printf("%d flows destroyed\n", total);
>>>        }
>>>        free(contexts);
>>>    }
>>> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index
>>> 519d551..92aaa19 100644
>>> --- a/app/test-pmd/testpmd.h
>>> +++ b/app/test-pmd/testpmd.h
>>> @@ -143,8 +143,14 @@ struct fwd_stream {
>>>        struct pkt_burst_stats tx_burst_stats;
>>>    };
>>>
>>> +enum testpmd_context_type {
>>> +     CONTEXT_TYPE_FLOW,
>>> +     CONTEXT_TYPE_SHARED_ACTION,
>>> +};
>>> +
>>
>> The enum prefix is too generic, 'CONTEXT_TYPE_', what do you think clarifying
>> what context we are talking about?
> 
> enum flow_age_action_context_type {
> 	FLOW_AGE_ACTION_CTX_FLOW,
> 	FLOW_AGE_ACTION_CTX_SHARED_ACTION,
> }
> 
> ?

I think better, thanks.

>>
>>>    /** Descriptor for a single flow. */
>>>    struct port_flow {
>>> +     enum testpmd_context_type ctype; /**< Context type. */
>>>        struct port_flow *next; /**< Next flow in list. */
>>>        struct port_flow *tmp; /**< Temporary linking. */
>>>        uint32_t id; /**< Flow rule ID. */ @@ -155,6 +161,7 @@ struct
>>> port_flow {
>>>
>>>    /* Descriptor for shared action */
>>>    struct port_shared_action {
>>> +     enum testpmd_context_type ctype; /**< Context type. */
>>>        struct port_shared_action *next; /**< Next flow in list. */
>>>        uint32_t id; /**< Shared action ID. */
>>>        enum rte_flow_action_type type; /**< Action type. */
>>>
> 
> 
> What do you think about changing the rte_flow_get_aged_flows API name to rte_flow_get_aged_contexts ?
> 

Here context has some data do identify the aged flows, right? If so 
'rte_flow_get_aged_flows' also reasonable I think.

No strong opinion but the API name as it is looks good to me.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context
  2020-11-04 12:58     ` Ferruh Yigit
@ 2020-11-04 13:28       ` Matan Azrad
  2020-11-04 13:45         ` Ferruh Yigit
  0 siblings, 1 reply; 17+ messages in thread
From: Matan Azrad @ 2020-11-04 13:28 UTC (permalink / raw)
  To: Ferruh Yigit, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev



 From: Ferruh Yigit
> On 11/3/2020 7:33 AM, Matan Azrad wrote:
> > Hi Ferruh
> >
> > Thank you for the fast review.
> > Please see inline
> >
> > From: Ferruh Yigit
> >> On 11/1/2020 5:48 PM, Matan Azrad wrote:
> >>> When an age action becomes aged-out the rte_flow_get_aged_flows
> >>> should return the action context supplied by the configuration structure.
> >>>
> >>> In case the age action created by the shared action API, the shared
> >>> action context of the Testpmd application was not set.
> >>>
> >>> In addition, the application handler of the contexts returned by the
> >>> rte_flow_get_aged_flows API didn't consider the fact that the action
> >>> could be set by the shared action API and considered it as regular
> >>> flow context.
> >>>
> >>> This caused a crash in Testpmd when the context is parsed.
> >>>
> >>> This patch set context type in the flow and shared action context
> >>> and uses it to parse the aged-out contexts correctly.
> >>>
> >>> Signed-off-by: Matan Azrad <matan@nvidia.com>
> >>> Acked-by: Dekel Peled <dekelp@nvidia.com>
> >>> ---
> >>>    app/test-pmd/config.c  | 57
> >>> ++++++++++++++++++++++++++++++++++++-----
> >> ---------
> >>>    app/test-pmd/testpmd.h |  7 +++++++
> >>>    2 files changed, 48 insertions(+), 16 deletions(-)
> >>>
> >>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> >>> e0203f0..3581f3d 100644
> >>> --- a/app/test-pmd/config.c
> >>> +++ b/app/test-pmd/config.c
> >>> @@ -1665,8 +1665,10 @@ void port_flow_tunnel_create(portid_t
> >>> port_id,
> >> const struct tunnel_ops *ops)
> >>>                return NULL;
> >>>        }
> >>>        if (rte_flow_conv(RTE_FLOW_CONV_OP_RULE, &pf->rule, ret, &rule,
> >>> -                       error) >= 0)
> >>> +                       error) >= 0) {
> >>> +             pf->ctype = CONTEXT_TYPE_FLOW;
> >>>                return pf;
> >>> +     }
> >>>        free(pf);
> >>>        return NULL;
> >>>    }
> >>> @@ -1831,6 +1833,7 @@ void port_flow_tunnel_create(portid_t port_id,
> >> const struct tunnel_ops *ops)
> >>>        }
> >>>        psa->next = *ppsa;
> >>>        psa->id = id;
> >>> +     psa->ctype = CONTEXT_TYPE_SHARED_ACTION;
> >>>        *ppsa = psa;
> >>>        *action = psa;
> >>>        return 0;
> >>> @@ -1849,6 +1852,12 @@ void port_flow_tunnel_create(portid_t
> >>> port_id,
> >> const struct tunnel_ops *ops)
> >>>        ret = action_alloc(port_id, id, &psa);
> >>>        if (ret)
> >>>                return ret;
> >>> +     if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
> >>> +             struct rte_flow_action_age *age =
> >>> +                             (void *)(uintptr_t)(action->conf);
> >>> +
> >>> +             age->context = psa;
> >>> +     }
> >>
> >> The port flow is using 'update_age_action_context()' function, can
> >> same function be utilized to update age context for shared action too?
> >
> > For updating flow context, the code iterates all actions to find the age action -
> so it worth to call dedicate function.
> > For updating  shared action context - it a direct access.
> > So, they have different search method.
> >
> 
> Just to reduce the age action related churn in the code, if it can be abstracted
> in to a single function I prefer it, if that doesn't make sense it is OK.
> 
> >
> >>
> >> btw, not sure why 'update_age_action_context()' is not static, if you
> >> will touch it can you please make it static function?
> >>
> >> And overall this context setting for the age action is requiring the
> >> special conditions in the flow create path, can you please check if
> >> it can be moved to 'cmdline_flow.c' for age parsing code somehow?
> >>
> >>>        /* Poisoning to make sure PMDs update it in case of error. */
> >>>        memset(&error, 0x22, sizeof(error));
> >>>        psa->action = rte_flow_shared_action_create(port_id, conf,
> >>> action, @@ -2379,7 +2388,10 @@ struct rte_flow_shared_action *
> >>>        void **contexts;
> >>>        int nb_context, total = 0, idx;
> >>>        struct rte_flow_error error;
> >>> -     struct port_flow *pf;
> >>> +     union {
> >>> +             struct port_flow *pf;
> >>> +             struct port_shared_action *psa;
> >>> +     } ctx;
> >>>
> >>>        if (port_id_is_invalid(port_id, ENABLED_WARN) ||
> >>>            port_id == (portid_t)RTE_PORT_ALL) @@ -2397,7 +2409,7 @@
> >>> struct rte_flow_shared_action *
> >>>                printf("Cannot allocate contexts for aged flow\n");
> >>>                return;
> >>>        }
> >>> -     printf("ID\tGroup\tPrio\tAttr\n");
> >>> +     printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
> >>>        nb_context = rte_flow_get_aged_flows(port_id, contexts, total,
> &error);
> >>>        if (nb_context != total) {
> >>>                printf("Port:%d get aged flows count(%d) !=
> >>> total(%d)\n", @@ -2406,18 +2418,31 @@ struct rte_flow_shared_action *
> >>>                return;
> >>>        }
> >>>        for (idx = 0; idx < nb_context; idx++) {
> >>> -             pf = (struct port_flow *)contexts[idx];
> >>> -             if (!pf) {
> >>> +             ctx.pf = (struct port_flow *)contexts[idx];
> >>> +             if (!ctx.pf) {
> >>>                        printf("Error: get Null context in port %u\n", port_id);
> >>>                        continue;
> >>>                }
> >>> -             printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
> >>> -                    pf->id,
> >>> -                    pf->rule.attr->group,
> >>> -                    pf->rule.attr->priority,
> >>> -                    pf->rule.attr->ingress ? 'i' : '-',
> >>> -                    pf->rule.attr->egress ? 'e' : '-',
> >>> -                    pf->rule.attr->transfer ? 't' : '-');
> >>> +             switch (ctx.pf->ctype) {
> >>
> >>
> >> At this stage you don't know if the context is 'pf' or 'psa', but you
> >> rely that both structure first element is "enum testpmd_context_type"
> >> and this requirement is completely undocumented.
> >
> > Yes, will add a comment.
> >
> >>
> >> Why don't create a common context and pass that one the the age
> >> action for both 'pf' & 'psa', like
> >>
> >> struct port_flow_age_action_context {
> >>       enum testpmd_context_type ctype;
> >>       union {
> >>           struct port_flow *pf;
> >>           struct port_shared_action *psa;
> >>       } ctx;
> >> };
> >
> > We considered this option too,
> > It looked us more optimized to not utilize more memory and alloc\free time
> for each age context.
> >
> > One more option we considered:
> >
> > Use age action context pointer as uint32_t\uintptr_t - use 2 bits for type and
> others for pf->id psa->id.
> > What do you think about this?
> >
> 
> Will 'id' be enough? I see other information is used, though not sure if it is only
> for print.
> 

From the id we can get the pointer(and other information) - this is the same ID as supplied by the command line user to query\destroy an existed flows.

> I will be unexpected to use the pointer for id but it works, can you please add
> enough comment to clarify the usage?

If you mean code comment, yes I will add.

> >
> >> I think this also prevents to corrupt 'pf' and 'psa' just for age action.
> >
> >
> >>
> >>> +             case CONTEXT_TYPE_FLOW:
> >>> +                     printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
> >>> +                                                              "\t%c%c%c\t\n",
> >>> +                            "Flow",
> >>> +                            ctx.pf->id,
> >>> +                            ctx.pf->rule.attr->group,
> >>> +                            ctx.pf->rule.attr->priority,
> >>> +                            ctx.pf->rule.attr->ingress ? 'i' : '-',
> >>> +                            ctx.pf->rule.attr->egress ? 'e' : '-',
> >>> +                            ctx.pf->rule.attr->transfer ? 't' : '-');
> >>> +                     break;
> >>> +             case CONTEXT_TYPE_SHARED_ACTION:
> >>> +                     printf("%-20s\t%" PRIu32 "\n", "Shared action",
> >>> +                            ctx.psa->id);
> >>> +                     break;
> >>> +             default:
> >>> +                     printf("Error: invalid context type %u\n", port_id);
> >>> +                     break;
> >>> +             }
> >>>        }
> >>>        if (destroy) {
> >>>                int ret;
> >>> @@ -2426,15 +2451,15 @@ struct rte_flow_shared_action *
> >>>                total = 0;
> >>>                printf("\n");
> >>>                for (idx = 0; idx < nb_context; idx++) {
> >>> -                     pf = (struct port_flow *)contexts[idx];
> >>> -                     if (!pf)
> >>> +                     ctx.pf = (struct port_flow *)contexts[idx];
> >>> +                     if (!ctx.pf || ctx.pf->ctype !=
> >>> + CONTEXT_TYPE_FLOW)
> >>>                                continue;
> >>
> >> When the context is 'CONTEXT_TYPE_SHARED_ACTION', who destroys it?
> >
> > Destroy request is optional, I didn't add a support to destroy something here:
> > 1 options here is to save all the flows assigned to the age shared action inside
> the shared action context and destroy all of them + the shared aged action.
> > It can be step 2 later.
> >
> 
> OK
> 
> >>
> >>> -                     flow_id = pf->id;
> >>> +                     flow_id = ctx.pf->id;
> >>>                        ret = port_flow_destroy(port_id, 1, &flow_id);
> >>>                        if (!ret)
> >>>                                total++;
> >>>                }
> >>> -             printf("%d flows be destroyed\n", total);
> >>> +             printf("%d flows destroyed\n", total);
> >>>        }
> >>>        free(contexts);
> >>>    }
> >>> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index
> >>> 519d551..92aaa19 100644
> >>> --- a/app/test-pmd/testpmd.h
> >>> +++ b/app/test-pmd/testpmd.h
> >>> @@ -143,8 +143,14 @@ struct fwd_stream {
> >>>        struct pkt_burst_stats tx_burst_stats;
> >>>    };
> >>>
> >>> +enum testpmd_context_type {
> >>> +     CONTEXT_TYPE_FLOW,
> >>> +     CONTEXT_TYPE_SHARED_ACTION,
> >>> +};
> >>> +
> >>
> >> The enum prefix is too generic, 'CONTEXT_TYPE_', what do you think
> >> clarifying what context we are talking about?
> >
> > enum flow_age_action_context_type {
> >       FLOW_AGE_ACTION_CTX_FLOW,
> >       FLOW_AGE_ACTION_CTX_SHARED_ACTION,
> > }
> >
> > ?
> 
> I think better, thanks.
> 
> >>
> >>>    /** Descriptor for a single flow. */
> >>>    struct port_flow {
> >>> +     enum testpmd_context_type ctype; /**< Context type. */
> >>>        struct port_flow *next; /**< Next flow in list. */
> >>>        struct port_flow *tmp; /**< Temporary linking. */
> >>>        uint32_t id; /**< Flow rule ID. */ @@ -155,6 +161,7 @@ struct
> >>> port_flow {
> >>>
> >>>    /* Descriptor for shared action */
> >>>    struct port_shared_action {
> >>> +     enum testpmd_context_type ctype; /**< Context type. */
> >>>        struct port_shared_action *next; /**< Next flow in list. */
> >>>        uint32_t id; /**< Shared action ID. */
> >>>        enum rte_flow_action_type type; /**< Action type. */
> >>>
> >
> >
> > What do you think about changing the rte_flow_get_aged_flows API name to
> rte_flow_get_aged_contexts ?
> >
> 
> Here context has some data do identify the aged flows, right? If so
> 'rte_flow_get_aged_flows' also reasonable I think.
> 
> No strong opinion but the API name as it is looks good to me.

OK, thanks.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context
  2020-11-04 13:28       ` Matan Azrad
@ 2020-11-04 13:45         ` Ferruh Yigit
  0 siblings, 0 replies; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-04 13:45 UTC (permalink / raw)
  To: Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

On 11/4/2020 1:28 PM, Matan Azrad wrote:
> 
> 
>   From: Ferruh Yigit
>> On 11/3/2020 7:33 AM, Matan Azrad wrote:
>>> Hi Ferruh
>>>
>>> Thank you for the fast review.
>>> Please see inline
>>>
>>> From: Ferruh Yigit
>>>> On 11/1/2020 5:48 PM, Matan Azrad wrote:
>>>>> When an age action becomes aged-out the rte_flow_get_aged_flows
>>>>> should return the action context supplied by the configuration structure.
>>>>>
>>>>> In case the age action created by the shared action API, the shared
>>>>> action context of the Testpmd application was not set.
>>>>>
>>>>> In addition, the application handler of the contexts returned by the
>>>>> rte_flow_get_aged_flows API didn't consider the fact that the action
>>>>> could be set by the shared action API and considered it as regular
>>>>> flow context.
>>>>>
>>>>> This caused a crash in Testpmd when the context is parsed.
>>>>>
>>>>> This patch set context type in the flow and shared action context
>>>>> and uses it to parse the aged-out contexts correctly.
>>>>>
>>>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
>>>>> Acked-by: Dekel Peled <dekelp@nvidia.com>
>>>>> ---
>>>>>     app/test-pmd/config.c  | 57
>>>>> ++++++++++++++++++++++++++++++++++++-----
>>>> ---------
>>>>>     app/test-pmd/testpmd.h |  7 +++++++
>>>>>     2 files changed, 48 insertions(+), 16 deletions(-)
>>>>>
>>>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>>>>> e0203f0..3581f3d 100644
>>>>> --- a/app/test-pmd/config.c
>>>>> +++ b/app/test-pmd/config.c
>>>>> @@ -1665,8 +1665,10 @@ void port_flow_tunnel_create(portid_t
>>>>> port_id,
>>>> const struct tunnel_ops *ops)
>>>>>                 return NULL;
>>>>>         }
>>>>>         if (rte_flow_conv(RTE_FLOW_CONV_OP_RULE, &pf->rule, ret, &rule,
>>>>> -                       error) >= 0)
>>>>> +                       error) >= 0) {
>>>>> +             pf->ctype = CONTEXT_TYPE_FLOW;
>>>>>                 return pf;
>>>>> +     }
>>>>>         free(pf);
>>>>>         return NULL;
>>>>>     }
>>>>> @@ -1831,6 +1833,7 @@ void port_flow_tunnel_create(portid_t port_id,
>>>> const struct tunnel_ops *ops)
>>>>>         }
>>>>>         psa->next = *ppsa;
>>>>>         psa->id = id;
>>>>> +     psa->ctype = CONTEXT_TYPE_SHARED_ACTION;
>>>>>         *ppsa = psa;
>>>>>         *action = psa;
>>>>>         return 0;
>>>>> @@ -1849,6 +1852,12 @@ void port_flow_tunnel_create(portid_t
>>>>> port_id,
>>>> const struct tunnel_ops *ops)
>>>>>         ret = action_alloc(port_id, id, &psa);
>>>>>         if (ret)
>>>>>                 return ret;
>>>>> +     if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
>>>>> +             struct rte_flow_action_age *age =
>>>>> +                             (void *)(uintptr_t)(action->conf);
>>>>> +
>>>>> +             age->context = psa;
>>>>> +     }
>>>>
>>>> The port flow is using 'update_age_action_context()' function, can
>>>> same function be utilized to update age context for shared action too?
>>>
>>> For updating flow context, the code iterates all actions to find the age action -
>> so it worth to call dedicate function.
>>> For updating  shared action context - it a direct access.
>>> So, they have different search method.
>>>
>>
>> Just to reduce the age action related churn in the code, if it can be abstracted
>> in to a single function I prefer it, if that doesn't make sense it is OK.
>>
>>>
>>>>
>>>> btw, not sure why 'update_age_action_context()' is not static, if you
>>>> will touch it can you please make it static function?
>>>>
>>>> And overall this context setting for the age action is requiring the
>>>> special conditions in the flow create path, can you please check if
>>>> it can be moved to 'cmdline_flow.c' for age parsing code somehow?
>>>>
>>>>>         /* Poisoning to make sure PMDs update it in case of error. */
>>>>>         memset(&error, 0x22, sizeof(error));
>>>>>         psa->action = rte_flow_shared_action_create(port_id, conf,
>>>>> action, @@ -2379,7 +2388,10 @@ struct rte_flow_shared_action *
>>>>>         void **contexts;
>>>>>         int nb_context, total = 0, idx;
>>>>>         struct rte_flow_error error;
>>>>> -     struct port_flow *pf;
>>>>> +     union {
>>>>> +             struct port_flow *pf;
>>>>> +             struct port_shared_action *psa;
>>>>> +     } ctx;
>>>>>
>>>>>         if (port_id_is_invalid(port_id, ENABLED_WARN) ||
>>>>>             port_id == (portid_t)RTE_PORT_ALL) @@ -2397,7 +2409,7 @@
>>>>> struct rte_flow_shared_action *
>>>>>                 printf("Cannot allocate contexts for aged flow\n");
>>>>>                 return;
>>>>>         }
>>>>> -     printf("ID\tGroup\tPrio\tAttr\n");
>>>>> +     printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
>>>>>         nb_context = rte_flow_get_aged_flows(port_id, contexts, total,
>> &error);
>>>>>         if (nb_context != total) {
>>>>>                 printf("Port:%d get aged flows count(%d) !=
>>>>> total(%d)\n", @@ -2406,18 +2418,31 @@ struct rte_flow_shared_action *
>>>>>                 return;
>>>>>         }
>>>>>         for (idx = 0; idx < nb_context; idx++) {
>>>>> -             pf = (struct port_flow *)contexts[idx];
>>>>> -             if (!pf) {
>>>>> +             ctx.pf = (struct port_flow *)contexts[idx];
>>>>> +             if (!ctx.pf) {
>>>>>                         printf("Error: get Null context in port %u\n", port_id);
>>>>>                         continue;
>>>>>                 }
>>>>> -             printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
>>>>> -                    pf->id,
>>>>> -                    pf->rule.attr->group,
>>>>> -                    pf->rule.attr->priority,
>>>>> -                    pf->rule.attr->ingress ? 'i' : '-',
>>>>> -                    pf->rule.attr->egress ? 'e' : '-',
>>>>> -                    pf->rule.attr->transfer ? 't' : '-');
>>>>> +             switch (ctx.pf->ctype) {
>>>>
>>>>
>>>> At this stage you don't know if the context is 'pf' or 'psa', but you
>>>> rely that both structure first element is "enum testpmd_context_type"
>>>> and this requirement is completely undocumented.
>>>
>>> Yes, will add a comment.
>>>
>>>>
>>>> Why don't create a common context and pass that one the the age
>>>> action for both 'pf' & 'psa', like
>>>>
>>>> struct port_flow_age_action_context {
>>>>        enum testpmd_context_type ctype;
>>>>        union {
>>>>            struct port_flow *pf;
>>>>            struct port_shared_action *psa;
>>>>        } ctx;
>>>> };
>>>
>>> We considered this option too,
>>> It looked us more optimized to not utilize more memory and alloc\free time
>> for each age context.
>>>
>>> One more option we considered:
>>>
>>> Use age action context pointer as uint32_t\uintptr_t - use 2 bits for type and
>> others for pf->id psa->id.
>>> What do you think about this?
>>>
>>
>> Will 'id' be enough? I see other information is used, though not sure if it is only
>> for print.
>>
> 
>  From the id we can get the pointer(and other information) - this is the same ID as supplied by the command line user to query\destroy an existed flows.
> 
>> I will be unexpected to use the pointer for id but it works, can you please add
>> enough comment to clarify the usage?
> 
> If you mean code comment, yes I will add.
> 

Yes, thanks.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-01 17:48 [dpdk-dev] [PATCH] app/testpmd: support age shared action context Matan Azrad
  2020-11-02 18:50 ` Ferruh Yigit
@ 2020-11-05 21:32 ` Matan Azrad
  2020-11-06 13:57   ` Ferruh Yigit
  2020-11-10 17:06   ` [dpdk-dev] [PATCH v3] " Matan Azrad
  1 sibling, 2 replies; 17+ messages in thread
From: Matan Azrad @ 2020-11-05 21:32 UTC (permalink / raw)
  To: Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev, Ferruh Yigit

When an age action becomes aged-out the rte_flow_get_aged_flows should
return the action context supplied by the configuration structure.

In case the age action created by the shared action API, the shared
action context of the Testpmd application was not set.

In addition, the application handler of the contexts returned by the
rte_flow_get_aged_flows API didn't consider the fact that the action
could be set by the shared action API and considered it as regular flow
context.

This caused a crash in Testpmd when the context is parsed.

This patch set context type in the flow and shared action context and
uses it to parse the aged-out contexts correctly.

Signed-off-by: Matan Azrad <matan@nvidia.com>
Acked-by: Dekel Peled <dekelp@nvidia.com>
---
 app/test-pmd/config.c  | 119 ++++++++++++++++++++++++++++++++++---------------
 app/test-pmd/testpmd.h |   5 +++
 2 files changed, 87 insertions(+), 37 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 755d1df..00a7dd1 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
 	}
 }
 
+#define AGE_ACTION_TYPE_MASK 0x3u
+
+static void
+set_age_action_context(void **ctx, enum action_age_context_type type, void *obj)
+{
+	uintptr_t value = (uintptr_t)obj;
+
+	/*
+	 * obj is allocated by malloc\calloc which must return an address
+	 * aligned to 8.
+	 * Use the last 2 bits for the age context type.
+	 */
+	value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
+	*ctx = (void *)value;
+}
+
+static void *
+parse_age_action_context(void *ctx, enum action_age_context_type *type)
+
+{
+	uintptr_t value = (uintptr_t)ctx;
+
+	*type = (enum action_age_context_type)(value & AGE_ACTION_TYPE_MASK);
+	value &= ~(uintptr_t)AGE_ACTION_TYPE_MASK;
+	return (void *)value;
+}
+
 static struct port_shared_action *
 action_get_by_id(portid_t port_id, uint32_t id)
 {
@@ -1849,6 +1876,14 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
 	ret = action_alloc(port_id, id, &psa);
 	if (ret)
 		return ret;
+	if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
+		struct rte_flow_action_age *age =
+			(struct rte_flow_action_age *)(uintptr_t)(action->conf);
+
+		set_age_action_context(&age->context,
+				       ACTION_AGE_CONTEXT_TYPE_SHARED_ACTION,
+				       psa);
+	}
 	/* Poisoning to make sure PMDs update it in case of error. */
 	memset(&error, 0x22, sizeof(error));
 	psa->action = rte_flow_shared_action_create(port_id, conf, action,
@@ -2113,24 +2148,20 @@ struct rte_flow_shared_action *
 	return 0;
 }
 
-/** Update age action context by port_flow pointer. */
-void
-update_age_action_context(const struct rte_flow_action *actions,
-			struct port_flow *pf)
+/** Return age action structure if exists, otherwise NULL. */
+static struct rte_flow_action_age *
+age_action_get(const struct rte_flow_action *actions)
 {
-	struct rte_flow_action_age *age = NULL;
-
 	for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
 		switch (actions->type) {
 		case RTE_FLOW_ACTION_TYPE_AGE:
-			age = (struct rte_flow_action_age *)
+			return (struct rte_flow_action_age *)
 				(uintptr_t)actions->conf;
-			age->context = pf;
-			return;
 		default:
 			break;
 		}
 	}
+	return NULL;
 }
 
 /** Create flow rule. */
@@ -2147,6 +2178,7 @@ struct rte_flow_shared_action *
 	uint32_t id = 0;
 	struct rte_flow_error error;
 	struct port_flow_tunnel *pft = NULL;
+	struct rte_flow_action_age *age = age_action_get(actions);
 
 	port = &ports[port_id];
 	if (port->flow_list) {
@@ -2170,7 +2202,9 @@ struct rte_flow_shared_action *
 	pf = port_flow_new(attr, pattern, actions, &error);
 	if (!pf)
 		return port_flow_complain(&error);
-	update_age_action_context(actions, pf);
+	if (age)
+		set_age_action_context(&age->context,
+				       ACTION_AGE_CONTEXT_TYPE_FLOW, pf);
 	/* Poisoning to make sure PMDs update it in case of error. */
 	memset(&error, 0x22, sizeof(error));
 	flow = rte_flow_create(port_id, attr, pattern, actions, &error);
@@ -2379,7 +2413,12 @@ struct rte_flow_shared_action *
 	void **contexts;
 	int nb_context, total = 0, idx;
 	struct rte_flow_error error;
-	struct port_flow *pf;
+	enum action_age_context_type type;
+	union {
+		struct port_flow *pf;
+		struct port_shared_action *psa;
+		void *obj;
+	} ctx;
 
 	if (port_id_is_invalid(port_id, ENABLED_WARN) ||
 	    port_id == (portid_t)RTE_PORT_ALL)
@@ -2397,7 +2436,7 @@ struct rte_flow_shared_action *
 		printf("Cannot allocate contexts for aged flow\n");
 		return;
 	}
-	printf("ID\tGroup\tPrio\tAttr\n");
+	printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
 	nb_context = rte_flow_get_aged_flows(port_id, contexts, total, &error);
 	if (nb_context != total) {
 		printf("Port:%d get aged flows count(%d) != total(%d)\n",
@@ -2405,37 +2444,43 @@ struct rte_flow_shared_action *
 		free(contexts);
 		return;
 	}
+	total = 0;
 	for (idx = 0; idx < nb_context; idx++) {
-		pf = (struct port_flow *)contexts[idx];
-		if (!pf) {
+		if (!contexts[idx]) {
 			printf("Error: get Null context in port %u\n", port_id);
 			continue;
 		}
-		printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
-		       pf->id,
-		       pf->rule.attr->group,
-		       pf->rule.attr->priority,
-		       pf->rule.attr->ingress ? 'i' : '-',
-		       pf->rule.attr->egress ? 'e' : '-',
-		       pf->rule.attr->transfer ? 't' : '-');
-	}
-	if (destroy) {
-		int ret;
-		uint32_t flow_id;
-
-		total = 0;
-		printf("\n");
-		for (idx = 0; idx < nb_context; idx++) {
-			pf = (struct port_flow *)contexts[idx];
-			if (!pf)
-				continue;
-			flow_id = pf->id;
-			ret = port_flow_destroy(port_id, 1, &flow_id);
-			if (!ret)
-				total++;
+		ctx.obj = parse_age_action_context(contexts[idx], &type);
+		if (!ctx.obj) {
+			printf("Error: get Null age context in port %u\n",
+			       port_id);
+			continue;
+		}
+		switch (type) {
+		case ACTION_AGE_CONTEXT_TYPE_FLOW:
+			printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
+								 "\t%c%c%c\t\n",
+			       "Flow",
+			       ctx.pf->id,
+			       ctx.pf->rule.attr->group,
+			       ctx.pf->rule.attr->priority,
+			       ctx.pf->rule.attr->ingress ? 'i' : '-',
+			       ctx.pf->rule.attr->egress ? 'e' : '-',
+			       ctx.pf->rule.attr->transfer ? 't' : '-');
+			if (destroy && !port_flow_destroy(port_id, 1,
+							  &ctx.pf->id))
+					total++;
+			break;
+		case ACTION_AGE_CONTEXT_TYPE_SHARED_ACTION:
+			printf("%-20s\t%" PRIu32 "\n", "Shared action",
+			       ctx.psa->id);
+			break;
+		default:
+			printf("Error: invalid context type %u\n", port_id);
+			break;
 		}
-		printf("%d flows be destroyed\n", total);
 	}
+	printf("\n%d flows destroyed\n", total);
 	free(contexts);
 }
 
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 519d551..52a6bca 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -143,6 +143,11 @@ struct fwd_stream {
 	struct pkt_burst_stats tx_burst_stats;
 };
 
+enum action_age_context_type {
+	ACTION_AGE_CONTEXT_TYPE_FLOW,
+	ACTION_AGE_CONTEXT_TYPE_SHARED_ACTION,
+};
+
 /** Descriptor for a single flow. */
 struct port_flow {
 	struct port_flow *next; /**< Next flow in list. */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-05 21:32 ` [dpdk-dev] [PATCH v2] " Matan Azrad
@ 2020-11-06 13:57   ` Ferruh Yigit
  2020-11-07 17:30     ` Matan Azrad
  2020-11-10 17:06   ` [dpdk-dev] [PATCH v3] " Matan Azrad
  1 sibling, 1 reply; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-06 13:57 UTC (permalink / raw)
  To: Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

On 11/5/2020 9:32 PM, Matan Azrad wrote:
> When an age action becomes aged-out the rte_flow_get_aged_flows should
> return the action context supplied by the configuration structure.
> 
> In case the age action created by the shared action API, the shared
> action context of the Testpmd application was not set.
> 
> In addition, the application handler of the contexts returned by the
> rte_flow_get_aged_flows API didn't consider the fact that the action
> could be set by the shared action API and considered it as regular flow
> context.
> 
> This caused a crash in Testpmd when the context is parsed.
> 
> This patch set context type in the flow and shared action context and
> uses it to parse the aged-out contexts correctly.
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Dekel Peled <dekelp@nvidia.com>
> ---
>   app/test-pmd/config.c  | 119 ++++++++++++++++++++++++++++++++++---------------
>   app/test-pmd/testpmd.h |   5 +++
>   2 files changed, 87 insertions(+), 37 deletions(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 755d1df..00a7dd1 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
>   	}
>   }
>   
> +#define AGE_ACTION_TYPE_MASK 0x3u
> +
> +static void
> +set_age_action_context(void **ctx, enum action_age_context_type type, void *obj)
> +{
> +	uintptr_t value = (uintptr_t)obj;
> +
> +	/*
> +	 * obj is allocated by malloc\calloc which must return an address
> +	 * aligned to 8.
> +	 * Use the last 2 bits for the age context type.
> +	 */
> +	value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
> +	*ctx = (void *)value;

Thanks Matan, I think this is much clear. But I though the 'id' will be used, 
not the pointer itself, like "uintptr_t value = id | (type * MASK)"
OR the address pointer and type seems error prone, although you comment you rely 
on the alignment.
The testpmd usage also kind of sample usage for the applications, I am for not 
suggesting this for the user applications.

Reserving the two bit of the 'id' reduces the usable 'id' to 30 bits, but it 
looks still big enough, what do you think?

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-06 13:57   ` Ferruh Yigit
@ 2020-11-07 17:30     ` Matan Azrad
  2020-11-09 10:21       ` Ferruh Yigit
  0 siblings, 1 reply; 17+ messages in thread
From: Matan Azrad @ 2020-11-07 17:30 UTC (permalink / raw)
  To: Ferruh Yigit, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

Hi Ferruh

From: Ferruh Yigit
> On 11/5/2020 9:32 PM, Matan Azrad wrote:
> > When an age action becomes aged-out the rte_flow_get_aged_flows should
> > return the action context supplied by the configuration structure.
> >
> > In case the age action created by the shared action API, the shared
> > action context of the Testpmd application was not set.
> >
> > In addition, the application handler of the contexts returned by the
> > rte_flow_get_aged_flows API didn't consider the fact that the action
> > could be set by the shared action API and considered it as regular
> > flow context.
> >
> > This caused a crash in Testpmd when the context is parsed.
> >
> > This patch set context type in the flow and shared action context and
> > uses it to parse the aged-out contexts correctly.
> >
> > Signed-off-by: Matan Azrad <matan@nvidia.com>
> > Acked-by: Dekel Peled <dekelp@nvidia.com>
> > ---
> >   app/test-pmd/config.c  | 119 ++++++++++++++++++++++++++++++++++-------
> --------
> >   app/test-pmd/testpmd.h |   5 +++
> >   2 files changed, 87 insertions(+), 37 deletions(-)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > 755d1df..00a7dd1 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t port_id,
> const struct tunnel_ops *ops)
> >       }
> >   }
> >
> > +#define AGE_ACTION_TYPE_MASK 0x3u
> > +
> > +static void
> > +set_age_action_context(void **ctx, enum action_age_context_type type,
> > +void *obj) {
> > +     uintptr_t value = (uintptr_t)obj;
> > +
> > +     /*
> > +      * obj is allocated by malloc\calloc which must return an address
> > +      * aligned to 8.
> > +      * Use the last 2 bits for the age context type.
> > +      */
> > +     value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
> > +     *ctx = (void *)value;
> 
> Thanks Matan, I think this is much clear. But I though the 'id' will be used, not
> the pointer itself, like "uintptr_t value = id | (type * MASK)"
> OR the address pointer and type seems error prone, although you comment
> you rely on the alignment.

I understand your concern, that's why the context value management is wrapped well by dedicated functions for set and parse.
Also it's very optimized way for memory and time especially when we are talking about big scale(see below).

> The testpmd usage also kind of sample usage for the applications, I am for not
> suggesting this for the user applications.


> Reserving the two bit of the 'id' reduces the usable 'id' to 30 bits, but it looks
> still big enough, what do you think?


Yes, it is big enough.
The problem with the id is the latency to get the pointer from it.
Since both the flows and the shared actions are saved in a list we need to traverse all the list in order to get the pointer and the needed information.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-07 17:30     ` Matan Azrad
@ 2020-11-09 10:21       ` Ferruh Yigit
  2020-11-09 10:38         ` Matan Azrad
  0 siblings, 1 reply; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-09 10:21 UTC (permalink / raw)
  To: Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

On 11/7/2020 5:30 PM, Matan Azrad wrote:
> Hi Ferruh
> 
> From: Ferruh Yigit
>> On 11/5/2020 9:32 PM, Matan Azrad wrote:
>>> When an age action becomes aged-out the rte_flow_get_aged_flows should
>>> return the action context supplied by the configuration structure.
>>>
>>> In case the age action created by the shared action API, the shared
>>> action context of the Testpmd application was not set.
>>>
>>> In addition, the application handler of the contexts returned by the
>>> rte_flow_get_aged_flows API didn't consider the fact that the action
>>> could be set by the shared action API and considered it as regular
>>> flow context.
>>>
>>> This caused a crash in Testpmd when the context is parsed.
>>>
>>> This patch set context type in the flow and shared action context and
>>> uses it to parse the aged-out contexts correctly.
>>>
>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
>>> Acked-by: Dekel Peled <dekelp@nvidia.com>
>>> ---
>>>    app/test-pmd/config.c  | 119 ++++++++++++++++++++++++++++++++++-------
>> --------
>>>    app/test-pmd/testpmd.h |   5 +++
>>>    2 files changed, 87 insertions(+), 37 deletions(-)
>>>
>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>>> 755d1df..00a7dd1 100644
>>> --- a/app/test-pmd/config.c
>>> +++ b/app/test-pmd/config.c
>>> @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t port_id,
>> const struct tunnel_ops *ops)
>>>        }
>>>    }
>>>
>>> +#define AGE_ACTION_TYPE_MASK 0x3u
>>> +
>>> +static void
>>> +set_age_action_context(void **ctx, enum action_age_context_type type,
>>> +void *obj) {
>>> +     uintptr_t value = (uintptr_t)obj;
>>> +
>>> +     /*
>>> +      * obj is allocated by malloc\calloc which must return an address
>>> +      * aligned to 8.
>>> +      * Use the last 2 bits for the age context type.
>>> +      */
>>> +     value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
>>> +     *ctx = (void *)value;
>>
>> Thanks Matan, I think this is much clear. But I though the 'id' will be used, not
>> the pointer itself, like "uintptr_t value = id | (type * MASK)"
>> OR the address pointer and type seems error prone, although you comment
>> you rely on the alignment.
> 
> I understand your concern, that's why the context value management is wrapped well by dedicated functions for set and parse.
> Also it's very optimized way for memory and time especially when we are talking about big scale(see below).
> 
>> The testpmd usage also kind of sample usage for the applications, I am for not
>> suggesting this for the user applications.
> 
> 
>> Reserving the two bit of the 'id' reduces the usable 'id' to 30 bits, but it looks
>> still big enough, what do you think?
> 
> 
> Yes, it is big enough.
> The problem with the id is the latency to get the pointer from it.
> Since both the flows and the shared actions are saved in a list we need to traverse all the list in order to get the pointer and the needed information.
> 

Using 'id' was your idea.

OK, what about back to previous suggestion, adding a new data struct for both 
pointers and type?
Your concern there was the memory consumption, yes although it will require more 
memory the amount is not unreasonable.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-09 10:21       ` Ferruh Yigit
@ 2020-11-09 10:38         ` Matan Azrad
  2020-11-09 11:12           ` Ferruh Yigit
  0 siblings, 1 reply; 17+ messages in thread
From: Matan Azrad @ 2020-11-09 10:38 UTC (permalink / raw)
  To: Ferruh Yigit, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev



From: Ferruh Yigit
> On 11/7/2020 5:30 PM, Matan Azrad wrote:
> > Hi Ferruh
> >
> > From: Ferruh Yigit
> >> On 11/5/2020 9:32 PM, Matan Azrad wrote:
> >>> When an age action becomes aged-out the rte_flow_get_aged_flows
> >>> should return the action context supplied by the configuration structure.
> >>>
> >>> In case the age action created by the shared action API, the shared
> >>> action context of the Testpmd application was not set.
> >>>
> >>> In addition, the application handler of the contexts returned by the
> >>> rte_flow_get_aged_flows API didn't consider the fact that the action
> >>> could be set by the shared action API and considered it as regular
> >>> flow context.
> >>>
> >>> This caused a crash in Testpmd when the context is parsed.
> >>>
> >>> This patch set context type in the flow and shared action context
> >>> and uses it to parse the aged-out contexts correctly.
> >>>
> >>> Signed-off-by: Matan Azrad <matan@nvidia.com>
> >>> Acked-by: Dekel Peled <dekelp@nvidia.com>
> >>> ---
> >>>    app/test-pmd/config.c  | 119
> >>> ++++++++++++++++++++++++++++++++++-------
> >> --------
> >>>    app/test-pmd/testpmd.h |   5 +++
> >>>    2 files changed, 87 insertions(+), 37 deletions(-)
> >>>
> >>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> >>> 755d1df..00a7dd1 100644
> >>> --- a/app/test-pmd/config.c
> >>> +++ b/app/test-pmd/config.c
> >>> @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t
> >>> port_id,
> >> const struct tunnel_ops *ops)
> >>>        }
> >>>    }
> >>>
> >>> +#define AGE_ACTION_TYPE_MASK 0x3u
> >>> +
> >>> +static void
> >>> +set_age_action_context(void **ctx, enum action_age_context_type
> >>> +type, void *obj) {
> >>> +     uintptr_t value = (uintptr_t)obj;
> >>> +
> >>> +     /*
> >>> +      * obj is allocated by malloc\calloc which must return an address
> >>> +      * aligned to 8.
> >>> +      * Use the last 2 bits for the age context type.
> >>> +      */
> >>> +     value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
> >>> +     *ctx = (void *)value;
> >>
> >> Thanks Matan, I think this is much clear. But I though the 'id' will
> >> be used, not the pointer itself, like "uintptr_t value = id | (type * MASK)"
> >> OR the address pointer and type seems error prone, although you
> >> comment you rely on the alignment.
> >
> > I understand your concern, that's why the context value management is
> wrapped well by dedicated functions for set and parse.
> > Also it's very optimized way for memory and time especially when we are
> talking about big scale(see below).
> >
> >> The testpmd usage also kind of sample usage for the applications, I
> >> am for not suggesting this for the user applications.
> >
> >
> >> Reserving the two bit of the 'id' reduces the usable 'id' to 30 bits,
> >> but it looks still big enough, what do you think?
> >
> >
> > Yes, it is big enough.
> > The problem with the id is the latency to get the pointer from it.
> > Since both the flows and the shared actions are saved in a list we need to
> traverse all the list in order to get the pointer and the needed information.
> >
> 
> Using 'id' was your idea.

Yes, Now I suggest even better one 😊

> 
> OK, what about back to previous suggestion, adding a new data struct for both
> pointers and type?
> Your concern there was the memory consumption, yes although it will require
> more memory the amount is not unreasonable.

Think about big scale.
It is not only memory (malloc overhead + ~16B) but also time consuming(malloc).

If we have solution that no need malloc and can do things faster, why not to take it?
I don't see here a bug - malloc alignment is a known topic - it should be at least the size of the biggest primitive type.

Matan 
 


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-09 10:38         ` Matan Azrad
@ 2020-11-09 11:12           ` Ferruh Yigit
  2020-11-10  8:30             ` Ori Kam
  0 siblings, 1 reply; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-09 11:12 UTC (permalink / raw)
  To: Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

On 11/9/2020 10:38 AM, Matan Azrad wrote:
> 
> 
> From: Ferruh Yigit
>> On 11/7/2020 5:30 PM, Matan Azrad wrote:
>>> Hi Ferruh
>>>
>>> From: Ferruh Yigit
>>>> On 11/5/2020 9:32 PM, Matan Azrad wrote:
>>>>> When an age action becomes aged-out the rte_flow_get_aged_flows
>>>>> should return the action context supplied by the configuration structure.
>>>>>
>>>>> In case the age action created by the shared action API, the shared
>>>>> action context of the Testpmd application was not set.
>>>>>
>>>>> In addition, the application handler of the contexts returned by the
>>>>> rte_flow_get_aged_flows API didn't consider the fact that the action
>>>>> could be set by the shared action API and considered it as regular
>>>>> flow context.
>>>>>
>>>>> This caused a crash in Testpmd when the context is parsed.
>>>>>
>>>>> This patch set context type in the flow and shared action context
>>>>> and uses it to parse the aged-out contexts correctly.
>>>>>
>>>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
>>>>> Acked-by: Dekel Peled <dekelp@nvidia.com>
>>>>> ---
>>>>>     app/test-pmd/config.c  | 119
>>>>> ++++++++++++++++++++++++++++++++++-------
>>>> --------
>>>>>     app/test-pmd/testpmd.h |   5 +++
>>>>>     2 files changed, 87 insertions(+), 37 deletions(-)
>>>>>
>>>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>>>>> 755d1df..00a7dd1 100644
>>>>> --- a/app/test-pmd/config.c
>>>>> +++ b/app/test-pmd/config.c
>>>>> @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t
>>>>> port_id,
>>>> const struct tunnel_ops *ops)
>>>>>         }
>>>>>     }
>>>>>
>>>>> +#define AGE_ACTION_TYPE_MASK 0x3u
>>>>> +
>>>>> +static void
>>>>> +set_age_action_context(void **ctx, enum action_age_context_type
>>>>> +type, void *obj) {
>>>>> +     uintptr_t value = (uintptr_t)obj;
>>>>> +
>>>>> +     /*
>>>>> +      * obj is allocated by malloc\calloc which must return an address
>>>>> +      * aligned to 8.
>>>>> +      * Use the last 2 bits for the age context type.
>>>>> +      */
>>>>> +     value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
>>>>> +     *ctx = (void *)value;
>>>>
>>>> Thanks Matan, I think this is much clear. But I though the 'id' will
>>>> be used, not the pointer itself, like "uintptr_t value = id | (type * MASK)"
>>>> OR the address pointer and type seems error prone, although you
>>>> comment you rely on the alignment.
>>>
>>> I understand your concern, that's why the context value management is
>> wrapped well by dedicated functions for set and parse.
>>> Also it's very optimized way for memory and time especially when we are
>> talking about big scale(see below).
>>>
>>>> The testpmd usage also kind of sample usage for the applications, I
>>>> am for not suggesting this for the user applications.
>>>
>>>
>>>> Reserving the two bit of the 'id' reduces the usable 'id' to 30 bits,
>>>> but it looks still big enough, what do you think?
>>>
>>>
>>> Yes, it is big enough.
>>> The problem with the id is the latency to get the pointer from it.
>>> Since both the flows and the shared actions are saved in a list we need to
>> traverse all the list in order to get the pointer and the needed information.
>>>
>>
>> Using 'id' was your idea.
> 
> Yes, Now I suggest even better one 😊
> 
>>
>> OK, what about back to previous suggestion, adding a new data struct for both
>> pointers and type?
>> Your concern there was the memory consumption, yes although it will require
>> more memory the amount is not unreasonable.
> 
> Think about big scale.
> It is not only memory (malloc overhead + ~16B) but also time consuming(malloc).
> 
> If we have solution that no need malloc and can do things faster, why not to take it?
> I don't see here a bug - malloc alignment is a known topic - it should be at least the size of the biggest primitive type.
> 

I can see there is a cost, either with malloc/free, or traverse the list to find 
'id', but updating memory pointer that you will use later to carry more metadata 
looks hack and error prone to me.

One can do these kind of tricks on their application, but for testpmd which is 
for testing and reference I didn't like the idea.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-09 11:12           ` Ferruh Yigit
@ 2020-11-10  8:30             ` Ori Kam
  2020-11-10  9:43               ` Ferruh Yigit
  0 siblings, 1 reply; 17+ messages in thread
From: Ori Kam @ 2020-11-10  8:30 UTC (permalink / raw)
  To: Ferruh Yigit, Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger; +Cc: dev

Hi,
Ferruh and Matan,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 9, 2020 1:13 PM
> To: Matan Azrad <matan@nvidia.com>; Wenzhuo Lu <wenzhuo.lu@intel.com>;
> Beilei Xing <beilei.xing@intel.com>; Bernard Iremonger
> <bernard.iremonger@intel.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] app/testpmd: support age shared action context
> 
> On 11/9/2020 10:38 AM, Matan Azrad wrote:
> >
> >
> > From: Ferruh Yigit
> >> On 11/7/2020 5:30 PM, Matan Azrad wrote:
> >>> Hi Ferruh
> >>>
> >>> From: Ferruh Yigit
> >>>> On 11/5/2020 9:32 PM, Matan Azrad wrote:
> >>>>> When an age action becomes aged-out the rte_flow_get_aged_flows
> >>>>> should return the action context supplied by the configuration structure.
> >>>>>
> >>>>> In case the age action created by the shared action API, the shared
> >>>>> action context of the Testpmd application was not set.
> >>>>>
> >>>>> In addition, the application handler of the contexts returned by the
> >>>>> rte_flow_get_aged_flows API didn't consider the fact that the action
> >>>>> could be set by the shared action API and considered it as regular
> >>>>> flow context.
> >>>>>
> >>>>> This caused a crash in Testpmd when the context is parsed.
> >>>>>
> >>>>> This patch set context type in the flow and shared action context
> >>>>> and uses it to parse the aged-out contexts correctly.
> >>>>>
> >>>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
> >>>>> Acked-by: Dekel Peled <dekelp@nvidia.com>
> >>>>> ---
> >>>>>     app/test-pmd/config.c  | 119
> >>>>> ++++++++++++++++++++++++++++++++++-------
> >>>> --------
> >>>>>     app/test-pmd/testpmd.h |   5 +++
> >>>>>     2 files changed, 87 insertions(+), 37 deletions(-)
> >>>>>
> >>>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> >>>>> 755d1df..00a7dd1 100644
> >>>>> --- a/app/test-pmd/config.c
> >>>>> +++ b/app/test-pmd/config.c
> >>>>> @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t
> >>>>> port_id,
> >>>> const struct tunnel_ops *ops)
> >>>>>         }
> >>>>>     }
> >>>>>
> >>>>> +#define AGE_ACTION_TYPE_MASK 0x3u
> >>>>> +
> >>>>> +static void
> >>>>> +set_age_action_context(void **ctx, enum action_age_context_type
> >>>>> +type, void *obj) {
> >>>>> +     uintptr_t value = (uintptr_t)obj;
> >>>>> +
> >>>>> +     /*
> >>>>> +      * obj is allocated by malloc\calloc which must return an address
> >>>>> +      * aligned to 8.
> >>>>> +      * Use the last 2 bits for the age context type.
> >>>>> +      */
> >>>>> +     value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
> >>>>> +     *ctx = (void *)value;
> >>>>
> >>>> Thanks Matan, I think this is much clear. But I though the 'id' will
> >>>> be used, not the pointer itself, like "uintptr_t value = id | (type * MASK)"
> >>>> OR the address pointer and type seems error prone, although you
> >>>> comment you rely on the alignment.
> >>>
> >>> I understand your concern, that's why the context value management is
> >> wrapped well by dedicated functions for set and parse.
> >>> Also it's very optimized way for memory and time especially when we are
> >> talking about big scale(see below).
> >>>
> >>>> The testpmd usage also kind of sample usage for the applications, I
> >>>> am for not suggesting this for the user applications.
> >>>
> >>>
> >>>> Reserving the two bit of the 'id' reduces the usable 'id' to 30 bits,
> >>>> but it looks still big enough, what do you think?
> >>>
> >>>
> >>> Yes, it is big enough.
> >>> The problem with the id is the latency to get the pointer from it.
> >>> Since both the flows and the shared actions are saved in a list we need to
> >> traverse all the list in order to get the pointer and the needed information.
> >>>
> >>
> >> Using 'id' was your idea.
> >
> > Yes, Now I suggest even better one 😊
> >
> >>
> >> OK, what about back to previous suggestion, adding a new data struct for
> both
> >> pointers and type?
> >> Your concern there was the memory consumption, yes although it will
> require
> >> more memory the amount is not unreasonable.
> >
> > Think about big scale.
> > It is not only memory (malloc overhead + ~16B) but also time
> consuming(malloc).
> >
> > If we have solution that no need malloc and can do things faster, why not to
> take it?
> > I don't see here a bug - malloc alignment is a known topic - it should be at
> least the size of the biggest primitive type.
> >
> 
> I can see there is a cost, either with malloc/free, or traverse the list to find
> 'id', but updating memory pointer that you will use later to carry more
> metadata
> looks hack and error prone to me.
> 
> One can do these kind of tricks on their application, but for testpmd which is
> for testing and reference I didn't like the idea.

I know I'm jumping a bit late, I have a different suggestion. 
What about creating new struct
Struct context_type {
	uint8_t type; /**< holds the type of the context can be enum. */
}
This struct should be added to both shared context and flow.
When adding context to the aging action we add the pointer to this struct.

Then when getting the context pointer we cast it to struct context_type,
get the value, and based on the type we use parentof function to get to the
pointer of the original structure.

The advantages:
1. Just adding one uint8_t to each struct. (not wasting space).
2. Very fast lookup since we just add if on the type and then
use parentof.
3. No major changes in structs.
4. Not an hack.
5. save extra allocation.
6. can be expended to support future types.

What do you think?

Best,
Ori


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-10  8:30             ` Ori Kam
@ 2020-11-10  9:43               ` Ferruh Yigit
  2020-11-10 10:58                 ` Matan Azrad
  0 siblings, 1 reply; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-10  9:43 UTC (permalink / raw)
  To: Ori Kam, Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger; +Cc: dev

On 11/10/2020 8:30 AM, Ori Kam wrote:
> Hi,
> Ferruh and Matan,
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, November 9, 2020 1:13 PM
>> To: Matan Azrad <matan@nvidia.com>; Wenzhuo Lu <wenzhuo.lu@intel.com>;
>> Beilei Xing <beilei.xing@intel.com>; Bernard Iremonger
>> <bernard.iremonger@intel.com>; Ori Kam <orika@nvidia.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [PATCH v2] app/testpmd: support age shared action context
>>
>> On 11/9/2020 10:38 AM, Matan Azrad wrote:
>>>
>>>
>>> From: Ferruh Yigit
>>>> On 11/7/2020 5:30 PM, Matan Azrad wrote:
>>>>> Hi Ferruh
>>>>>
>>>>> From: Ferruh Yigit
>>>>>> On 11/5/2020 9:32 PM, Matan Azrad wrote:
>>>>>>> When an age action becomes aged-out the rte_flow_get_aged_flows
>>>>>>> should return the action context supplied by the configuration structure.
>>>>>>>
>>>>>>> In case the age action created by the shared action API, the shared
>>>>>>> action context of the Testpmd application was not set.
>>>>>>>
>>>>>>> In addition, the application handler of the contexts returned by the
>>>>>>> rte_flow_get_aged_flows API didn't consider the fact that the action
>>>>>>> could be set by the shared action API and considered it as regular
>>>>>>> flow context.
>>>>>>>
>>>>>>> This caused a crash in Testpmd when the context is parsed.
>>>>>>>
>>>>>>> This patch set context type in the flow and shared action context
>>>>>>> and uses it to parse the aged-out contexts correctly.
>>>>>>>
>>>>>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
>>>>>>> Acked-by: Dekel Peled <dekelp@nvidia.com>
>>>>>>> ---
>>>>>>>      app/test-pmd/config.c  | 119
>>>>>>> ++++++++++++++++++++++++++++++++++-------
>>>>>> --------
>>>>>>>      app/test-pmd/testpmd.h |   5 +++
>>>>>>>      2 files changed, 87 insertions(+), 37 deletions(-)
>>>>>>>
>>>>>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>>>>>>> 755d1df..00a7dd1 100644
>>>>>>> --- a/app/test-pmd/config.c
>>>>>>> +++ b/app/test-pmd/config.c
>>>>>>> @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t
>>>>>>> port_id,
>>>>>> const struct tunnel_ops *ops)
>>>>>>>          }
>>>>>>>      }
>>>>>>>
>>>>>>> +#define AGE_ACTION_TYPE_MASK 0x3u
>>>>>>> +
>>>>>>> +static void
>>>>>>> +set_age_action_context(void **ctx, enum action_age_context_type
>>>>>>> +type, void *obj) {
>>>>>>> +     uintptr_t value = (uintptr_t)obj;
>>>>>>> +
>>>>>>> +     /*
>>>>>>> +      * obj is allocated by malloc\calloc which must return an address
>>>>>>> +      * aligned to 8.
>>>>>>> +      * Use the last 2 bits for the age context type.
>>>>>>> +      */
>>>>>>> +     value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
>>>>>>> +     *ctx = (void *)value;
>>>>>>
>>>>>> Thanks Matan, I think this is much clear. But I though the 'id' will
>>>>>> be used, not the pointer itself, like "uintptr_t value = id | (type * MASK)"
>>>>>> OR the address pointer and type seems error prone, although you
>>>>>> comment you rely on the alignment.
>>>>>
>>>>> I understand your concern, that's why the context value management is
>>>> wrapped well by dedicated functions for set and parse.
>>>>> Also it's very optimized way for memory and time especially when we are
>>>> talking about big scale(see below).
>>>>>
>>>>>> The testpmd usage also kind of sample usage for the applications, I
>>>>>> am for not suggesting this for the user applications.
>>>>>
>>>>>
>>>>>> Reserving the two bit of the 'id' reduces the usable 'id' to 30 bits,
>>>>>> but it looks still big enough, what do you think?
>>>>>
>>>>>
>>>>> Yes, it is big enough.
>>>>> The problem with the id is the latency to get the pointer from it.
>>>>> Since both the flows and the shared actions are saved in a list we need to
>>>> traverse all the list in order to get the pointer and the needed information.
>>>>>
>>>>
>>>> Using 'id' was your idea.
>>>
>>> Yes, Now I suggest even better one 😊
>>>
>>>>
>>>> OK, what about back to previous suggestion, adding a new data struct for
>> both
>>>> pointers and type?
>>>> Your concern there was the memory consumption, yes although it will
>> require
>>>> more memory the amount is not unreasonable.
>>>
>>> Think about big scale.
>>> It is not only memory (malloc overhead + ~16B) but also time
>> consuming(malloc).
>>>
>>> If we have solution that no need malloc and can do things faster, why not to
>> take it?
>>> I don't see here a bug - malloc alignment is a known topic - it should be at
>> least the size of the biggest primitive type.
>>>
>>
>> I can see there is a cost, either with malloc/free, or traverse the list to find
>> 'id', but updating memory pointer that you will use later to carry more
>> metadata
>> looks hack and error prone to me.
>>
>> One can do these kind of tricks on their application, but for testpmd which is
>> for testing and reference I didn't like the idea.
> 
> I know I'm jumping a bit late, I have a different suggestion.
> What about creating new struct
> Struct context_type {
> 	uint8_t type; /**< holds the type of the context can be enum. */
> }
> This struct should be added to both shared context and flow.
> When adding context to the aging action we add the pointer to this struct.
> 
> Then when getting the context pointer we cast it to struct context_type,
> get the value, and based on the type we use parentof function to get to the
> pointer of the original structure.
> 
> The advantages:
> 1. Just adding one uint8_t to each struct. (not wasting space).
> 2. Very fast lookup since we just add if on the type and then
> use parentof.
> 3. No major changes in structs.
> 4. Not an hack.
> 5. save extra allocation.
> 6. can be expended to support future types.
> 
> What do you think?
> 

Hi Ori, Matan,

Looks good to me, this is more like first version of the patch but with 
'parentof' usage it is safer I think.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context
  2020-11-10  9:43               ` Ferruh Yigit
@ 2020-11-10 10:58                 ` Matan Azrad
  0 siblings, 0 replies; 17+ messages in thread
From: Matan Azrad @ 2020-11-10 10:58 UTC (permalink / raw)
  To: Ferruh Yigit, Ori Kam, Wenzhuo Lu, Beilei Xing, Bernard Iremonger; +Cc: dev



From: Ferruh Yigit
> On 11/10/2020 8:30 AM, Ori Kam wrote:
> > Hi,
> > Ferruh and Matan,
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Sent: Monday, November 9, 2020 1:13 PM
> >> To: Matan Azrad <matan@nvidia.com>; Wenzhuo Lu
> >> <wenzhuo.lu@intel.com>; Beilei Xing <beilei.xing@intel.com>; Bernard
> >> Iremonger <bernard.iremonger@intel.com>; Ori Kam <orika@nvidia.com>
> >> Cc: dev@dpdk.org
> >> Subject: Re: [PATCH v2] app/testpmd: support age shared action
> >> context
> >>
> >> On 11/9/2020 10:38 AM, Matan Azrad wrote:
> >>>
> >>>
> >>> From: Ferruh Yigit
> >>>> On 11/7/2020 5:30 PM, Matan Azrad wrote:
> >>>>> Hi Ferruh
> >>>>>
> >>>>> From: Ferruh Yigit
> >>>>>> On 11/5/2020 9:32 PM, Matan Azrad wrote:
> >>>>>>> When an age action becomes aged-out the rte_flow_get_aged_flows
> >>>>>>> should return the action context supplied by the configuration
> structure.
> >>>>>>>
> >>>>>>> In case the age action created by the shared action API, the
> >>>>>>> shared action context of the Testpmd application was not set.
> >>>>>>>
> >>>>>>> In addition, the application handler of the contexts returned by
> >>>>>>> the rte_flow_get_aged_flows API didn't consider the fact that
> >>>>>>> the action could be set by the shared action API and considered
> >>>>>>> it as regular flow context.
> >>>>>>>
> >>>>>>> This caused a crash in Testpmd when the context is parsed.
> >>>>>>>
> >>>>>>> This patch set context type in the flow and shared action
> >>>>>>> context and uses it to parse the aged-out contexts correctly.
> >>>>>>>
> >>>>>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
> >>>>>>> Acked-by: Dekel Peled <dekelp@nvidia.com>
> >>>>>>> ---
> >>>>>>>      app/test-pmd/config.c  | 119
> >>>>>>> ++++++++++++++++++++++++++++++++++-------
> >>>>>> --------
> >>>>>>>      app/test-pmd/testpmd.h |   5 +++
> >>>>>>>      2 files changed, 87 insertions(+), 37 deletions(-)
> >>>>>>>
> >>>>>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> >>>>>>> 755d1df..00a7dd1 100644
> >>>>>>> --- a/app/test-pmd/config.c
> >>>>>>> +++ b/app/test-pmd/config.c
> >>>>>>> @@ -1763,6 +1763,33 @@ void port_flow_tunnel_create(portid_t
> >>>>>>> port_id,
> >>>>>> const struct tunnel_ops *ops)
> >>>>>>>          }
> >>>>>>>      }
> >>>>>>>
> >>>>>>> +#define AGE_ACTION_TYPE_MASK 0x3u
> >>>>>>> +
> >>>>>>> +static void
> >>>>>>> +set_age_action_context(void **ctx, enum action_age_context_type
> >>>>>>> +type, void *obj) {
> >>>>>>> +     uintptr_t value = (uintptr_t)obj;
> >>>>>>> +
> >>>>>>> +     /*
> >>>>>>> +      * obj is allocated by malloc\calloc which must return an address
> >>>>>>> +      * aligned to 8.
> >>>>>>> +      * Use the last 2 bits for the age context type.
> >>>>>>> +      */
> >>>>>>> +     value |= (uintptr_t)type & AGE_ACTION_TYPE_MASK;
> >>>>>>> +     *ctx = (void *)value;
> >>>>>>
> >>>>>> Thanks Matan, I think this is much clear. But I though the 'id'
> >>>>>> will be used, not the pointer itself, like "uintptr_t value = id | (type *
> MASK)"
> >>>>>> OR the address pointer and type seems error prone, although you
> >>>>>> comment you rely on the alignment.
> >>>>>
> >>>>> I understand your concern, that's why the context value management
> >>>>> is
> >>>> wrapped well by dedicated functions for set and parse.
> >>>>> Also it's very optimized way for memory and time especially when
> >>>>> we are
> >>>> talking about big scale(see below).
> >>>>>
> >>>>>> The testpmd usage also kind of sample usage for the applications,
> >>>>>> I am for not suggesting this for the user applications.
> >>>>>
> >>>>>
> >>>>>> Reserving the two bit of the 'id' reduces the usable 'id' to 30
> >>>>>> bits, but it looks still big enough, what do you think?
> >>>>>
> >>>>>
> >>>>> Yes, it is big enough.
> >>>>> The problem with the id is the latency to get the pointer from it.
> >>>>> Since both the flows and the shared actions are saved in a list we
> >>>>> need to
> >>>> traverse all the list in order to get the pointer and the needed
> information.
> >>>>>
> >>>>
> >>>> Using 'id' was your idea.
> >>>
> >>> Yes, Now I suggest even better one 😊
> >>>
> >>>>
> >>>> OK, what about back to previous suggestion, adding a new data
> >>>> struct for
> >> both
> >>>> pointers and type?
> >>>> Your concern there was the memory consumption, yes although it will
> >> require
> >>>> more memory the amount is not unreasonable.
> >>>
> >>> Think about big scale.
> >>> It is not only memory (malloc overhead + ~16B) but also time
> >> consuming(malloc).
> >>>
> >>> If we have solution that no need malloc and can do things faster,
> >>> why not to
> >> take it?
> >>> I don't see here a bug - malloc alignment is a known topic - it
> >>> should be at
> >> least the size of the biggest primitive type.
> >>>
> >>
> >> I can see there is a cost, either with malloc/free, or traverse the
> >> list to find 'id', but updating memory pointer that you will use
> >> later to carry more metadata looks hack and error prone to me.
> >>
> >> One can do these kind of tricks on their application, but for testpmd
> >> which is for testing and reference I didn't like the idea.
> >
> > I know I'm jumping a bit late, I have a different suggestion.
> > What about creating new struct
> > Struct context_type {
> >       uint8_t type; /**< holds the type of the context can be enum. */
> > } This struct should be added to both shared context and flow.
> > When adding context to the aging action we add the pointer to this struct.
> >
> > Then when getting the context pointer we cast it to struct
> > context_type, get the value, and based on the type we use parentof
> > function to get to the pointer of the original structure.
> >
> > The advantages:
> > 1. Just adding one uint8_t to each struct. (not wasting space).
> > 2. Very fast lookup since we just add if on the type and then use
> > parentof.
> > 3. No major changes in structs.
> > 4. Not an hack.
> > 5. save extra allocation.
> > 6. can be expended to support future types.
> >
> > What do you think?
> >
> 
> Hi Ori, Matan,
> 
> Looks good to me, this is more like first version of the patch but with 'parentof'
> usage it is safer I think.

Ok, will send v3 soon.
Thanks Ferruh and Ori


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [dpdk-dev] [PATCH v3] app/testpmd: support age shared action context
  2020-11-05 21:32 ` [dpdk-dev] [PATCH v2] " Matan Azrad
  2020-11-06 13:57   ` Ferruh Yigit
@ 2020-11-10 17:06   ` Matan Azrad
  2020-11-11 12:51     ` Ferruh Yigit
  1 sibling, 1 reply; 17+ messages in thread
From: Matan Azrad @ 2020-11-10 17:06 UTC (permalink / raw)
  To: Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev, Ferruh Yigit

When an age action becomes aged-out the next call for
rte_flow_get_aged_flows API should return the action context supplied
by the action configuration structure.

In case the age action is created by the shared action API, the shared
action context of the Testpmd application was not set.

In addition, the application handler of the contexts returned by the
rte_flow_get_aged_flows API didn't consider the fact that the action
could be set by the shared action API and considered it as regular flow
context.

This caused a crash in Testpmd when the context is parsed.

This patch set context type in the flow and shared action context and
uses it to parse the aged-out contexts correctly.

Signed-off-by: Matan Azrad <matan@nvidia.com>
Acked-by: Dekel Peled <dekelp@nvidia.com>
---

v3:
update age context to point to the context type field inside the context structures.

 app/test-pmd/config.c  | 89 +++++++++++++++++++++++++++++---------------------
 app/test-pmd/testpmd.h | 13 +++++++-
 2 files changed, 64 insertions(+), 38 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 755d1df..91e7542 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1849,6 +1849,13 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
 	ret = action_alloc(port_id, id, &psa);
 	if (ret)
 		return ret;
+	if (action->type == RTE_FLOW_ACTION_TYPE_AGE) {
+		struct rte_flow_action_age *age =
+			(struct rte_flow_action_age *)(uintptr_t)(action->conf);
+
+		psa->age_type = ACTION_AGE_CONTEXT_TYPE_SHARED_ACTION;
+		age->context = &psa->age_type;
+	}
 	/* Poisoning to make sure PMDs update it in case of error. */
 	memset(&error, 0x22, sizeof(error));
 	psa->action = rte_flow_shared_action_create(port_id, conf, action,
@@ -1900,8 +1907,8 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops)
 				continue;
 			}
 			*tmp = psa->next;
-			free(psa);
 			printf("Shared action #%u destroyed\n", psa->id);
+			free(psa);
 			break;
 		}
 		if (i == n)
@@ -2113,24 +2120,20 @@ struct rte_flow_shared_action *
 	return 0;
 }
 
-/** Update age action context by port_flow pointer. */
-void
-update_age_action_context(const struct rte_flow_action *actions,
-			struct port_flow *pf)
+/** Return age action structure if exists, otherwise NULL. */
+static struct rte_flow_action_age *
+age_action_get(const struct rte_flow_action *actions)
 {
-	struct rte_flow_action_age *age = NULL;
-
 	for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
 		switch (actions->type) {
 		case RTE_FLOW_ACTION_TYPE_AGE:
-			age = (struct rte_flow_action_age *)
+			return (struct rte_flow_action_age *)
 				(uintptr_t)actions->conf;
-			age->context = pf;
-			return;
 		default:
 			break;
 		}
 	}
+	return NULL;
 }
 
 /** Create flow rule. */
@@ -2147,6 +2150,7 @@ struct rte_flow_shared_action *
 	uint32_t id = 0;
 	struct rte_flow_error error;
 	struct port_flow_tunnel *pft = NULL;
+	struct rte_flow_action_age *age = age_action_get(actions);
 
 	port = &ports[port_id];
 	if (port->flow_list) {
@@ -2170,7 +2174,10 @@ struct rte_flow_shared_action *
 	pf = port_flow_new(attr, pattern, actions, &error);
 	if (!pf)
 		return port_flow_complain(&error);
-	update_age_action_context(actions, pf);
+	if (age) {
+		pf->age_type = ACTION_AGE_CONTEXT_TYPE_FLOW;
+		age->context = &pf->age_type;
+	}
 	/* Poisoning to make sure PMDs update it in case of error. */
 	memset(&error, 0x22, sizeof(error));
 	flow = rte_flow_create(port_id, attr, pattern, actions, &error);
@@ -2379,7 +2386,11 @@ struct rte_flow_shared_action *
 	void **contexts;
 	int nb_context, total = 0, idx;
 	struct rte_flow_error error;
-	struct port_flow *pf;
+	enum age_action_context_type *type;
+	union {
+		struct port_flow *pf;
+		struct port_shared_action *psa;
+	} ctx;
 
 	if (port_id_is_invalid(port_id, ENABLED_WARN) ||
 	    port_id == (portid_t)RTE_PORT_ALL)
@@ -2397,7 +2408,7 @@ struct rte_flow_shared_action *
 		printf("Cannot allocate contexts for aged flow\n");
 		return;
 	}
-	printf("ID\tGroup\tPrio\tAttr\n");
+	printf("%-20s\tID\tGroup\tPrio\tAttr\n", "Type");
 	nb_context = rte_flow_get_aged_flows(port_id, contexts, total, &error);
 	if (nb_context != total) {
 		printf("Port:%d get aged flows count(%d) != total(%d)\n",
@@ -2405,37 +2416,41 @@ struct rte_flow_shared_action *
 		free(contexts);
 		return;
 	}
+	total = 0;
 	for (idx = 0; idx < nb_context; idx++) {
-		pf = (struct port_flow *)contexts[idx];
-		if (!pf) {
+		if (!contexts[idx]) {
 			printf("Error: get Null context in port %u\n", port_id);
 			continue;
 		}
-		printf("%" PRIu32 "\t%" PRIu32 "\t%" PRIu32 "\t%c%c%c\t\n",
-		       pf->id,
-		       pf->rule.attr->group,
-		       pf->rule.attr->priority,
-		       pf->rule.attr->ingress ? 'i' : '-',
-		       pf->rule.attr->egress ? 'e' : '-',
-		       pf->rule.attr->transfer ? 't' : '-');
-	}
-	if (destroy) {
-		int ret;
-		uint32_t flow_id;
-
-		total = 0;
-		printf("\n");
-		for (idx = 0; idx < nb_context; idx++) {
-			pf = (struct port_flow *)contexts[idx];
-			if (!pf)
-				continue;
-			flow_id = pf->id;
-			ret = port_flow_destroy(port_id, 1, &flow_id);
-			if (!ret)
+		type = (enum age_action_context_type *)contexts[idx];
+		switch (*type) {
+		case ACTION_AGE_CONTEXT_TYPE_FLOW:
+			ctx.pf = container_of(type, struct port_flow, age_type);
+			printf("%-20s\t%" PRIu32 "\t%" PRIu32 "\t%" PRIu32
+								 "\t%c%c%c\t\n",
+			       "Flow",
+			       ctx.pf->id,
+			       ctx.pf->rule.attr->group,
+			       ctx.pf->rule.attr->priority,
+			       ctx.pf->rule.attr->ingress ? 'i' : '-',
+			       ctx.pf->rule.attr->egress ? 'e' : '-',
+			       ctx.pf->rule.attr->transfer ? 't' : '-');
+			if (destroy && !port_flow_destroy(port_id, 1,
+							  &ctx.pf->id))
 				total++;
+			break;
+		case ACTION_AGE_CONTEXT_TYPE_SHARED_ACTION:
+			ctx.psa = container_of(type, struct port_shared_action,
+					       age_type);
+			printf("%-20s\t%" PRIu32 "\n", "Shared action",
+			       ctx.psa->id);
+			break;
+		default:
+			printf("Error: invalid context type %u\n", port_id);
+			break;
 		}
-		printf("%d flows be destroyed\n", total);
 	}
+	printf("\n%d flows destroyed\n", total);
 	free(contexts);
 }
 
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 519d551..6b901a8 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -143,13 +143,23 @@ struct fwd_stream {
 	struct pkt_burst_stats tx_burst_stats;
 };
 
+/**
+ * Age action context types, must be included inside the age action
+ * context structure.
+ */
+enum age_action_context_type {
+	ACTION_AGE_CONTEXT_TYPE_FLOW,
+	ACTION_AGE_CONTEXT_TYPE_SHARED_ACTION,
+};
+
 /** Descriptor for a single flow. */
 struct port_flow {
 	struct port_flow *next; /**< Next flow in list. */
 	struct port_flow *tmp; /**< Temporary linking. */
 	uint32_t id; /**< Flow rule ID. */
 	struct rte_flow *flow; /**< Opaque flow object returned by PMD. */
-	struct rte_flow_conv_rule rule; /* Saved flow rule description. */
+	struct rte_flow_conv_rule rule; /**< Saved flow rule description. */
+	enum age_action_context_type age_type; /**< Age action context type. */
 	uint8_t data[]; /**< Storage for flow rule description */
 };
 
@@ -159,6 +169,7 @@ struct port_shared_action {
 	uint32_t id; /**< Shared action ID. */
 	enum rte_flow_action_type type; /**< Action type. */
 	struct rte_flow_shared_action *action;	/**< Shared action handle. */
+	enum age_action_context_type age_type; /**< Age action context type. */
 };
 
 struct port_flow_tunnel {
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v3] app/testpmd: support age shared action context
  2020-11-10 17:06   ` [dpdk-dev] [PATCH v3] " Matan Azrad
@ 2020-11-11 12:51     ` Ferruh Yigit
  0 siblings, 0 replies; 17+ messages in thread
From: Ferruh Yigit @ 2020-11-11 12:51 UTC (permalink / raw)
  To: Matan Azrad, Wenzhuo Lu, Beilei Xing, Bernard Iremonger, Ori Kam; +Cc: dev

On 11/10/2020 5:06 PM, Matan Azrad wrote:
> When an age action becomes aged-out the next call for
> rte_flow_get_aged_flows API should return the action context supplied
> by the action configuration structure.
> 
> In case the age action is created by the shared action API, the shared
> action context of the Testpmd application was not set.
> 
> In addition, the application handler of the contexts returned by the
> rte_flow_get_aged_flows API didn't consider the fact that the action
> could be set by the shared action API and considered it as regular flow
> context.
> 
> This caused a crash in Testpmd when the context is parsed.
> 
> This patch set context type in the flow and shared action context and
> uses it to parse the aged-out contexts correctly.
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Dekel Peled <dekelp@nvidia.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2020-11-11 12:52 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 17:48 [dpdk-dev] [PATCH] app/testpmd: support age shared action context Matan Azrad
2020-11-02 18:50 ` Ferruh Yigit
2020-11-03  7:33   ` Matan Azrad
2020-11-04 12:58     ` Ferruh Yigit
2020-11-04 13:28       ` Matan Azrad
2020-11-04 13:45         ` Ferruh Yigit
2020-11-05 21:32 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2020-11-06 13:57   ` Ferruh Yigit
2020-11-07 17:30     ` Matan Azrad
2020-11-09 10:21       ` Ferruh Yigit
2020-11-09 10:38         ` Matan Azrad
2020-11-09 11:12           ` Ferruh Yigit
2020-11-10  8:30             ` Ori Kam
2020-11-10  9:43               ` Ferruh Yigit
2020-11-10 10:58                 ` Matan Azrad
2020-11-10 17:06   ` [dpdk-dev] [PATCH v3] " Matan Azrad
2020-11-11 12:51     ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git