From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CD5DA0521; Tue, 3 Nov 2020 15:27:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30216CADA; Tue, 3 Nov 2020 15:27:45 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E47D5CACF for ; Tue, 3 Nov 2020 15:27:42 +0100 (CET) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.144]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 45161200CD; Tue, 3 Nov 2020 14:27:41 +0000 (UTC) Received: from us4-mdac16-5.at1.mdlocal (unknown [10.110.49.156]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 43198800A4; Tue, 3 Nov 2020 14:27:41 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.12]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C68CE40070; Tue, 3 Nov 2020 14:27:40 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 68AB84005B; Tue, 3 Nov 2020 14:27:40 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 3 Nov 2020 14:27:36 +0000 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 3 Nov 2020 14:27:36 +0000 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 0A3ERaic012280; Tue, 3 Nov 2020 14:27:36 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 2787B1613A9; Tue, 3 Nov 2020 14:27:36 +0000 (GMT) From: Andrew Rybchenko To: CC: Ori Kam , "Xueming(Steven) Li" , Slava Ovsiienko , Ray Kinsella , "Neil Horman" , Thomas Monjalon , "Ferruh Yigit" , Andrew Rybchenko Date: Tue, 3 Nov 2020 14:26:16 +0000 Message-ID: <1604413577-23607-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> References: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25764.003 X-TM-AS-Result: No-3.123700-8.000000-10 X-TMASE-MatchedRID: oN68cszm0PMx6i6qKNyVGiZm6wdY+F8KE3EgF0+MVuB8vx8dQICa64E3 pfk7XdNxRVWmp4RlJdFhIO83i6Qjym33Dw0gKiXJpFQot5BYq9OfM+smQZqWkIJMlS+kMGbc+F+ ZNDU3ANMp5/0TmYzWjTe+9YmuRpG7trQSlX9RxUWcVWc2a+/ju0tc8DbogbSE31GU/N5W5BCJPi Rk7PkoE4QmFySp4ySSlSed9T5Ihn4Ovl7WFhImCxRpL+ItWgLmHnW07AxOgT/HN9tnHHgXhKJFm bmfOdw3xh7hjtPvAHyrlA/106nDw8cZkgQUzAWimLEPJniueweCo8vMtMK/WeidIgHX2zHf0a8l U98SXUiFDekgydoeyV+wX0SqSP+3kfRhdidsajMURSScn+QSXgD6RpjqQGaF+gtHj7OwNO0e17F nX7/0+Sa62yPol4rmwy/puGTO7ZCk7yBg4gmLJt6JBxKzNmImJuLLCmdfXyLzCDFCRfSRYwG4e5 7b9AR6cHjvyh0uGqKrF7zvoEpMq9pAu0sLxpSoQ8G+yYJYYdZRZDsGiXQioL4jxKnHJRLcwL6Sx Ppr1/I= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.123700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25764.003 X-MDID: 1604413661-zyLkBC0-Iefo X-PPE-DISP: 1604413661;zyLkBC0-Iefo Subject: [dpdk-dev] [PATCH v2] ethdev: deprecate shared counters using action attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A new generic shared actions API may be used to create shared counter. There is no point to keep duplicate COUNT action specific capability to create shared counters. Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit --- Cc: Ori Kam Cc: Xueming(Steven) Li Cc: Slava Ovsiienko Right now it is suggested do not touch ID and keep it as is. Anyway we have plenty of time before 21.11 when it can be removed. However it is important to highlight the right direction for shared counters now. doc/guides/prog_guide/rte_flow.rst | 17 ++++++++++------- doc/guides/rel_notes/deprecation.rst | 4 ++++ lib/librte_ethdev/rte_flow.h | 6 +++++- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index ea203e0..64b533b 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -1724,17 +1724,20 @@ that counter. For ports within the same switch domain then the counter id namespace extends to all ports within that switch domain. +The shared flag is DEPRECATED and ``SHARED`` ``COUNT`` action should be used +to make shared counters. + .. _table_rte_flow_action_count: .. table:: COUNT - +------------+---------------------+ - | Field | Value | - +============+=====================+ - | ``shared`` | shared counter flag | - +------------+---------------------+ - | ``id`` | counter id | - +------------+---------------------+ + +------------+---------------------------------+ + | Field | Value | + +============+=================================+ + | ``shared`` | DEPRECATED, shared counter flag | + +------------+---------------------------------+ + | ``id`` | counter id | + +------------+---------------------------------+ Query structure to retrieve and reset flow rule counters: diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index c2d3457..7f3c2e7 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -122,6 +122,10 @@ Deprecation Notices will be limited to maximum 256 queues. Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. +* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count`` + is deprecated and will be removed in DPDK 21.11. Shared counters should + be managed using shared actions API (``rte_flow_shared_action_create`` etc). + * cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``, ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index a8eac4d..2bb93d2 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -2287,6 +2287,9 @@ struct rte_flow_query_age { * Counters can be retrieved and reset through ``rte_flow_query()``, see * ``struct rte_flow_query_count``. * + * @deprecated Shared attribute is deprecated, use generic + * RTE_FLOW_ACTION_TYPE_SHARED action. + * * The shared flag indicates whether the counter is unique to the flow rule the * action is specified with, or whether it is a shared counter. * @@ -2299,7 +2302,8 @@ struct rte_flow_query_age { * to all ports within that switch domain. */ struct rte_flow_action_count { - uint32_t shared:1; /**< Share counter ID with other flow rules. */ + /** @deprecated Share counter ID with other flow rules. */ + uint32_t shared:1; uint32_t reserved:31; /**< Reserved, must be zero. */ uint32_t id; /**< Counter ID. */ }; -- 1.8.3.1