From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id BF0863239 for ; Mon, 13 Jul 2015 13:04:34 +0200 (CEST) Received: by widic2 with SMTP id ic2so9039008wid.0 for ; Mon, 13 Jul 2015 04:04:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Qirpath92Q7qtivIwIki1MGhzqnT0TyRUxWNPmVysuQ=; b=mSL2xc/fTpywojoePIK70WoW/rYK6CSPEpMeY7s+vCaO36Wrd2pFA1OglCruNDF/2b FvEt3SEhMjVRKur8EZfxLwDwAH/ei+n1tL3JxD9OH0klT9v40+26wJm4hs9XyTldzfeH BcsLPKCSPhTDs8UecJwEqim56fHs5Pll0qMFFVG4ryzKlqdL4ixW4TDy1maDDV6Vh629 pbUhtvifY1cCamS5XxF/XQ9w8H4M3haHJWEqCJURpZ9eteodQatYLbAbu53I2FznECpr l+hnNCmcTNg1x/gxh1FtbEImUjimtT2lz/ZIYuU6nDj312JHFm0R+Px31uChpD2nSPud Ga4w== X-Gm-Message-State: ALoCoQng9bHr+UhGuWzNwZzFyKB4huIPfUVzIgnv7WehVpewA8pRsFnDv6cP/0RIPSkaaKxUD+Z8 X-Received: by 10.180.83.137 with SMTP id q9mr22779797wiy.68.1436785474605; Mon, 13 Jul 2015 04:04:34 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ex8sm28537551wjc.34.2015.07.13.04.04.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 04:04:33 -0700 (PDT) From: Thomas Monjalon To: Tomasz Kulasek Date: Mon, 13 Jul 2015 13:03:21 +0200 Message-ID: <1604538.YavAJG9xMg@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <5593BB53.2060204@intel.com> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <5593BB53.2060204@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/8] Dynamic RSS Configuration for Bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 11:04:35 -0000 2015-07-01 11:05, Declan Doherty: > On 29/06/15 15:50, Tomasz Kulasek wrote: > > OVERVIEW > > -------- > > 1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS makes bonding > > device fully RSS-capable, so all slaves are synchronized with its configuration. > > This mode is intended to provide RSS configuration as known from "dynamic RSS > > configuration for one port" and made slaves transparent for client application > > implementation. > > > > 2) If .rxmode.mq_mode for bonding device isn't ETH_MQ_RX_RSS, slaves are not > > synchronized. That provides an ability to configure them manually. This mode may > > be useful when application wants to manage RSS in an unusual way and the > > consistency of RSS configuration for slaves isn't required. > > > > Turning on/off RSS mode for slaves when bonding is started is not possible. > > Other RSS configuration is propagated over slaves, when bonding device API is > > used to do it. > > > > v3 changes: > > - checkpatch cleanups > ... > > Acked-by : Declan Doherty Applied without patches 5 and 6: - As discussed earlier, patch 5 workaround a missing flag to announce stats per queue availability. - Patch 6 introduce a new dependency (ncurses) to build a new bond_rss example. Examples are useful to show how to use some features. Maybe you can show bonding RSS in the existing bonding example without adding bells and whistles. The example directory must be kept reasonnably maintainable.