From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 75F5B2C60 for ; Sat, 27 Oct 2018 15:30:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6C715D06; Sat, 27 Oct 2018 09:29:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 27 Oct 2018 09:29:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=IhnYRnC6U+Y8m6IWAD+WGugIuuLDbdHdbj2/MQhPN/w=; b=b5dXxA7x/2Zt OOq9IiuKM5sID4PS3t4oXPAT0ILLFrhb36/Vm3k8SP6u+R7oIYzUN4ALmYIy0Jpn 4YyzeF5UY+ooFac4da3GE1b9Y/xMPo2E12k6rfEWMRFNfKzvZPFJnwxfttTDu9kU DkeyueUG757UOO5hT0deZAFJVi9P9wk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=IhnYRnC6U+Y8m6IWAD+WGugIuuLDbdHdbj2/MQhPN /w=; b=p1MOLwCTHj0s16jB/9yR52JgHircX2AwBVh2hNZGRlGfWUfwhMCUIXuga ebJ1b7Nk40/LyRfgCkP5+uUUYbyqAuAM7wjsSLRskHfYHN3BmfqCI0TaCKFm3Zd5 NY/nWiE5/kfsETbhuuxs3QzKfqg4+pNN4uLezuSAeb9mi7WU8SsjIpAsVXATFaGa 5fH0l8gYVLBVDi6i9F9b0IYxyLPwIq3whJnjNxoD15Xl43f11hRRVRDzsrO3/T26 p5Wo2s7geaMzQ6ZEij4tIN8dCzLlNkJrLeKT6sy/8daWyQsiHGqm8RYW00TVYg1+ fLHVq11Gl4dFMNKqPCxbgfj64EpZA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A2A9E43AC; Sat, 27 Oct 2018 09:29:56 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Sat, 27 Oct 2018 15:30:02 +0200 Message-ID: <16053628.QeqsbmsNmo@xps> In-Reply-To: References: <20181026184248.78908-1-ferruh.yigit@intel.com> <2054335.yDqyzkpi5h@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] buildtools: fix build for some mktemp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 13:30:00 -0000 27/10/2018 01:53, Ferruh Yigit: > On 10/27/2018 12:47 AM, Thomas Monjalon wrote: > > 27/10/2018 02:38, Ferruh Yigit: > >> build error: > >> == Build drivers/net/tap > >> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c: > >> Invalid argument > >> .../buildtools/auto-config-h.sh: line 86: : No such file or directory > >> .../drivers/net/tap/Makefile:55: recipe for target > >> 'tap_autoconf.h.new' failed > >> > >> Above error observed on Wind River Linux 8.0 > >> > >> `mktemp` command in that system has a restrictions to have X in > >> the template at the end and at least six of them. > >> > >> Complied to mktemp requirements and add -xc flag to compiler to say > >> `temp` file is a C file > >> > >> Fixes: ff37ca5d3773 ("devtools: use a common prefix for temporary files") > >> > >> Reported-by: Shuai Zhu > >> Signed-off-by: Ferruh Yigit > >> --- > >> v2: > >> * keep using mktemp, add -xc to compiler > >> --- > >> buildtools/auto-config-h.sh | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> --- a/buildtools/auto-config-h.sh > >> +++ b/buildtools/auto-config-h.sh > >> -temp=$(mktemp -t dpdk.${0##*/}.XXX.c) > >> +temp=$(mktemp -t dpdk.${0##*/}.c.XXXXXX) > > > > It looks OK for this script. > > > > Should we do the same kind of change for devtools/check-includes.sh? > > and devtools/cocci.sh? > > Not sure, this script is part of buildtool and required for build, so needs to > be compatible for various systems. Above are devtools and can use new mktemp. Applied, thanks