DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] devtools: restore null test
Date: Mon, 29 Jul 2019 14:15:50 +0200	[thread overview]
Message-ID: <1605746.aTWFI4qxfl@xps> (raw)
In-Reply-To: <CAJFAV8ya4jcCqjRepWmoxQHaDpkXWLLa07Om39S-qRaZys=oAg@mail.gmail.com>

29/07/2019 12:35, David Marchand:
> On Wed, Jul 17, 2019 at 5:53 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > --- a/devtools/test-null.sh
> > +++ b/devtools/test-null.sh
> > -if grep -q SHARED_LIB=y $build/.config; then
> > -       pmd='-d librte_pmd_null.so'
> > +testpmd=$build/app/dpdk-testpmd
> > +[ -f "$testpmd" ] || testpmd=$build/app/testpmd
> > +if [ ! -f "$testpmd" ] ; then
> 
> You don't really care that testpmd is a file, prefer -e.

Yes I care, I want to avoid finding a directory.

> > +       echo 'ERROR: testpmd cannot be found' >&2
> > +       exit 1
> > +fi
> > +
> > +unset libs
> 
> You reference it later, I suppose you meant libs=

I think "unset libs" is the standard syntax to initialize a variable
to an empty value.

> > +if ldd $testpmd | grep -q librte_ ; then
> > +       libs='-d librte_mempool_ring.so -d librte_pmd_null.so'
> >  fi




  reply	other threads:[~2019-07-29 12:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 11:20 [dpdk-dev] [PATCH] devtools: fix " Thomas Monjalon
2019-07-17 15:52 ` [dpdk-dev] [PATCH v2 1/2] devtools: restore " Thomas Monjalon
2019-07-17 15:52   ` [dpdk-dev] [PATCH v2 2/2] devtools: allow misc options in " Thomas Monjalon
2019-07-29 10:36     ` David Marchand
2019-07-29 12:19       ` Thomas Monjalon
2019-07-29 12:55         ` David Marchand
2019-07-29 10:35   ` [dpdk-dev] [PATCH v2 1/2] devtools: restore " David Marchand
2019-07-29 12:15     ` Thomas Monjalon [this message]
2019-07-29 12:53       ` David Marchand
2019-07-30 17:34 ` [dpdk-dev] [PATCH v3 " Thomas Monjalon
2019-07-30 17:34   ` [dpdk-dev] [PATCH v3 2/2] devtools: allow misc options in " Thomas Monjalon
2019-08-05 15:23     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1605746.aTWFI4qxfl@xps \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).