DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: make ethernet xstats names compliant
@ 2020-11-19 19:18 Viacheslav Ovsiienko
  2020-11-22 12:58 ` Raslan Darawsheh
  0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Ovsiienko @ 2020-11-19 19:18 UTC (permalink / raw)
  To: dev; +Cc: rasland, matan, orika, thomas, iryzhov

xstats names for simple stats are mostly standardized in ethdev drivers
and should be compliant with [1]

[1] http://doc.dpdk.org/guides/prog_guide/poll_mode_drv.html?highlight=xstats#extended-statistics-api

Reported-by: Igor Ryzhov <iryzhov@nfware.com>
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/linux/mlx5_ethdev_os.c | 54 ++++++++++++++++-----------------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index f7ef149..d1ca51a 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1315,71 +1315,71 @@ int mlx5_get_module_eeprom(struct rte_eth_dev *dev,
 
 static const struct mlx5_counter_ctrl mlx5_counters_init[] = {
 	{
-		.dpdk_name = "rx_port_unicast_bytes",
+		.dpdk_name = "rx_unicast_bytes",
 		.ctr_name = "rx_vport_unicast_bytes",
 	},
 	{
-		.dpdk_name = "rx_port_multicast_bytes",
+		.dpdk_name = "rx_multicast_bytes",
 		.ctr_name = "rx_vport_multicast_bytes",
 	},
 	{
-		.dpdk_name = "rx_port_broadcast_bytes",
+		.dpdk_name = "rx_broadcast_bytes",
 		.ctr_name = "rx_vport_broadcast_bytes",
 	},
 	{
-		.dpdk_name = "rx_port_unicast_packets",
+		.dpdk_name = "rx_unicast_packets",
 		.ctr_name = "rx_vport_unicast_packets",
 	},
 	{
-		.dpdk_name = "rx_port_multicast_packets",
+		.dpdk_name = "rx_multicast_packets",
 		.ctr_name = "rx_vport_multicast_packets",
 	},
 	{
-		.dpdk_name = "rx_port_broadcast_packets",
+		.dpdk_name = "rx_broadcast_packets",
 		.ctr_name = "rx_vport_broadcast_packets",
 	},
 	{
-		.dpdk_name = "tx_port_unicast_bytes",
+		.dpdk_name = "tx_unicast_bytes",
 		.ctr_name = "tx_vport_unicast_bytes",
 	},
 	{
-		.dpdk_name = "tx_port_multicast_bytes",
+		.dpdk_name = "tx_multicast_bytes",
 		.ctr_name = "tx_vport_multicast_bytes",
 	},
 	{
-		.dpdk_name = "tx_port_broadcast_bytes",
+		.dpdk_name = "tx_broadcast_bytes",
 		.ctr_name = "tx_vport_broadcast_bytes",
 	},
 	{
-		.dpdk_name = "tx_port_unicast_packets",
+		.dpdk_name = "tx_unicast_packets",
 		.ctr_name = "tx_vport_unicast_packets",
 	},
 	{
-		.dpdk_name = "tx_port_multicast_packets",
+		.dpdk_name = "tx_multicast_packets",
 		.ctr_name = "tx_vport_multicast_packets",
 	},
 	{
-		.dpdk_name = "tx_port_broadcast_packets",
+		.dpdk_name = "tx_broadcast_packets",
 		.ctr_name = "tx_vport_broadcast_packets",
 	},
 	{
-		.dpdk_name = "rx_wqe_err",
+		.dpdk_name = "rx_wqe_errors",
 		.ctr_name = "rx_wqe_err",
 	},
 	{
-		.dpdk_name = "rx_crc_errors_phy",
+		.dpdk_name = "rx_phy_crc_errors",
 		.ctr_name = "rx_crc_errors_phy",
 	},
 	{
-		.dpdk_name = "rx_in_range_len_errors_phy",
+		.dpdk_name = "rx_phy_in_range_len_errors",
 		.ctr_name = "rx_in_range_len_errors_phy",
 	},
 	{
-		.dpdk_name = "rx_symbol_err_phy",
+		.dpdk_name = "rx_phy_symbol_errors",
 		.ctr_name = "rx_symbol_err_phy",
 	},
 	{
-		.dpdk_name = "tx_errors_phy",
+		.dpdk_name = "tx_phy_errors",
 		.ctr_name = "tx_errors_phy",
 	},
 	{
@@ -1388,44 +1388,44 @@ int mlx5_get_module_eeprom(struct rte_eth_dev *dev,
 		.dev = 1,
 	},
 	{
-		.dpdk_name = "tx_packets_phy",
+		.dpdk_name = "tx_phy_packets",
 		.ctr_name = "tx_packets_phy",
 	},
 	{
-		.dpdk_name = "rx_packets_phy",
+		.dpdk_name = "rx_phy_packets",
 		.ctr_name = "rx_packets_phy",
 	},
 	{
-		.dpdk_name = "tx_discards_phy",
+		.dpdk_name = "tx_phy_discard_packets",
 		.ctr_name = "tx_discards_phy",
 	},
 	{
-		.dpdk_name = "rx_discards_phy",
+		.dpdk_name = "rx_phy_discard_packets",
 		.ctr_name = "rx_discards_phy",
 	},
 	{
-		.dpdk_name = "tx_bytes_phy",
+		.dpdk_name = "tx_phy_bytes",
 		.ctr_name = "tx_bytes_phy",
 	},
 	{
-		.dpdk_name = "rx_bytes_phy",
+		.dpdk_name = "rx_phy_bytes",
 		.ctr_name = "rx_bytes_phy",
 	},
 	/* Representor only */
 	{
-		.dpdk_name = "rx_packets",
+		.dpdk_name = "rx_vport_packets",
 		.ctr_name = "vport_rx_packets",
 	},
 	{
-		.dpdk_name = "rx_bytes",
+		.dpdk_name = "rx_vport_bytes",
 		.ctr_name = "vport_rx_bytes",
 	},
 	{
-		.dpdk_name = "tx_packets",
+		.dpdk_name = "tx_vport_packets",
 		.ctr_name = "vport_tx_packets",
 	},
 	{
-		.dpdk_name = "tx_bytes",
+		.dpdk_name = "tx_vport_bytes",
 		.ctr_name = "vport_tx_bytes",
 	},
 };
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: make ethernet xstats names compliant
  2020-11-19 19:18 [dpdk-dev] [PATCH] net/mlx5: make ethernet xstats names compliant Viacheslav Ovsiienko
@ 2020-11-22 12:58 ` Raslan Darawsheh
  0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2020-11-22 12:58 UTC (permalink / raw)
  To: Slava Ovsiienko, dev
  Cc: Matan Azrad, Ori Kam, NBU-Contact-Thomas Monjalon, iryzhov

Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Thursday, November 19, 2020 9:18 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; iryzhov@nfware.com
> Subject: [PATCH] net/mlx5: make ethernet xstats names compliant
> 
> xstats names for simple stats are mostly standardized in ethdev drivers
> and should be compliant with [1]
> 
> [1]
> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdoc.d
> pdk.org%2Fguides%2Fprog_guide%2Fpoll_mode_drv.html%3Fhighlight%3Dx
> stats%23extended-statistics-
> api&amp;data=04%7C01%7Crasland%40nvidia.com%7Cdc0a60ac1fb24742c03
> 208d88cbfe0bf%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63741
> 4103029395985%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC
> JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=v7Ri
> pQbvVRPnj%2FBh7GTym%2FZVl6stIRJ8Qnaqas91wXA%3D&amp;reserved=0
> 
> Reported-by: Igor Ryzhov <iryzhov@nfware.com>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  drivers/net/mlx5/linux/mlx5_ethdev_os.c | 54 ++++++++++++++++----------
> -------
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 19:18 [dpdk-dev] [PATCH] net/mlx5: make ethernet xstats names compliant Viacheslav Ovsiienko
2020-11-22 12:58 ` Raslan Darawsheh

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox