* [dpdk-dev] [PATCH] eal: fix build on armv7
@ 2020-04-23 14:24 David Marchand
2020-04-23 15:36 ` Thomas Monjalon
2020-04-24 17:35 ` David Marchand
0 siblings, 2 replies; 3+ messages in thread
From: David Marchand @ 2020-04-23 14:24 UTC (permalink / raw)
To: dev; +Cc: thomas
Caught by OBS on armv7:
In file included from .../lib/librte_eal/include/rte_string_fns.h:21,
from .../lib/librte_kvargs/rte_kvargs.c:9:
.../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
67 | typedef uint64_t unaligned_uint64_t __rte_aligned(1);
| ^~~~~~~~~~~~~
.../lib/librte_eal/include/rte_common.h:68:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
68 | typedef uint32_t unaligned_uint32_t __rte_aligned(1);
| ^~~~~~~~~~~~~
.../lib/librte_eal/include/rte_common.h:69:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
69 | typedef uint16_t unaligned_uint16_t __rte_aligned(1);
| ^~~~~~~~~~~~~
make[3]: *** [.../mk/internal/rte.compile-pre.mk:116: rte_kvargs.o] Error 1
Fixes: f35e5b3e07b2 ("replace alignment attributes")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/include/rte_common.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_common.h
index 733447b736..668e8b0af8 100644
--- a/lib/librte_eal/include/rte_common.h
+++ b/lib/librte_eal/include/rte_common.h
@@ -63,6 +63,11 @@ extern "C" {
__GNUC_PATCHLEVEL__)
#endif
+/**
+ * Force alignment
+ */
+#define __rte_aligned(a) __attribute__((__aligned__(a)))
+
#ifdef RTE_ARCH_STRICT_ALIGN
typedef uint64_t unaligned_uint64_t __rte_aligned(1);
typedef uint32_t unaligned_uint32_t __rte_aligned(1);
@@ -73,11 +78,6 @@ typedef uint32_t unaligned_uint32_t;
typedef uint16_t unaligned_uint16_t;
#endif
-/**
- * Force alignment
- */
-#define __rte_aligned(a) __attribute__((__aligned__(a)))
-
/**
* Force a structure to be packed
*/
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix build on armv7
2020-04-23 14:24 [dpdk-dev] [PATCH] eal: fix build on armv7 David Marchand
@ 2020-04-23 15:36 ` Thomas Monjalon
2020-04-24 17:35 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-04-23 15:36 UTC (permalink / raw)
To: David Marchand; +Cc: dev
23/04/2020 16:24, David Marchand:
> Caught by OBS on armv7:
>
> In file included from .../lib/librte_eal/include/rte_string_fns.h:21,
> from .../lib/librte_kvargs/rte_kvargs.c:9:
> .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__rte_aligned'
> 67 | typedef uint64_t unaligned_uint64_t __rte_aligned(1);
> | ^~~~~~~~~~~~~
> .../lib/librte_eal/include/rte_common.h:68:37: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__rte_aligned'
> 68 | typedef uint32_t unaligned_uint32_t __rte_aligned(1);
> | ^~~~~~~~~~~~~
> .../lib/librte_eal/include/rte_common.h:69:37: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__rte_aligned'
> 69 | typedef uint16_t unaligned_uint16_t __rte_aligned(1);
> | ^~~~~~~~~~~~~
> make[3]: *** [.../mk/internal/rte.compile-pre.mk:116: rte_kvargs.o] Error 1
>
> Fixes: f35e5b3e07b2 ("replace alignment attributes")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
It deserves few words explanation about RTE_ARCH_STRICT_ALIGN.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix build on armv7
2020-04-23 14:24 [dpdk-dev] [PATCH] eal: fix build on armv7 David Marchand
2020-04-23 15:36 ` Thomas Monjalon
@ 2020-04-24 17:35 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-04-24 17:35 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon
On Thu, Apr 23, 2020 at 4:25 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Caught by OBS on armv7:
>
> In file included from .../lib/librte_eal/include/rte_string_fns.h:21,
> from .../lib/librte_kvargs/rte_kvargs.c:9:
> .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__rte_aligned'
> 67 | typedef uint64_t unaligned_uint64_t __rte_aligned(1);
> | ^~~~~~~~~~~~~
> .../lib/librte_eal/include/rte_common.h:68:37: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__rte_aligned'
> 68 | typedef uint32_t unaligned_uint32_t __rte_aligned(1);
> | ^~~~~~~~~~~~~
> .../lib/librte_eal/include/rte_common.h:69:37: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__rte_aligned'
> 69 | typedef uint16_t unaligned_uint16_t __rte_aligned(1);
> | ^~~~~~~~~~~~~
> make[3]: *** [.../mk/internal/rte.compile-pre.mk:116: rte_kvargs.o] Error 1
>
> Fixes: f35e5b3e07b2 ("replace alignment attributes")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied with mention of RTE_ARCH_STRICT_ALIGN in commitlog.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-24 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 14:24 [dpdk-dev] [PATCH] eal: fix build on armv7 David Marchand
2020-04-23 15:36 ` Thomas Monjalon
2020-04-24 17:35 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).