* [dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo
@ 2016-11-23 12:56 Ilya Matveychikov
2016-11-23 15:43 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ilya Matveychikov @ 2016-11-23 12:56 UTC (permalink / raw)
To: dev
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
---
examples/ip_pipeline/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
index 5827117..6657237 100644
--- a/examples/ip_pipeline/Makefile
+++ b/examples/ip_pipeline/Makefile
@@ -36,7 +36,7 @@ endif
# Default target, can be overridden by command line or environment
RTE_TARGET ?= x86_64-native-linuxapp-gcc
-DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
+DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
include $(RTE_SDK)/mk/rte.vars.mk
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo
2016-11-23 12:56 [dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo Ilya Matveychikov
@ 2016-11-23 15:43 ` Ferruh Yigit
2017-01-17 17:22 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2016-11-23 15:43 UTC (permalink / raw)
To: matvejchikov, dev
On 11/23/2016 12:56 PM, Ilya Matveychikov wrote:
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> ---
> examples/ip_pipeline/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
> index 5827117..6657237 100644
> --- a/examples/ip_pipeline/Makefile
> +++ b/examples/ip_pipeline/Makefile
> @@ -36,7 +36,7 @@ endif
> # Default target, can be overridden by command line or environment
> RTE_TARGET ?= x86_64-native-linuxapp-gcc
>
> -DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> +DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
No need to fix, this line can be removed completely.
Because of:
VPATH += $(SRCDIR)/pipeline
and files handled in this makefile:
SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c
When you fix DIR-y, you also need to add a makefile to pipeline folder
and update this makefile. I guess all those are not required. Just
removing that line is easier J
>
> include $(RTE_SDK)/mk/rte.vars.mk
>
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo
2016-11-23 15:43 ` Ferruh Yigit
@ 2017-01-17 17:22 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-01-17 17:22 UTC (permalink / raw)
To: Ferruh Yigit, matvejchikov; +Cc: dev
2016-11-23 15:43, Ferruh Yigit:
> On 11/23/2016 12:56 PM, Ilya Matveychikov wrote:
> > Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> > ---
> > examples/ip_pipeline/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
> > index 5827117..6657237 100644
> > --- a/examples/ip_pipeline/Makefile
> > +++ b/examples/ip_pipeline/Makefile
> > @@ -36,7 +36,7 @@ endif
> > # Default target, can be overridden by command line or environment
> > RTE_TARGET ?= x86_64-native-linuxapp-gcc
> >
> > -DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
> > +DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
>
> No need to fix, this line can be removed completely.
>
> Because of:
> VPATH += $(SRCDIR)/pipeline
>
> and files handled in this makefile:
> SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c
>
> When you fix DIR-y, you also need to add a makefile to pipeline folder
> and update this makefile. I guess all those are not required. Just
> removing that line is easier J
There was no progress on this trivial patch.
So I made what Ferruh suggested and applied in the tree directly:
http://dpdk.org/commit/45e1c8b
Thanks for the report and the review.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-17 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-23 12:56 [dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo Ilya Matveychikov
2016-11-23 15:43 ` Ferruh Yigit
2017-01-17 17:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).